Index: src/java/org/apache/hadoop/hbase/master/RootScanner.java =================================================================== --- src/java/org/apache/hadoop/hbase/master/RootScanner.java (revision 736069) +++ src/java/org/apache/hadoop/hbase/master/RootScanner.java (working copy) @@ -28,7 +28,6 @@ class RootScanner extends BaseScanner { /** * Constructor - * * @param master */ public RootScanner(HMaster master) { @@ -35,7 +34,7 @@ super(master, true, master.metaRescanInterval, master.closed); } - /* + /** * Don't retry if we get an error while scanning. Errors are most often * * caused by the server going away. Wait until next rescan interval when Index: src/java/org/apache/hadoop/hbase/master/ServerManager.java =================================================================== --- src/java/org/apache/hadoop/hbase/master/ServerManager.java (revision 736069) +++ src/java/org/apache/hadoop/hbase/master/ServerManager.java (working copy) @@ -50,7 +50,7 @@ * load numbers, dying servers, etc. */ class ServerManager implements HConstants { - private static final Log LOG = + static final Log LOG = LogFactory.getLog(ServerManager.class.getName()); private final AtomicInteger quiescedServers = new AtomicInteger(0); @@ -101,7 +101,7 @@ getInt("hbase.regions.nobalancing.count", 4); } - /* + /** * Look to see if we have ghost references to this regionserver such as * still-existing leases or if regionserver is on the dead servers list * getting its logs processed. @@ -337,7 +337,8 @@ } } - /* RegionServer is checking in, no exceptional circumstances + /** + * RegionServer is checking in, no exceptional circumstances * @param serverName * @param serverInfo * @param mostLoadedRegions @@ -739,7 +740,6 @@ /** Instantiated to monitor the health of a region server */ private class ServerExpirer implements LeaseListener { - @SuppressWarnings("hiding") private String server; ServerExpirer(String server) { Index: src/java/org/apache/hadoop/hbase/master/TableDelete.java =================================================================== --- src/java/org/apache/hadoop/hbase/master/TableDelete.java (revision 736069) +++ src/java/org/apache/hadoop/hbase/master/TableDelete.java (working copy) @@ -41,10 +41,8 @@ } @Override - protected void processScanItem( - @SuppressWarnings("unused") String serverName, - @SuppressWarnings("unused") long startCode, - final HRegionInfo info) throws IOException { + protected void processScanItem(String serverName, + long startCode, final HRegionInfo info) throws IOException { if (isEnabled(info)) { throw new TableNotDisabledException(tableName); Index: src/java/org/apache/hadoop/hbase/master/ModifyTableMeta.java =================================================================== --- src/java/org/apache/hadoop/hbase/master/ModifyTableMeta.java (revision 736069) +++ src/java/org/apache/hadoop/hbase/master/ModifyTableMeta.java (working copy) @@ -57,10 +57,8 @@ } @Override - protected void processScanItem( - @SuppressWarnings("unused") String serverName, - @SuppressWarnings("unused") long startCode, final HRegionInfo info) - throws IOException { + protected void processScanItem(String serverName, long startCode, + final HRegionInfo info) throws IOException { if (isEnabled(info)) { throw new TableNotDisabledException(tableName.toString()); } Index: src/java/org/apache/hadoop/hbase/master/ColumnOperation.java =================================================================== --- src/java/org/apache/hadoop/hbase/master/ColumnOperation.java (revision 736069) +++ src/java/org/apache/hadoop/hbase/master/ColumnOperation.java (working copy) @@ -38,10 +38,8 @@ } @Override - protected void processScanItem( - @SuppressWarnings("unused") String serverName, - @SuppressWarnings("unused") long startCode, final HRegionInfo info) - throws IOException { + protected void processScanItem(String serverName, long startCode, + final HRegionInfo info) throws IOException { if (isEnabled(info)) { throw new TableNotDisabledException(tableName); } @@ -48,8 +46,7 @@ } protected void updateRegionInfo(HRegionInterface server, byte [] regionName, - HRegionInfo i) - throws IOException { + HRegionInfo i) throws IOException { BatchUpdate b = new BatchUpdate(i.getRegionName()); b.put(COL_REGIONINFO, Writables.getBytes(i)); server.batchUpdate(regionName, b, -1L); Index: src/java/org/apache/hadoop/hbase/master/NotAllMetaRegionsOnlineException.java =================================================================== --- src/java/org/apache/hadoop/hbase/master/NotAllMetaRegionsOnlineException.java (revision 736069) +++ src/java/org/apache/hadoop/hbase/master/NotAllMetaRegionsOnlineException.java (working copy) @@ -25,8 +25,9 @@ /** * Thrown when an operation requires the root and all meta regions to be online */ -@SuppressWarnings("serial") public class NotAllMetaRegionsOnlineException extends DoNotRetryIOException { + private static final long serialVersionUID = 6439786157874827523L; + /** * default constructor */ Index: src/java/org/apache/hadoop/hbase/master/HMaster.java =================================================================== --- src/java/org/apache/hadoop/hbase/master/HMaster.java (revision 736069) +++ src/java/org/apache/hadoop/hbase/master/HMaster.java (working copy) @@ -94,8 +94,8 @@ static final Log LOG = LogFactory.getLog(HMaster.class.getName()); - public long getProtocolVersion(@SuppressWarnings("unused") String protocol, - @SuppressWarnings("unused") long clientVersion) { + public long getProtocolVersion(String protocol, + long clientVersion) { return HBaseRPCProtocolVersion.versionID; }