Index: src/test/org/apache/lucene/search/TestThreadSafe.java =================================================================== --- src/test/org/apache/lucene/search/TestThreadSafe.java (revision 596366) +++ src/test/org/apache/lucene/search/TestThreadSafe.java (working copy) @@ -117,7 +117,7 @@ for (int i=0; i 0x7e) { String s = "0000" + Integer.toString(ch, 16); - retval.append("\\u" + s.substring(s.length() - 4, s.length())); + retval.append("\\u").append(s.substring(s.length() - 4, s.length())); } else { retval.append(ch); } Index: src/java/org/apache/lucene/queryParser/ParseException.java =================================================================== --- src/java/org/apache/lucene/queryParser/ParseException.java (revision 596366) +++ src/java/org/apache/lucene/queryParser/ParseException.java (working copy) @@ -179,7 +179,7 @@ default: if ((ch = str.charAt(i)) < 0x20 || ch > 0x7e) { String s = "0000" + Integer.toString(ch, 16); - retval.append("\\u" + s.substring(s.length() - 4, s.length())); + retval.append("\\u").append(s.substring(s.length() - 4, s.length())); } else { retval.append(ch); } Index: src/java/org/apache/lucene/analysis/PorterStemmer.java =================================================================== --- src/java/org/apache/lucene/analysis/PorterStemmer.java (revision 596366) +++ src/java/org/apache/lucene/analysis/PorterStemmer.java (working copy) @@ -83,8 +83,7 @@ public void add(char ch) { if (b.length <= i + EXTRA) { char[] new_b = new char[b.length+INC]; - for (int c = 0; c < b.length; c++) - new_b[c] = b[c]; + System.arraycopy(b, 0, new_b, 0, b.length); b = new_b; } b[i++] = ch; @@ -454,8 +453,7 @@ char[] new_b = new char[wordLen + EXTRA]; b = new_b; } - for (int j=0; j"); break; - case CUSTOM: buffer.append (""); + case CUSTOM: + buffer.append("'); break; - default: buffer.append("\"" + field + "\""); + default: + buffer.append('\"').append(field).append('\"'); break; } - if (locale != null) buffer.append ("("+locale+")"); + if (locale != null) buffer.append('(').append(locale).append(')'); if (reverse) buffer.append('!'); return buffer.toString(); Index: src/java/org/apache/lucene/index/ParallelReader.java =================================================================== --- src/java/org/apache/lucene/index/ParallelReader.java (revision 596366) +++ src/java/org/apache/lucene/index/ParallelReader.java (working copy) @@ -120,7 +120,7 @@ if (incRefReaders) { reader.incRef(); } - decrefOnClose.add(new Boolean(incRefReaders)); + decrefOnClose.add(Boolean.valueOf(incRefReaders)); } /** @@ -170,12 +170,12 @@ IndexReader oldReader = (IndexReader) readers.get(i); IndexReader newReader = (IndexReader) newReaders.get(i); if (newReader == oldReader) { - newDecrefOnClose.add(new Boolean(true)); + newDecrefOnClose.add(Boolean.TRUE); newReader.incRef(); } else { // this is a new subreader instance, so on close() we don't // decRef but close it - newDecrefOnClose.add(new Boolean(false)); + newDecrefOnClose.add(Boolean.FALSE); } pr.add(newReader, !storedFieldReaders.contains(oldReader)); } Index: src/java/org/apache/lucene/index/MergePolicy.java =================================================================== --- src/java/org/apache/lucene/index/MergePolicy.java (revision 596366) +++ src/java/org/apache/lucene/index/MergePolicy.java (working copy) @@ -115,7 +115,7 @@ b.append(segments.info(i).segString(dir)); } if (info != null) - b.append(" into " + info.name); + b.append(" into ").append(info.name); if (optimize) b.append(" [optimize]"); return b.toString(); @@ -145,7 +145,7 @@ b.append("MergeSpec:\n"); final int count = merges.size(); for(int i=0;i 0x7e) { String s = "0000" + Integer.toString(ch, 16); - retval.append("\\u" + s.substring(s.length() - 4, s.length())); + retval.append("\\u").append(s.substring(s.length() - 4, s.length())); } else { retval.append(ch); } Index: src/demo/org/apache/lucene/demo/html/HTMLParser.java =================================================================== --- src/demo/org/apache/lucene/demo/html/HTMLParser.java (revision 596366) +++ src/demo/org/apache/lucene/demo/html/HTMLParser.java (working copy) @@ -627,9 +627,7 @@ jj_lasttokens[jj_endpos++] = kind; } else if (jj_endpos != 0) { jj_expentry = new int[jj_endpos]; - for (int i = 0; i < jj_endpos; i++) { - jj_expentry[i] = jj_lasttokens[i]; - } + System.arraycopy(jj_lasttokens, 0, jj_expentry, 0, jj_endpos); boolean exists = false; for (java.util.Enumeration e = jj_expentries.elements(); e.hasMoreElements();) { int[] oldentry = (int[])(e.nextElement()); Index: src/demo/org/apache/lucene/demo/html/ParseException.java =================================================================== --- src/demo/org/apache/lucene/demo/html/ParseException.java (revision 596366) +++ src/demo/org/apache/lucene/demo/html/ParseException.java (working copy) @@ -179,7 +179,7 @@ default: if ((ch = str.charAt(i)) < 0x20 || ch > 0x7e) { String s = "0000" + Integer.toString(ch, 16); - retval.append("\\u" + s.substring(s.length() - 4, s.length())); + retval.append("\\u").append(s.substring(s.length() - 4, s.length())); } else { retval.append(ch); }