Index: /home/tverhagen/dev_ext/ivy/src/java/org/apache/ivy/util/filter/FilterHelper.java =================================================================== --- /home/tverhagen/dev_ext/ivy/src/java/org/apache/ivy/util/filter/FilterHelper.java (revision 552422) +++ /home/tverhagen/dev_ext/ivy/src/java/org/apache/ivy/util/filter/FilterHelper.java (working copy) @@ -33,7 +33,8 @@ return NO_FILTER; } String[] t = types.split(","); - List acceptedTypes = new ArrayList(types.length()); + // TODO [2007.06.28] Check if types.length() shouldn't be t.length(). + List acceptedTypes = new ArrayList(types.length()); for (int i = 0; i < t.length; i++) { acceptedTypes.add(t[i].trim()); } @@ -41,12 +42,16 @@ } /** - * we could have used commons-collections facility for this... if we accepted to add - * dependencies on third party jars + * Returns a new collection containing only the items from the given collectoin, which are + * accepted by the filter. * - * @param col - * @param filter - * @return + * @param col The collection to filter. + * @param filter The filter to use. + * @return A new collection instance containing the only the instance accepted by the filter. + * + *
+ * Comment: We could have used Commons-Collections + * facility for this. If we accepted to add dependencies on third party jars. */ public static Collection filter(Collection col, Filter filter) { if (filter == null) {