Fixed
------------------------------------

1.
class: org.apache.jetspeed.demo.simple.AttributeScopeServlet
fixed: 1) APPLICATION_SCOPE_NAME was set to wrong value 2) used Long.valueOf instead of constructor

2. 
class: org.apache.portals.gems.util.ValidationHelper
fixed: made static constant vars final

3.
class: org.apache.jetspeed.portlets.palm
fixed: fixed null dereference

4. CHECK
class: org.apache.jetspeed.portlets.profiler.ProfileCriterionForm
fixed: made fallbackTypes and resolvers static final to eliminate deserialization issues

5. CHECK
class: org.apache.jetspeed.portlets.profiler.ProfileRuleForm
fixed: made classnames static final to eliminate deserialization issues

6. CHECK
class: org.apache.jetspeed.portlets.rpad.RepositoryConfigHandler
fixed: fixed compare with non-related object with different type

7. 
class: org.apache.jetspeed.util.JetspeedLongObjectID
fixed: made class serializable

8.
class: org.apache.jetspeed.capabilities.impl.CapabilityMapImpl
fixed: use equals() instead of == in string compare

9. CHECK
class: org.apache.jetspeed.locator.JetspeedTemplateLocator
fixed: 1) remove potential NPE and 2) make code compacter, remove double code

10. 
class: org.apache.jetspeed.om.folder.psml
fixed: made constant var static

11. 
class: org.apache.jetspeed.decoration.DecorationFactoryImpl
fixed: replace useless equals() call with intended warn() call

12. 
classes in package org.apache.jetspeed.layout.impl: AddPortletAction, GetPortletsAction and MovePortletAction
fixed: use private logger instead of masking base class logger

13.
class: org.apache.jetspeed.portalsite.impl.PortalSiteSessionContextImpl
fixed: replace direct calls to folderPageHistory var with get method, to avoid deserialization issues

14.
class:org.apache.jetspeed.components.portletregistry.MutablePortletApplicationProxy
fixed: remove useless equals() method

15. 
class: org.apache.jetspeed.om.impl.LanguageSetImpl
fixed: make classloader transient

16.
class: org.apache.jetspeed.om.portlet.impl.PortletApplicationDefinitionImpl
fixed: made var webApplication transient

17. CHECK
class: org.apache.jetspeed.om.preference.impl.PrefsPreference
fixed: remove infinite loop in method cloneValues()

18.
class: org.apache.jetspeed.om.preference.impl.PrefsPreferenceSetImpl
fixed: make class serializable

19.
class: org.apache.jetspeed.om.window.impl.PortletWindowImpl
fixed: make var portletEntity transient

20.
class: org.apache.jetspeed.security.PolicyWrapper
fixed: make var policy transient

21. 
class: org.apache.jetspeed.security.spi.impl.PasswordHistoryInterceptor
fixed: made constant var final

22.
class: org.apache.jetspeed.serializer.objects.JSPermission
fixed: 1) made constant vars final , 2) replaced all == string comparisons with .equals() calls

23.
class: org.apache.jetspeed.sso.TestSSOComponent
fixed: use base class vars + initialization instead of redefining them

24.
class: org.apache.jetspeed.statistics.impl.UserStatsImpl
fixed: fix broken equals() method, which always returned true when comparing same type objects

25. 
class: org.apache.jetspeed.om.common.preference.


Remaining dubious / buggy code:
------------------------------------
1. H B Se: Class org.apache.jetspeed.om.preference.impl.PrefsPreferenceSetImpl defines non-transient non-serializable instance field prefsRootNode	jetspeed-2/components/registry/src/java/org/apache/jetspeed/om/preference/impl	PrefsPreferenceSetImpl.java	line 43	1181473715648	26460

2. H B Se: The field org.apache.jetspeed.portlet.webcontent.WebContentResource.content is transient but isn't set by deserialization	jetspeed-2/components/web-content/src/java/org/apache/jetspeed/portlet/webcontent	WebContentResource.java	line 32	1181473715757	26498

3. H C UMAC: Uncallable method org.apache.jetspeed.serializer.objects.JSNVPElement$1.isReferencable() defined in anonymous class	jetspeed-2/components/serializer/src/java/org/apache/jetspeed/serializer/objects	JSNVPElement.java	line 1	1181473854014	27195

4. H D DLS: Dead store to lastGuess in org.apache.jetspeed.demo.simple.PickANumberPortlet.doView(RenderRequest, RenderResponse)	jetspeed-2/applications/demo/src/java/org/apache/jetspeed/demo/simple	PickANumberPortlet.java	line 151	1181473853827	26876

5. H P Dm: org.apache.jetspeed.engine.JetspeedEngine.shutdown() forces garbage collection; extremely dubious except in benchmarking code	jetspeed-2/components/portal/src/java/org/apache/jetspeed/engine	JetspeedEngine.java	line 174	1181473853843	26893