Index: get-involved.xml
===================================================================
--- get-involved.xml (revision 495534)
+++ get-involved.xml (working copy)
@@ -69,85 +69,100 @@
- You may have heard or read about Harmony's strict rules for contributor's
- eligibility. We take this seriously because a number of parties implement
- Java, and we respect their rights to their property. If you have detailed
- knowledge of another implementation of Java, and they have not explicitly
- approved your participation in Harmony, please check whether we will be able
- to accept your contribution by reading the
- Apache Harmony contribution policy.
-
+ You may have heard or read about Harmony's strict rules for contributor's
+ eligibility. We take this seriously because a number of parties implement
+ Java, and we respect their rights to their property. If you have detailed
+ knowledge of another implementation of Java, and they have not explicitly
+ approved your participation in Harmony, please check whether we will be able
+ to accept your contribution by reading the
+ Apache Harmony contribution policy.
+
+
One of the best ways to get involved in the Harmony project is to
- create patches or additions and contribute them. All contributions
- should be made via a new entry in our project
+ create patches or additions and contribute them. When you propose
+ a specific change to the software for discussion or voting on the
+ mailing list, you should present in the form of input to the patch
+ command.
+ All contributions should be made via a new entry in our project
JIRA.
- Here are some basic guidelines and suggestions :
-
-
-
- Once you are sure you have tested/reviewed your changes, open a - new JIRA entry. Clearly describe the patch or enhancement, and - provide details, such as how to re-create if a bug, why the - change or enhancement is useful, etc. Then, attach all materials - to the JIRA entry via "Attach File". Please be sure to select - "Grant license to ASF for inclusion in ASF works...". Any patch - without this grant will be rejected. -
+- Please use the subversion 'diff' utility to create a patch as follows : - -
- svn diff file.java > file.patch -- - where 'file' is the filename that you have changed. This will produce a - nice patch file that can be added to the JIRA, which makes it easy for - the project committers to review and possibly accept your patch. - - - - - +
+ Once you are sure you have tested/reviewed your changes, do the following: +
+diff utility to create a patch as follows:
+ svn diff file.java > file.patch+ where
file is the filename that you have changed. This will produce a
+ nice patch file that can be added to the
+ JIRA, which makes it easy for
+ the project committers to review and possibly accept your patch.
+ Example
+diff -u http_main.c.orig http_main.c >> patchfile.txt+ Note that the
diff command only shows differences for text files, and
+ not binary files. So even if you did svn add on a binary file (gif, jar,
+ png etc.), it won't show up in the patch, and will fail to apply. The
+ key string to look out for in the patch is:
+ Cannot display: file marked as a binary type.+ If you see that, you'll also need to attach the binary files that have changed + separately to the issue. To get a list of such files in
file.patch, run:
+ grep -B 2 "Cannot display" file.patch+