Index: src/main/java/common/javax/swing/JSlider.java =================================================================== --- src/main/java/common/javax/swing/JSlider.java (revision 495368) +++ src/main/java/common/javax/swing/JSlider.java (working copy) @@ -116,12 +116,16 @@ } public JSlider(final int orientation, final int min, final int max, final int value) { - this(new DefaultBoundedRangeModel(value, 0, min, max)); - this.orientation = orientation; + this(checkOrientation(orientation), + new DefaultBoundedRangeModel(value, 0, min, max)); } public JSlider(final BoundedRangeModel brm) { - this.orientation = HORIZONTAL; + this(HORIZONTAL, brm); + } + + private JSlider(final int orientation, final BoundedRangeModel brm) { + this.orientation = orientation; sliderModel = brm; modelChangeHandler = createChangeListener(); @@ -132,6 +136,13 @@ updateUI(); } + private static int checkOrientation(final int orientation) { + if (orientation != VERTICAL && orientation != HORIZONTAL) { + throw new IllegalArgumentException("orientation must be one of: VERTICAL, HORIZONTAL"); + } + return orientation; + } + public SliderUI getUI() { return (SliderUI)ui; }