Index: src/java/org/apache/commons/httpclient/HostConfiguration.java =================================================================== --- src/java/org/apache/commons/httpclient/HostConfiguration.java (revision 345878) +++ src/java/org/apache/commons/httpclient/HostConfiguration.java (working copy) @@ -503,7 +503,7 @@ /** * @see java.lang.Object#hashCode() */ - public int hashCode() { + public synchronized int hashCode() { int hash = LangUtils.HASH_SEED; hash = LangUtils.hashCode(hash, this.host); hash = LangUtils.hashCode(hash, this.proxyHost); Index: src/java/org/apache/commons/httpclient/auth/DigestScheme.java =================================================================== --- src/java/org/apache/commons/httpclient/auth/DigestScheme.java (revision 345878) +++ src/java/org/apache/commons/httpclient/auth/DigestScheme.java (working copy) @@ -459,10 +459,8 @@ String uri = getParameter("uri"); String realm = getParameter("realm"); String nonce = getParameter("nonce"); - String nc = getParameter("nc"); String opaque = getParameter("opaque"); String response = digest; - String qop = getParameter("qop"); String algorithm = getParameter("algorithm"); List params = new ArrayList(20); Index: src/java/org/apache/commons/httpclient/auth/AuthScope.java =================================================================== --- src/java/org/apache/commons/httpclient/auth/AuthScope.java (revision 345878) +++ src/java/org/apache/commons/httpclient/auth/AuthScope.java (working copy) @@ -69,7 +69,7 @@ * In the future versions of HttpClient the use of this parameter will be * discontinued. */ - public static AuthScope ANY = new AuthScope(ANY_HOST, ANY_PORT, ANY_REALM, ANY_SCHEME); + public static final AuthScope ANY = new AuthScope(ANY_HOST, ANY_PORT, ANY_REALM, ANY_SCHEME); /** The authentication scheme the credentials apply to. */ private String scheme = null; Index: src/java/org/apache/commons/httpclient/methods/multipart/FilePart.java =================================================================== --- src/java/org/apache/commons/httpclient/methods/multipart/FilePart.java (revision 345878) +++ src/java/org/apache/commons/httpclient/methods/multipart/FilePart.java (working copy) @@ -71,7 +71,7 @@ protected static final String FILE_NAME = "; filename="; /** Attachment's file name as a byte array */ - protected static final byte[] FILE_NAME_BYTES = + private static final byte[] FILE_NAME_BYTES = EncodingUtil.getAsciiBytes(FILE_NAME); /** Source of the file part. */ Index: src/java/org/apache/commons/httpclient/params/DefaultHttpParamsFactory.java =================================================================== --- src/java/org/apache/commons/httpclient/params/DefaultHttpParamsFactory.java (revision 345878) +++ src/java/org/apache/commons/httpclient/params/DefaultHttpParamsFactory.java (working copy) @@ -39,8 +39,6 @@ import org.apache.commons.httpclient.util.DateUtil; /** - * TODO: comment type - * * @since 3.0 */ public class DefaultHttpParamsFactory implements HttpParamsFactory { Index: src/java/org/apache/commons/httpclient/params/HttpClientParams.java =================================================================== --- src/java/org/apache/commons/httpclient/params/HttpClientParams.java (revision 345878) +++ src/java/org/apache/commons/httpclient/params/HttpClientParams.java (working copy) @@ -199,12 +199,12 @@ public void makeStrict() { super.makeStrict(); - setParameters(PROTOCOL_STRICTNESS_PARAMETERS, new Boolean(true)); + setParameters(PROTOCOL_STRICTNESS_PARAMETERS, Boolean.TRUE); } public void makeLenient() { super.makeLenient(); - setParameters(PROTOCOL_STRICTNESS_PARAMETERS, new Boolean(false)); + setParameters(PROTOCOL_STRICTNESS_PARAMETERS, Boolean.FALSE); } } Index: src/java/org/apache/commons/httpclient/params/HttpMethodParams.java =================================================================== --- src/java/org/apache/commons/httpclient/params/HttpMethodParams.java (revision 345878) +++ src/java/org/apache/commons/httpclient/params/HttpMethodParams.java (working copy) @@ -475,7 +475,7 @@ * strictly adhere to the HTTP specification. */ public void makeStrict() { - setParameters(PROTOCOL_STRICTNESS_PARAMETERS, new Boolean(true)); + setParameters(PROTOCOL_STRICTNESS_PARAMETERS, Boolean.TRUE); setIntParameter(STATUS_LINE_GARBAGE_LIMIT, 0); } @@ -486,7 +486,7 @@ * the HTTP protocol specification (RFC 2616 and other relevant RFCs). */ public void makeLenient() { - setParameters(PROTOCOL_STRICTNESS_PARAMETERS, new Boolean(false)); + setParameters(PROTOCOL_STRICTNESS_PARAMETERS, Boolean.FALSE); setIntParameter(STATUS_LINE_GARBAGE_LIMIT, Integer.MAX_VALUE); } Index: src/java/org/apache/commons/httpclient/params/HttpConnectionManagerParams.java =================================================================== --- src/java/org/apache/commons/httpclient/params/HttpConnectionManagerParams.java (revision 345878) +++ src/java/org/apache/commons/httpclient/params/HttpConnectionManagerParams.java (working copy) @@ -62,7 +62,7 @@ * {@link org.apache.commons.httpclient.HostConfiguration#ANY_HOST_CONFIGURATION}. *

*/ - public static String MAX_HOST_CONNECTIONS = "http.connection-manager.max-per-host"; + public static final String MAX_HOST_CONNECTIONS = "http.connection-manager.max-per-host"; /** * Defines the maximum number of connections allowed overall. This value only applies @@ -71,7 +71,7 @@ * This parameter expects a value of type {@link Integer}. *

*/ - public static String MAX_TOTAL_CONNECTIONS = "http.connection-manager.max-total"; + public static final String MAX_TOTAL_CONNECTIONS = "http.connection-manager.max-total"; /** * Sets the default maximum number of connections allowed for a given Index: src/java/org/apache/commons/httpclient/HttpClient.java =================================================================== --- src/java/org/apache/commons/httpclient/HttpClient.java (revision 345878) +++ src/java/org/apache/commons/httpclient/HttpClient.java (working copy) @@ -389,7 +389,7 @@ } HttpMethodDirector methodDirector = new HttpMethodDirector( - this.httpConnectionManager, + getHttpConnectionManager(), hostconfig, this.params, (state == null ? getState() : state)); Index: src/java/org/apache/commons/httpclient/ProxyClient.java =================================================================== --- src/java/org/apache/commons/httpclient/ProxyClient.java (revision 345878) +++ src/java/org/apache/commons/httpclient/ProxyClient.java (working copy) @@ -261,7 +261,7 @@ /** * A connection manager that creates a single connection. Meant to be used only once. */ - class DummyConnectionManager implements HttpConnectionManager { + static class DummyConnectionManager implements HttpConnectionManager { private HttpConnection httpConnection; Index: src/java/org/apache/commons/httpclient/StatusLine.java =================================================================== --- src/java/org/apache/commons/httpclient/StatusLine.java (revision 345878) +++ src/java/org/apache/commons/httpclient/StatusLine.java (working copy) @@ -129,7 +129,7 @@ throw new HttpException("Status-Line '" + statusLine + "' is not valid"); } //save the original Status-Line - this.statusLine = new String(statusLine); + this.statusLine = statusLine; } Index: src/java/org/apache/commons/httpclient/util/LangUtils.java =================================================================== --- src/java/org/apache/commons/httpclient/util/LangUtils.java (revision 345878) +++ src/java/org/apache/commons/httpclient/util/LangUtils.java (working copy) @@ -39,8 +39,8 @@ */ public class LangUtils { - public static int HASH_SEED = 17; - public static int HASH_OFFSET = 37; + public static final int HASH_SEED = 17; + public static final int HASH_OFFSET = 37; private LangUtils() { super(); Index: src/java/org/apache/commons/httpclient/util/IdleConnectionTimeoutThread.java =================================================================== --- src/java/org/apache/commons/httpclient/util/IdleConnectionTimeoutThread.java (revision 345878) +++ src/java/org/apache/commons/httpclient/util/IdleConnectionTimeoutThread.java (working copy) @@ -45,7 +45,7 @@ private List connectionManagers = new ArrayList(); - private boolean shutdown = false; + private volatile boolean shutdown = false; private long timeoutInterval = 1000; @@ -117,7 +117,7 @@ * * @see HttpConnectionManager#closeIdleConnections(long) */ - public void setConnectionTimeout(long connectionTimeout) { + public synchronized void setConnectionTimeout(long connectionTimeout) { if (shutdown) { throw new IllegalStateException("IdleConnectionTimeoutThread has been shutdown"); } @@ -129,7 +129,7 @@ * * @param timeoutInterval The timeout interval in milliseconds */ - public void setTimeoutInterval(long timeoutInterval) { + public synchronized void setTimeoutInterval(long timeoutInterval) { if (shutdown) { throw new IllegalStateException("IdleConnectionTimeoutThread has been shutdown"); }