Source changes - FishEye

Shows the 20 most recent commits for Apache Flex.

Mihai Chira <mihaic@apache.org> committed 4c60183258caf23020d7398f6d2ffdab747d0e56 (3 files)
Reviews: none

FLEX-35362 CAUSE: the DropDownController signals that the DropDownListBase is open immediately, even before the latter has actually made that change on stage. Since the opening takes one or two frames, it leaves a few milliseconds in which code which relies on that open/closed state erroneously assumes that it can use elements that should be on stage or initialized. In this case it's the layout property, which, due to the skin of the DropDownList, is only initialized once the drop down is actually open.
SOLUTION: we check whether the layout is not-null, and if it is, we select items in the list as if it were closed.

NOTES:
-also edited some comments, simplified Array instantiation, and removed an empty constructor.
-now the unit test will pass.

Mihai Chira <mihaic@apache.org> committed 23a306cc8a08bfb21165aed7647a4f1ba6edbc4b (1 file)
Reviews: none

FLEX-35362 Added unit test to reproduce the bug. As expected, it currently fails.

DESKTOP-RH4S838\Yishay <yishayjobs@hotmail.com> committed 90886a1dc49f7c9b2249a6952d9aa6e84a007124 (0 files)
Reviews: none

Merge branch 'develop' of https://git-wip-us.apache.org/repos/asf/flex-asjs into develop

DESKTOP-RH4S838\Yishay <yishayjobs@hotmail.com> committed 157927e3a28c1c7740d91c43a303a41dd87b5689 (0 files)
Reviews: none

Merge branch 'develop' of https://git-wip-us.apache.org/repos/asf/flex-asjs into develop

Harbs <harbs@in-tools.com> committed ccde57d110b1775b46cf9fc90a5fb6850fe8aa8d (0 files)
Reviews: none

Merge branch 'develop' of https://git-wip-us.apache.org/repos/asf/flex-asjs into develop
* 'develop' of https://git-wip-us.apache.org/repos/asf/flex-asjs:
  try to fix build. CI server gets a different version of GCL from the Falcon jenkins.xml

Peter Ent <pent@apache.org> committed 1b1697a0f65c0fccea58726bf9c6cb23121da849 (1 file)
Reviews: none

Merge branch 'develop' into feature/dragAndDrop
* develop: (24 commits)
  Allow chained assignment to non-existent children
  Add MDLDynamicTableExample to ilustrate how add/remove items to MDL Table - Currently only adding is working. The rest job will be done as part of FLEX-35354
  Forgot header
  Returns parameter passed into setAttribute and setChild to enable chained assignment of values.
  Added missing pieces for TextBlock management Fixed bug in GroupElement.replaceElements()
  Added helper function
  FLEX-35354 - Rename TabsItemRendererFactoryForArrayListData to TabsDynamicItemsRendererFactoryForArrayListData - Update TabsDynamicItemsRendererFactoryForArrayListData with new implementation of DynamicItemsRendererFactoryForArrayListData - Update example MDLDynamicTabsExample
  FLEX-35354 - Add DynamicItemsRendererFactoryForArrayListData to allow add items dynamically to MDL Table - Bead can be used in other components - Update TabsItemRendererFactoryForArrayListData with new DynamicItemsRendererFactoryForArrayListData
  Switch MDLDynamicTabsExample to JSFlex only build in Maven
  “Stringables” should be assignable to XML
  Partially fixed FormatExample
  Fixed a few errors in DataGridXcompile
  Fixed TLFEditTestFlexJS manual test
  Added maven build for UnitTests
  -refactored ant builds of manual tests to be closer to examples, and support for 'maven_compat' from test level ant scripts. -renamed GenericTests to UnitTests and fixed some display issues due to layout changes etc
  Quick fix for FormExample (avoid 0 width, 0 height clipping)
  Quick fix for ListsTest
  Quick fix for ImageTest
  FLEX-35350 - THead and TBody need to be created a bit early cause MDL complaining with NPE when dataProvider is null
  quick fix to get compiling and something displaying
  ...

Mihai Chira <mihaic@apache.org> committed 243507a7346b6acbba755833a970dccdb48cf375 (1 file)
Reviews: none

FLEX-35321 CAUSE: if the object isn't on stage when we'd normally set its initialized flag to true, we correctly skip this step, but we also need to set its updateCompletePendingFlag back to false, so that in case it's added to stage again it can work correctly, and have its initialized flag set to true as expected. This second step was skipped in the previous commit. This could be noticed, for example, in DataGrid, which would not show the renderers which it initially used in GridViewLayout.updateTypicalCellSizes(). SOLUTION: set the updateCompletePendingFlag to false even if the object isn't on stage anymore. NOTES: also removed unused imports and an unused local variable.

Harbs <harbs@in-tools.com> committed 641f74c044e44e229d5965a8a8cde27dd14c9b7e (0 files)
Reviews: none

Merge branch 'develop' of https://git-wip-us.apache.org/repos/asf/flex-asjs into develop
* 'develop' of https://git-wip-us.apache.org/repos/asf/flex-asjs:
  Add MDLDynamicTableExample to ilustrate how add/remove items to MDL Table - Currently only adding is working. The rest job will be done as part of FLEX-35354

piotrz <piotrz@apache.org> committed 56e467a1db22e644c4917b9b012291b94e1f3054 (3 files)
Reviews: none

FLEX-35354 - Add DynamicItemsRendererFactoryForArrayListData to allow add items dynamically to MDL Table - Bead can be used in other components - Update TabsItemRendererFactoryForArrayListData with new DynamicItemsRendererFactoryForArrayListData

greg-dove <greg.dove@gmail.com> committed 932f7cb4de15b4ff45d8dd71d76bd08110242f19 (0 files)
Reviews: none

Merge branch 'develop' of https://git-wip-us.apache.org/repos/asf/flex-asjs into develop

piotrz <piotrz@apache.org> committed d52d531b04895d7ecc38167c96a08d9ca9e75594 (1 file)
Reviews: none

FLEX-35350 - THead and TBody need to be created a bit early cause MDL complaining with NPE when dataProvider is null

greg-dove <greg.dove@gmail.com> committed 629949ec033368ed535cbf7d6a31898623ec71b0 (0 files)
Reviews: none

Merge branch 'develop' of https://git-wip-us.apache.org/repos/asf/flex-asjs into develop

Peter Ent <pent@apache.org> committed 2443273b691c62df76f29dd05d68da88f7f7e88e (0 files)
Reviews: none

Merge branch 'develop' into feature/dragAndDrop
* develop: (26 commits)
  Update MDL Example - MDL Grid should have at least one MDL GridCell
  Added support for blink alpha and blink color for point cursor. HTML does not have the same transparency support as Flash and control over alternating colors is important.
  revert this because it isn't needed now that we require the same IValuesImpl in the module as is in the main app.
  switch to using IModule to trigger module output
  Forgot import
  Added change event on CheckBox Fixed RadioButton too
  This should work better with MXML
  Forgot to remove this line.
  Setting checked state manually now works
  maven build for ModuleExample. Module artifacts are not copied into the MainApp (yet)
  initial module example
  initialize modules
  UIModule and UIModuleLoader
  FLEX-35350 - Add missing overrides of methods related to item renderers - Use in all places element instead positioner
  Fix typo in import of KeyboardEvent
  FLEX-35350 - Make HTML element "table" as main element of MDL Table component which allows to add bead to it instead of "tbody" - TableCell and TableColumnt now extends existing classes in Basic module - accordingly TableCell and TableHeader
  Fix typo in comments of MDL CardInner
  Cleaned up HTML components
  try this price if we can't get other price data
  fx:Style blocks in MXML weren't working. How did they ever work?
  ...

piotrz <piotrz@apache.org> committed 8b1093013ec3323af9ecc79be6d926a1a8f6f6d1 (0 files)
Reviews: none

Merge branch 'develop' of https://git-wip-us.apache.org/repos/asf/flex-asjs into develop

greg-dove <greg.dove@gmail.com> committed 1b3b89aa80d1da03ad375beeef9ed4d015be1dba (0 files)
Reviews: none

Merge branch 'develop' of https://git-wip-us.apache.org/repos/asf/flex-falcon into develop

Mihai Chira <mihaic@apache.org> committed fcc25865f43a7f0760da5a5b1849a932349797d8 (2 files)
Reviews: none

FLEX-18746 CAUSE: HierarchicalCollectionView.updateLength() was ignoring nodes without children, as it should. However, the function it called for the nodes with children, getChildren() unfortunately had a necessary side-effect (which is a poor design choice, to be sure), which was to add an event listener to the children collection. So the empty collections of nodes were not listened to, which meant that once the node was open any children that were added to that node were not counted towards the length of the collection. And one way this inconsistency surfaced was through the expandItem() fatal.
SOLUTION: The best - and most time-consuming - solution to this is to find a way to extract the side-effect of getChildren() into a separate function and call it when needed. However, for the moment I have opted to simply allow getChildren() to be called even for empty nodes, which in turn adds the event listeners.

NOTES: all unit tests now pass.

Mihai Chira <mihaic@apache.org> committed 5fb2fb634ea856cc0cd4034dc9bc99e4a58219d5 (2 files)
Reviews: none

FLEX-18746 Adding another unit test which goes to the heart of the bug - the length calculation in HierarchicalCollectionView. (Currently the test function test_opening_closing_with_Jill_having_no_children_to_begin_with() fails, as expected.)

piotrz <piotrz@apache.org> committed 683db92f43d324bc786f6d8f99b5fab3b95aa842 (1 file)
Reviews: none

FLEX-35350 - Add missing overrides of methods related to item renderers - Use in all places element instead positioner