Uploaded image for project: 'TinkerPop'
  1. TinkerPop
  2. TINKERPOP-944

Deprecate Graph.Exceptions.elementNotFound

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Done
    • 3.0.2-incubating
    • 3.2.3
    • structure
    • None

    Description

      As it sits right now, the standard elementNotFound exception is not used in the core code base, but we are validating that it is being thrown in the test suite by providers! The test is actually faulty because it is not asserting the message and just that it is a NoSuchElementException which is causing the problem. We should either deprecate this method and just validate NoSuchElementException or use it in full and force providers to do the same.

      This has the potential to be a breaking change as it might break tests if providers aren't using that standard exception.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            spmallette Stephen Mallette
            spmallette Stephen Mallette
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment