Uploaded image for project: 'TinkerPop'
  1. TinkerPop
  2. TINKERPOP-3032

Align readPartitions data type for PartitionStrategy

Attach filesAttach ScreenshotAdd voteVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Open
    • Minor
    • Resolution: Unresolved
    • 3.6.6
    • None
    • dotnet, go, process
    • None

    Description

      gremlin-language doesn't have Set yet until TINKERPOP-3023 but .NET forces PartitionStrategy.readPartitions to be of that type. The other languages accept List. There should be some alignment here. Set makes sense for this configuration but from an API perspective users probably don't need to be forced into it. Seems like it could internally use Set but accept a List to avoid that extra specificity. This also applies to Go. Set is also used in constructing some other strategies like ReservedKeysVerificationStrategy.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            Unassigned Unassigned
            spmallette Stephen Mallette

            Dates

              Created:
              Updated:

              Slack

                Issue deployment