Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-2891

binary data may cause a failure with JSON transport under specific circumstances

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 0.9.3
    • Go - Library
    • None
    • Patch Available

    Description

      The Go implementation relies on base64.StdEncoding.Decode which expects the base64 encoding to be complete with padding.

      With Thrift it is legal to transfer binary data via JSON without padding, but the standard package can't handle this and returns an error instead ("invalid base64 data at offset N").

      Attachments

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            jensg Jens Geyer
            jensg Jens Geyer
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment