Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-2633

remove 'this is a dummy struct' structs from generated erlang

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • 0.9.2
    • Erlang - Compiler
    • Patch Available

    Description

      the erlang backend adds 'this is a dummy struct' struct_info/1 (and struct_info_ext/1) clause to generated files which is probably incorrect behavior. it should probably instead be a function clause that catches all undefined structs and returns either 'undefined' or throws a 'function_clause' error. i've supplied a patch that does the latter (as that is the current behavior if you call struct_info/1 or struct_info_ext/1 with an undefined struct name)

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            roger Roger Meier
            alisdairsullivan alisdair sullivan
            Votes:
            1 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment