Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-1393

TTransportException's thrown from THttpClient contain superfluous slashes in the Exception message

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Trivial
    • Resolution: Fixed
    • 0.8
    • 0.8
    • PHP - Library
    • None
    • Patch Available

    Description

      This is a very minor issue, but should be addressed nonetheless.

      The THttpClient class ensures the $uri_ property has a slash prefixed by appending one if needed in the constructor. However in THttpClient::read, there are 2 exceptions thrown where a slash is concatenated between the port and uri. This results in a superfluous slash in the TTransportException message.

      Example:
      "THttpClient: Could not read 184549154 bytes from xxx.yyy.com:80//randomService"

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            nick-jones Nick Jones
            nick-jones Nick Jones
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment