Uploaded image for project: 'Apache Storm'
  1. Apache Storm
  2. STORM-3684

receive-queue V2 metrics shouldn't have "_system" as componentId if it is from a system task

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • 2.0.0, 2.1.0, 2.2.0
    • 2.3.0
    • None
    • None

    Description

      When storm registers receive-queue for executors,
      https://github.com/apache/storm/blob/v2.2.0/storm-client/src/jvm/org/apache/storm/daemon/worker/WorkerState.java#L689

      it set componentId as "__system" for any task. This is wrong for V2 metrics.

      V1 metrics are fine since the component Id used for V1 metric is not from the same place.

      https://github.com/apache/storm/blob/master/storm-client/src/jvm/org/apache/storm/executor/Executor.java#L342-L343
      It is from the member variable of the executor object.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            li530 Rui Li
            li530 Rui Li
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 2h 20m
                2h 20m

                Slack

                  Issue deployment