Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-9726

DocValuesFacets: move 'contains' check after 'min' check

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Task
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • None
    • 6.4, 7.0
    • None
    • None

    Description

      If a query requests facets with a 'contains' check, DocValuesFacets converts each term's ordinal to a BytesRef, does the string match and then checks whether it has a high enough count to go in the priority queue.
      This patch moves the lookup after the min check so that we don't do it for all terms.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            cpoerschke Christine Poerschke
            jm100 Jonny Marks
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment