Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-14651

Metrics history could disable itself better

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • 8.7
    • metrics
    • None

    Description

      The MetricsHistoryHandler should disable itself better than it does.  It will create a SolrRrdBackendFactory (which has an ExecutorService / thread pool) when it should not when the plugin is disabled.  Furthermore, I think this should be disabled by default in tests, as it's excessive machinery that don't matter to 99.9% of tests.  This will help our tests run more efficiently.

      While working on other issues, I also occasionally saw a thread leak failure with the RRD being the leaked threads.  I see that in "close", we don't wait for the executor to actually shut down but it should.

      CC Andrzej Bialecki

      Attachments

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            dsmiley David Smiley
            dsmiley David Smiley
            Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 50m
                50m

                Slack

                  Issue deployment