Uploaded image for project: 'Shiro'
  1. Shiro
  2. SHIRO-892

No Guice binding for newly introduced ShiroFilterConfiguration

VotersWatch issueWatchersLinkUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 1.10.0
    • 1.10.1
    • Integration: Guice
    • None

    Description

      When using Shiro 1.10.0 using Guice, the object graph is incomplete (no binding for ShiroFilterConfiguration). Release notes did not mention that user must provide it either.

      Personally, I'd prefer to have Shiro provide one "out of the box" if possible, as otherwise this may count as "breaking change"?

      Cause is this commit: https://github.com/apache/shiro/commit/28e10e0ca1cdcd2cede86802fde8464b29265fc8

      Reproducer: try to "boot off" Shiro as an "Guice app would" (using Guice integration, ie. prep a sample app using 1.9.1 then migrate it to 1.10.0 -> incomplete graph)

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            bdemers Brian Demers
            cstamas Tamas Cservenak
            Votes:
            1 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 40m
                40m

                Slack

                  Issue deployment