Uploaded image for project: 'Shiro'
  1. Shiro
  2. SHIRO-302

DefaultHasher does not generate random salt

VotersWatch issueWatchersLinkUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 1.2.0
    • Cryptography & Hashing
    • None

    Description

      Extract from DefaultHasher javadoc: When a salt is not specified in a request, this implementation generates secure random salts via its

      {@link #setRandomNumberGenerator(org.apache.shiro.crypto.RandomNumberGenerator) randomNumberGenerator}

      property.

      Random salt is generated, but never assigned (line 155):
      if (publicSaltBytes == null)

      { getRandomNumberGenerator().nextBytes().getBytes(); }

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            kaosko Kalle Korhonen
            meri Maria Jurcovicova
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - 1h
                1h
                Remaining:
                Remaining Estimate - 1h
                1h
                Logged:
                Time Spent - Not Specified
                Not Specified

                Slack

                  Issue deployment