Uploaded image for project: 'Shiro'
  1. Shiro
  2. SHIRO-244

Typo in IniSecurityManagerFactory causes a requirement for a dummy Realm in addition to a RealmFactory

VotersWatch issueWatchersLinkUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Duplicate
    • 1.1.0
    • None
    • Realms
    • None

    Description

      In the private addToRealms-method of IniSecurityManagerFactory, there is a check:

      Collection<Realm> factoryRealms = factory.getRealms();
      if (!CollectionUtils.isEmpty(realms)) {
      realms.addAll(factoryRealms);
      }

      The if-clause should be against the factoryRealms variable, as this check forces one to create a dummy Realm in the configuration file in order for the factory created Realms to be added as well.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            Unassigned Unassigned
            eloukkola Esa Loukkola
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - 0.25h
                0.25h
                Remaining:
                Remaining Estimate - 0.25h
                0.25h
                Logged:
                Time Spent - Not Specified
                Not Specified

                Slack

                  Issue deployment