Uploaded image for project: 'Phoenix'
  1. Phoenix
  2. PHOENIX-6078

Remove Internal Phoenix Connections from parent LinkedQueue when closed

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 4.14.3
    • 5.1.0, 4.16.0
    • None
    • None

    Description

      In https://issues.apache.org/jira/browse/PHOENIX-5872

      We started maintaining parent-child relationships between phoenix connections to close those connections. But after closing those child connections we should be removing them from the Queue which is being maintained for the same.

      Here:

      https://github.com/apache/phoenix/blob/affa9e889efcc2ad7dac009a0d294b09447d281e/phoenix-core/src/main/java/org/apache/phoenix/compile/MutatingParallelIteratorFactory.java#L114

       

      If not removed from the queue, and if the parent connection is being reused: we are observing the OOM issue on the container side during the mapper run.

       

      Attachments

        1. PHOENIX-6078.4.x.patch
          7 kB
          Saksham Gangwar
        2. PHOENIX-6078.4.x.v2.patch
          7 kB
          Saksham Gangwar
        3. PHOENIX-6078v2.4.x.patch
          7 kB
          Saksham Gangwar
        4. PHOENIX-6078v3.4.x.patch
          7 kB
          Saksham Gangwar
        5. PHOENIX-6078v4.4.x.patch
          7 kB
          Saksham Gangwar

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            stoty Istvan Toth
            saksham.gangwar Saksham Gangwar
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 0.5h
                0.5h

                Slack

                  Issue deployment