[MJLINK-53] ITs should fail if no jlink binary is available - ASF JIRA

Attach files

Attach Screenshot

Voters

Watch issue

Watchers

Create sub-task

Link

Clone

Update Comment Author

Replace String in Comment

Update Comment Visibility

Delete Comments

XML

Word

Printable

JSON

Details

Type: Improvement
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: None
Fix Version/s: 3.1.0
Labels:
None

Description

Currently the ITs will just be skipped if no jlink binary is available:

[INFO] --- maven-invoker-plugin:3.2.1:integration-test (integration-test) @ maven-jlink-plugin ---
107[INFO] Running 2 setup jobs:
108[INFO] Building: setup-jar-module-info/pom.xml
109[INFO]           setup-jar-module-info/pom.xml .................... SKIPPED due to JRE version
110[INFO] Building: setup-jar/pom.xml
111[INFO]           setup-jar/pom.xml ................................ SKIPPED due to JRE version
112[INFO] Setup done.
113[INFO] Building: MJLINK-3_improveVerboseOutput/pom.xml
114[INFO]           MJLINK-3_improveVerboseOutput/pom.xml ............ SKIPPED due to JRE version
115[INFO] Building: MJLINK-4_dependencyResolution/pom.xml
116[INFO]           MJLINK-4_dependencyResolution/pom.xml ............ SKIPPED due to JRE version
117[INFO] Building: MJLINK-26/pom.xml
118[INFO]           MJLINK-26/pom.xml ................................ SKIPPED due to JRE version
119

Source: https://github.com/bmarwell/maven-jlink-plugin/runs/1343140417?check_suite_focus=true#step:11:1

However, building this project (maven-mjlink-plugin) with JDK8 should be supported using jlink via toolchains.

To add a little bit more detail:

https://issues.apache.org/jira/browse/MJLINK-36 is to be implemented via multi-module jars (e.g. add a folder src/main/java9). This means that without a Java8+Toolchain execution, the Java 8 code is never executed.