Uploaded image for project: 'JSPWiki'
  1. JSPWiki
  2. JSPWIKI-1045

IE11 rendering is broken for %%graphBars using color names

Bulk Copy AttachmentsBulk Move AttachmentsVotersWatch issueWatchersConvert to sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 2.10.3
    • 2.10.3
    • Templates and UI
    • None
    • Tomcat 7
      Java 8
      JSPWiki v2.10.3-git-27

    Description

      Example: https://jspwiki-wiki.apache.org/Wiki.jsp?page=GraphBars


      IE11 create an javascript exception because object c010 does not implement remove() method.


      Patch
      Index: jspwiki-war/src/main/scripts/moo-extend/Color.js
      IDEA additional info:
      Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
      <+>UTF-8
      ===================================================================
      --- jspwiki-war/src/main/scripts/moo-extend/Color.js	(revision 2e3da23a887548876fa7f61303efaf1fa15fc333)
      +++ jspwiki-war/src/main/scripts/moo-extend/Color.js	(revision )
      @@ -59,7 +59,6 @@
               c0l0r.inject(document.body);
               color = ( color.test(/^[\da-f]{3,6}$/i) ?  ("#" + color) :
                        c0l0r.setStyle('color',color).getComputedStyle('color').rgbToHex() ).hexToRgb(true);  //[r,g,b]
      -        c0l0r.remove();
       
           }
           if(!color){ return null; }
      
      

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            brushed Dirk Frederickx
            epoth E.Poth
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment