Uploaded image for project: 'Hive'
  1. Hive
  2. HIVE-862

CommandProcessor should return DriverResponse

Log workAgile BoardRank to TopRank to BottomBulk Copy AttachmentsBulk Move AttachmentsVotersWatch issueWatchersCreate sub-taskConvert to sub-taskMoveLinkCloneLabelsUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • New Feature
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 0.6.0
    • Query Processor
    • None
    • Reviewed

    Description

      Since Driver now returns DriverResponse CommandProcessor should return a similar object.

      For reference here is how i want to use this:
      
      Currently:
      HWISessionItem.java
      private List<Integer> queryRet;
      private List<String>  queries;
      
      public void runQuery() {
        //for each query in queries
         if (instanceof driver) {
            //other stuff here
           queryRet.add( qp.run(cmd) );
         } else {
            queryRet.add(proc.run(cmd_1)  );
         }
      }
      
      So I would like to refactor and use DriverResponse.
      
      private List<DriverResponse> queryRet;
      private List<String>  queries;
      
      public void runQuery() {
        //for each query in queries
         
         if (instanceof driver) {
            //other stuff here
           queryRet.add( qp.run(cmd) );  //<--- this is fine
         } else {
            queryRet.add(proc.run(cmd_1)  ); <--this returns an int.
         }
      }
      

      Attachments

        1. HIVE-862.1.patch
          15 kB
          William W. Graham Jr
        2. HIVE-862.2.patch
          17 kB
          William W. Graham Jr

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            billgraham William W. Graham Jr Assign to me
            appodictic Edward Capriolo
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment