Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-13634

Avoid unsafe reference equality checks to EMPTY byte[]

VotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 2.0.0
    • Compaction, Scanners
    • None
    • Reviewed

    Description

      While looking to see if there was a standard method in the code base for testing for the empty start and end row, I noticed some cases that are using unsafe reference equality checks and thus may have incorrect behavior in boundary cases:

      ScanQueryMatcher.checkPartialDropDeleteRange
      StripeStoreFileManager.findStripeForRow

      It looks like both are intended to support stripe compaction

      Attachments

        1. HBASE-13634-v1.patch
          10 kB
          Lars Francke
        2. HBASE-13634-branch-1.patch
          3 kB
          Lars Francke
        3. HBASE-13634.patch
          9 kB
          Lars Francke

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            larsfrancke Lars Francke
            davelatham Dave Latham
            Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment