Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-12347

Fix the edge case where Hadoop QA's parsing of attached patches breaks the JIRA status checker in dev-support/rebase_all_git_branches.sh

VotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • 2.0.0
    • scripts
    • None

    Description

      The rebase_all_hbase_branches.sh script is unable to detect that HBASE-12207 is closed, because for that one JIRA, the curl command that detects the status is returning the status, but also the text from Hadoop QA for each patch it has evaluated on the JIRA:

      $ curl -s https://issues.apache.org/jira/browse/HBASE-12207 | grep resolution-val
                      <span id="resolution-val" class="value resolved" >
          +		jira_status=$(curl -s $jira_url/$jira|grep resolution-val|sed -e "s/.*class=\"value\ //"|cut -d'"' -f 1)<br/>
          +		jira_status=$(curl -s $jira_url/$jira|grep resolution-val|sed -e "s/.*class=\"value\ //"|cut -d'"' -f 1)
          +		jira_status=$(curl -s $jira_url/$jira|grep resolution-val|sed -e "s/.*class=\"value\ //"|cut -d'"' -f 1)<br/>
          +		jira_status=$(curl -s $jira_url/$jira|grep resolution-val|sed -e "s/.*class=\"value\ //"|cut -d'"' -f 1)
          +		jira_status=$(curl -s $jira_url/$jira|grep resolution-val|sed -e "s/.*class=\"value\ //"|cut -d'"' -f 1)<br/>
          +		jira_status=$(curl -s $jira_url/$jira|grep resolution-val|sed -e "s/.*class=\"value\ //"|cut -d'"' -f 1)
          +		jira_status=$(curl -s $jira_url/$jira|grep resolution-val|sed -e "s/.*class=\"value\ //"|cut -d'"' -f 1)<br/>
          +		jira_status=$(curl -s $jira_url/$jira|grep resolution-val|sed -e "s/.*class=\"value\ //"|cut -d'"' -f 1)
      

      All but the top line of output are from parsing comments from Hadoop QA. I think this is an edge case that will only to patches against that section of dev-support/rebase_all_git_branches.sh. However, I'm not sure the cleanest way to fix it.

      Attachments

        1. HBASE-12347.patch
          1 kB
          M Linville

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            misty M Linville
            misty M Linville
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment