[HADOOP-3256] JobHistory file on HDFS should not use the 'job name' - ASF JIRA

Log work

Agile Board

Rank to Top

Rank to Bottom

Attach files

Attach Screenshot

Bulk Copy Attachments

Bulk Move Attachments

Voters

Watch issue

Watchers

Create sub-task

Convert to sub-task

Move

Link

Clone

Labels

Update Comment Author

Replace String in Comment

Update Comment Visibility

Delete Comments

XML

Word

Printable

JSON

Details

Type: Bug
Status: Closed
Priority: Blocker
Resolution: Fixed
Affects Version/s: 0.17.0
Fix Version/s: 0.17.0
Component/s: None
Labels:
None

Hadoop Flags:

Reviewed

Description

~~HADOOP-2178~~ introduced the feature of saving jobhistory logs on HDFS.

Unfortunately the following code:

        // setup the history log file for this job
        String logFileName = jobUniqueString +  
                             "_" + user+ "_" + jobName;
        if (logFileName.length() > MAX_FILENAME_SIZE) {
          logFileName = logFileName.substring(0, MAX_FILENAME_SIZE-1);
        }

is vulnerable to user-provided job names.

Specifically I ran into 'URISyntaxException' with jobs whose names include a ":".

The easy fix is to ensure that we do not use the human-friendly job names and only the jobid.

The long term fix is to ensure that Path handles filenames with any characters.