Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-13442

Optimize UGI group lookups

VotersStop watchingWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 2.8.0, 3.0.0-alpha1, 2.7.5
    • None
    • None
    • Reviewed

    Description

      UGI#getGroups and its usage is inefficient. The list is unnecessarily converted to multiple collections.

      For every invocation, the List<String> from the group provider is converted into a LinkedHashSet<String> (to de-dup), back to a String[]. Then callers testing for group membership convert back to a List<String>. This should be done once to reduce allocations.

      Attachments

        1. HADOOP-13442.patch
          14 kB
          Daryn Sharp

        Issue Links

        breaks

        Bug - A problem which impairs or prevents the functions of the product. HDFS-10738 Fix TestRefreshUserMappings.testRefreshSuperUserGroupsConfiguration test failure

        • Major - Major loss of function.
        • Resolved

        Bug - A problem which impairs or prevents the functions of the product. MAPREDUCE-6750 TestHSAdminServer.testRefreshSuperUserGroups is failing

        • Minor - Minor loss of function, or other problem where easy workaround is present.
        • Resolved
        is duplicated by

        Bug - A problem which impairs or prevents the functions of the product. HADOOP-12253 ViewFileSystem getFileStatus java.lang.ArrayIndexOutOfBoundsException: 0

        • Major - Major loss of function.
        • Resolved

        Improvement - An improvement or enhancement to an existing feature or task. HADOOP-12858 Reduce UGI getGroups overhead

        • Major - Major loss of function.
        • Resolved
        is required by

        Sub-task - The sub-task of the issue HDFS-10711 Optimize FSPermissionChecker group membership check

        • Major - Major loss of function.
        • Resolved
        relates to

        Improvement - An improvement or enhancement to an existing feature or task. HADOOP-17079 Optimize UGI#getGroups by adding UGI#getGroupsSet

        • Major - Major loss of function.
        • Resolved

        Activity
          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            daryn Daryn Sharp
            daryn Daryn Sharp
            Votes:
            0 Vote for this issue
            Watchers:
            9 Stop watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment