Uploaded image for project: 'Qpid Dispatch'
  1. Qpid Dispatch
  2. DISPATCH-1403

Consolidate chained qd_buffer_t field handling code

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 1.8.0, 1.9.0
    • 1.19.0
    • Router Node

    Description

      There are many places in the router's C codebase where we need to work with data spanning a chained qd_buffer_t list. In particular the low level operations such as:

      • advance N bytes
      • compare N bytes
      • copy N bytes
        are common throughout the code.

      Here are examples from the iterator.c library:
      copy bytes
      advance cursor
      compare

      Similar logic is implemented in message.c and parse.c.

      We should de-duplicate this code by providing a common implementation as part of the buffer handling code.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            kgiusti Ken Giusti
            kgiusti Ken Giusti
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment