Uploaded image for project: 'CouchDB'
  1. CouchDB
  2. COUCHDB-1628

THANKS generation uses a non-portable sed extended regexp flag

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 1.3
    • Build System
    • None

    Description

      The bootstrap script currently generates a THANKS file by grepping through the git shortlog and running an extended regular expression command on the resulting stream using sed (line 48):

      git shortlog -se 6c976bd..HEAD \

      grep -v @apache.org \
      sed -E "s/^[[:blank:]] {5}

      [[:digit:]]+[[:blank:]]/ * /" >> THANKS

      BSD sed uses the '-E' option to interpret regular expressions as extended (modern) regular expressions rather than basic regular expressions (BRE's). GNU sed uses the '-r' option for this behavior.

      The bootstrap script should be modified to detect the proper flag to use. I am currently using a patch which checks the system's uname to determine the flag.

      Attachments

        Activity

          People

            jan Jan Lehnardt
            bonhage Christopher Bonhage
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment