Uploaded image for project: 'Commons Configuration'
  1. Commons Configuration
  2. CONFIGURATION-527

clearPropertyDirect() in AbstractConfiguration should be abstract

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 1.9
    • 2.0
    • Build
    • None

    Description

      The method clearPropertyDirect() in AbstractConfiguration has an empty implementation body. It is documented as "should be overwritten" but is not marked abstract.
      It should be abstract to prevent errors when subclassing AbstractConfiguration and using the clear() method where (indirectly) clearPropertyDirect() is being called.
      See addPropertyDirect() for comparison, which is abstract.

      Attachments

        1. patch.diff
          0.9 kB
          Matthias Richter

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            Unassigned Unassigned
            richtmat Matthias Richter
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment