Uploaded image for project: 'Apache Cordova'
  1. Apache Cordova
  2. CB-8971

'Duplicate cordova' check breaks Ripple

VotersWatch issueWatchersLinkUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 5.0.0
    • None
    • cordova-js
    • None

    Description

      Ripple defines a setter for window.cordova so it can intercapt the cordova object being created, and patch cordova.exec. This breaks the new 'duplicate cordova' check, which looks for 'cordova' in window, which will return true in Ripple. The alternative, window.cordova, will work, since that remains undefined in Ripple.

      Attachments

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            Unassigned Unassigned
            TimBarham Tim Barham
            Votes:
            1 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment