Details
-
Improvement
-
Status: Closed
-
Major
-
Resolution: Fixed
-
None
-
None
-
Unknown
Description
Since recently I have been playing with our sourcheck to hook it in as a GitHub action at each PR, I have been fixing some sourcecheck findings leftover from previous unchecked commits.
Most of the stuff makes sense but this one:
// Some comments here <module name="Indentation"> <property name="lineWrappingIndentation" value="0"/> <property name="caseIndent" value="0"/> </module>
this impose that switch/case blocks should be in the form of:
switch(...) { case: ... case: ... case: ... default: }
i.e. switch and case keywords MUST have the same indentation. I have searched a little bit and it seems this is not widely used as a code style, the tendency is to have the case indented.
Since there are 2053 occurrences of switch/case blocks, before attempting to fix this I would like a general agreement on this.