Uploaded image for project: 'Aurora'
  1. Aurora
  2. AURORA-496

Modify config binding helper registration in clientv2

    XMLWordPrintableJSON

Details

    • Task
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 0.5.0
    • Client
    • None
    • Q2 Sprint 2, Q2 Sprint 3

    Description

      Config binding helpers (components that add macros to the pystachio
      config language) were registered in a way that used self-construction.

      In practice, binding helpers need initialization that comes from command-line parameters. With the implicit construction method, we can't provide construction parameters to the helpers.

      We need to switches to an explicit construction/registration, instead
      of auto-construction when the class is registered. (Interestingly, this
      is the way that the documentation on the binding helpers code says that
      it works!)

      Instead of writing:
      FooHelper.register()

      We should write:
      BindingHelper.register(FooHelper())

      Which makes it possible to do:
      BindingHelper.register(FooHelper(url=bar))

      Attachments

        Activity

          People

            mchucarroll Mark Chu-Carroll
            mchucarroll Mark Chu-Carroll
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: