Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.4.0
    • Component/s: build
    • Labels:
      None
    • Environment:

      Java 6, RHEL/Ubuntu

    • Hadoop Flags:
      Reviewed
    • Release Note:
      Create zookeeper rpm and deb packages.

      Description

      This goal of this ticket is to generate a set of RPM/debian package which integrate well with RPM sets created by HADOOP-6255.

      1. ZOOKEEPER-999-9.patch
        67 kB
        Eric Yang
      2. ZOOKEEPER-999-8.patch
        63 kB
        Eric Yang
      3. ZOOKEEPER-999-7.patch
        62 kB
        Eric Yang
      4. ZOOKEEPER-999-6.patch
        62 kB
        Eric Yang
      5. ZOOKEEPER-999-5.patch
        62 kB
        Eric Yang
      6. ZOOKEEPER-999-4.patch
        61 kB
        Eric Yang
      7. ZOOKEEPER-999-3.patch
        59 kB
        Eric Yang
      8. ZOOKEEPER-999-2.patch
        63 kB
        Eric Yang
      9. ZOOKEEPER-999-13.patch
        67 kB
        Eric Yang
      10. ZOOKEEPER-999-12.patch
        67 kB
        Eric Yang
      11. ZOOKEEPER-999-11.patch
        67 kB
        Eric Yang
      12. ZOOKEEPER-999-10.patch
        68 kB
        Eric Yang
      13. ZOOKEEPER-999-1.patch
        64 kB
        Eric Yang
      14. ZOOKEEPER-999.patch
        45 kB
        Eric Yang

        Issue Links

          Activity

          Hide
          Mahadev konar added a comment -

          eric,
          I am not sure what you intend to do with this jira. Can you please be a little more elaborate?

          Show
          Mahadev konar added a comment - eric, I am not sure what you intend to do with this jira. Can you please be a little more elaborate?
          Hide
          Eric Yang added a comment -

          The plan is to create an ant target which generates installable rpm package, and a conf pseudo rpm. The layout of the files will be installed as recommended by Owen's deployment layout. This will ensure hadoop stack software can integrate well between projects.

          Show
          Eric Yang added a comment - The plan is to create an ant target which generates installable rpm package, and a conf pseudo rpm. The layout of the files will be installed as recommended by Owen's deployment layout. This will ensure hadoop stack software can integrate well between projects.
          Hide
          Eric Yang added a comment -

          Usage:

          ant "rpm" creates rpm package
          ant "deb" creates debian package

          Show
          Eric Yang added a comment - Usage: ant "rpm" creates rpm package ant "deb" creates debian package
          Hide
          Thomas Koch added a comment -

          ZooKeeper is already packaged for Debian and available in the current testing repository of Debian. I'm the packager.
          I'd propose that we coordinate our efforts so that we don't end up with two versions of Debian packages. The official "Debian" package in the Debian repository and the one created by the ant target.

          I don't know, whether there are any efforts to package ZooKeeper for Fedora/Red Hat.

          Show
          Thomas Koch added a comment - ZooKeeper is already packaged for Debian and available in the current testing repository of Debian. I'm the packager. I'd propose that we coordinate our efforts so that we don't end up with two versions of Debian packages. The official "Debian" package in the Debian repository and the one created by the ant target. I don't know, whether there are any efforts to package ZooKeeper for Fedora/Red Hat.
          Hide
          Eric Yang added a comment -

          Hi Thomas,

          Thank you for bringing my attention to the official Debian builds. The packages are divided in smaller components. It would be good to use Debian package naming scheme. What else would you recommend to coordinate our efforts?

          Show
          Eric Yang added a comment - Hi Thomas, Thank you for bringing my attention to the official Debian builds. The packages are divided in smaller components. It would be good to use Debian package naming scheme. What else would you recommend to coordinate our efforts?
          Hide
          Thomas Koch added a comment -

          Hi Eric,

          I'd suggest to drop the building of deb packages from your patch and instead join efforts to have ZooKeeper in Debian as polished and current as possible. There's very much more about a proper .deb package then just getting the thing running.
          Do you have any need for .deb packages of snapshots or is it enough for you to have packages for each release?

          I don't know anything about RPMs so I can't give any suggestions about that. Have you asked anybody at Red Hat / Fedora to build official packages?

          I've asked on IRC and fedora people pointed me to the following pages if someone wants to start building RPMs:
          http://fedoraproject.org/wiki/PackageMaintainers/WishList
          http://fedoraproject.org/wiki/PackageMaintainers/Join

          Do you really need RPMs?

          Please also keep in mind that there already are "inofficial" ZooKeeper packages from cloudera.

          Show
          Thomas Koch added a comment - Hi Eric, I'd suggest to drop the building of deb packages from your patch and instead join efforts to have ZooKeeper in Debian as polished and current as possible. There's very much more about a proper .deb package then just getting the thing running. Do you have any need for .deb packages of snapshots or is it enough for you to have packages for each release? I don't know anything about RPMs so I can't give any suggestions about that. Have you asked anybody at Red Hat / Fedora to build official packages? I've asked on IRC and fedora people pointed me to the following pages if someone wants to start building RPMs: http://fedoraproject.org/wiki/PackageMaintainers/WishList http://fedoraproject.org/wiki/PackageMaintainers/Join Do you really need RPMs? Please also keep in mind that there already are "inofficial" ZooKeeper packages from cloudera.
          Hide
          Eric Yang added a comment -

          Hi Thomas,

          The idea is to be able to bring more snapshots to the hands of the developers. Distro based official release usually is more integrated with the OS and more polished for the end user experience. However, the goal is to provide a set of tools that can help early adaptors (developers) to deploy in test/production environment. The packaging cycle is more rapid than distro official release build. It would be challenging to map Apache packages to exactly the way Debian customize the OS because other distro may have different ideas on packaging. If we remove deb packaging from the build system, it would discourage the developer to develop on Debian platform. RedHat does not have RPMs for hadoop for now. When Redhat starts to package hadoop, Redhat team will definitely have their own packaging sets with patches etc.

          What I proposed here, is similar philosophy that you can download mysql from mysql website with different binary packages options, but the OS vendor will have a more stable and well integrated version.

          Show
          Eric Yang added a comment - Hi Thomas, The idea is to be able to bring more snapshots to the hands of the developers. Distro based official release usually is more integrated with the OS and more polished for the end user experience. However, the goal is to provide a set of tools that can help early adaptors (developers) to deploy in test/production environment. The packaging cycle is more rapid than distro official release build. It would be challenging to map Apache packages to exactly the way Debian customize the OS because other distro may have different ideas on packaging. If we remove deb packaging from the build system, it would discourage the developer to develop on Debian platform. RedHat does not have RPMs for hadoop for now. When Redhat starts to package hadoop, Redhat team will definitely have their own packaging sets with patches etc. What I proposed here, is similar philosophy that you can download mysql from mysql website with different binary packages options, but the OS vendor will have a more stable and well integrated version.
          Hide
          Thomas Koch added a comment -

          IRC chat between thkoch and mahadev, march 01
          <t> Hi. Do you need only rpm packages of ZK or also .deb packages?
          <m> i dont really need either... i just thought it would be good for community to get it from ZK
          <m> no ?
          <t> There already are cloudera packages and Debian packages. Having them from ZK also only adds to the confusion. I know that my colleagues did spend time to compare advantages and disadvantages of Debian packages vs. cloudera packages
          <m> thats the reason to do it in ZK
          <m> to remove any confusion
          <m> the easier it is if apache ZK can be the source of truth for RPM's
          <t> IMHO it's best to leave the packaging to the distributions. They know best about integration, QA of integration and release management
          <t> I really don't know about RPM but Debian is doing a great job in QA and application lifecycle
          <m> could be in some cases .... but i'd really like folks on RHEL and debian to be able ot say rpm install
          <m> or simmilar for debian
          <m> and do it via apache releases
          <t> you can do apt-get install zookeeper already
          <m> i totally believe it .....
          <m> agreed if debian guys are already doing it we can throw away zk for deb
          <m> makes sense to me
          <m> but RPMs should be useful no?
          <m> if red had starts doing it ... am willing to throw that away as well
          <m> what do you think?
          <t> It would kind of invalidate my work, if Apache would provide Debian packages... About Red Hat I couldn't care less. I only know from colleagues, that packaging for Red Hat should be a major pain.
          <m> if debian provides zk releases
          <t> I'd only suggest to coordinate with cloudera about the RPMs. They already provide RPMs. Maybe one could join forces to bring them into Fedora/Red Hat as official packages
          <m> i'd be happy to ...... you want to comment on the jira?
          <t> I already commented on the jira.
          <m> the idea of folks contributing to apache is to help them contribute
          <m> and not to throw away there work .....
          <m>
          <m> in case of debian it makes sense since we already have debian

          Show
          Thomas Koch added a comment - IRC chat between thkoch and mahadev, march 01 <t> Hi. Do you need only rpm packages of ZK or also .deb packages? <m> i dont really need either... i just thought it would be good for community to get it from ZK <m> no ? <t> There already are cloudera packages and Debian packages. Having them from ZK also only adds to the confusion. I know that my colleagues did spend time to compare advantages and disadvantages of Debian packages vs. cloudera packages <m> thats the reason to do it in ZK <m> to remove any confusion <m> the easier it is if apache ZK can be the source of truth for RPM's <t> IMHO it's best to leave the packaging to the distributions. They know best about integration, QA of integration and release management <t> I really don't know about RPM but Debian is doing a great job in QA and application lifecycle <m> could be in some cases .... but i'd really like folks on RHEL and debian to be able ot say rpm install <m> or simmilar for debian <m> and do it via apache releases <t> you can do apt-get install zookeeper already <m> i totally believe it ..... <m> agreed if debian guys are already doing it we can throw away zk for deb <m> makes sense to me <m> but RPMs should be useful no? <m> if red had starts doing it ... am willing to throw that away as well <m> what do you think? <t> It would kind of invalidate my work, if Apache would provide Debian packages... About Red Hat I couldn't care less. I only know from colleagues, that packaging for Red Hat should be a major pain. <m> if debian provides zk releases <t> I'd only suggest to coordinate with cloudera about the RPMs. They already provide RPMs. Maybe one could join forces to bring them into Fedora/Red Hat as official packages <m> i'd be happy to ...... you want to comment on the jira? <t> I already commented on the jira. <m> the idea of folks contributing to apache is to help them contribute <m> and not to throw away there work ..... <m> <m> in case of debian it makes sense since we already have debian
          Hide
          Thomas Koch added a comment -

          I'd be very motivated to work together with the Apache infrastructure team and integrate Debian package building in the Apache QA process. Thus all Apache projects could benefit. This would however be a longer process of several months.

          For the short term I can offer to update the Debian ZooKeeper package in the Debian experimantal distribution more frequent.

          Show
          Thomas Koch added a comment - I'd be very motivated to work together with the Apache infrastructure team and integrate Debian package building in the Apache QA process. Thus all Apache projects could benefit. This would however be a longer process of several months. For the short term I can offer to update the Debian ZooKeeper package in the Debian experimantal distribution more frequent.
          Hide
          Mahadev konar added a comment -

          Thomas,
          would it be possible to have the package building in the apache (without QA)? This probably might be lesser time. no?

          Show
          Mahadev konar added a comment - Thomas, would it be possible to have the package building in the apache (without QA)? This probably might be lesser time. no?
          Hide
          Eric Yang added a comment -

          Thanks for volunteering. The packaging process could definitely have a good coordinator between Debian and Apache. The current structure is a wireframe of the directory path layout by Owen for the greater hadoop stack. It will be easier for developer to locate dependency libraries across different Apache projects by using the directory structure layout in this chain of jiras. I recommend we keep the code for the longer term planning process, and refine into smaller package sets until packages ready for Debian distribution.

          Show
          Eric Yang added a comment - Thanks for volunteering. The packaging process could definitely have a good coordinator between Debian and Apache. The current structure is a wireframe of the directory path layout by Owen for the greater hadoop stack. It will be easier for developer to locate dependency libraries across different Apache projects by using the directory structure layout in this chain of jiras. I recommend we keep the code for the longer term planning process, and refine into smaller package sets until packages ready for Debian distribution.
          Hide
          Thomas Koch added a comment -

          @mahadev: I don't understand? What do you mean with "have the package building in the apache (without QA)"?

          I don't know much about the apache infrastructure, but I could think of three possibilities:

          • build a Debian package for every patch submitted to hudson/jenkins.
          • build a Debian package for every commit to trunk
          • build Debian packages on a manual trigger

          @Eric: That's exactly what I'd like to do: Build the packages for Debian and work together with apache to make packaging easier and raise awareness on each side for different priorities and agendas. Unfortunately I don't understand anything beginning from your second sentence. What "current structure", "wireframe", "greater hadoop stack"? Which "chain of jiras"? - I believe I'm missing some context here.

          Show
          Thomas Koch added a comment - @mahadev: I don't understand? What do you mean with "have the package building in the apache (without QA)"? I don't know much about the apache infrastructure, but I could think of three possibilities: build a Debian package for every patch submitted to hudson/jenkins. build a Debian package for every commit to trunk build Debian packages on a manual trigger @Eric: That's exactly what I'd like to do: Build the packages for Debian and work together with apache to make packaging easier and raise awareness on each side for different priorities and agendas. Unfortunately I don't understand anything beginning from your second sentence. What "current structure", "wireframe", "greater hadoop stack"? Which "chain of jiras"? - I believe I'm missing some context here.
          Hide
          Mahadev konar added a comment -

          thomas, never mind. Ignore my comments. I think it would be great to have debian packages for every commit. Is that possible? I think you can poll/register for notification. But again all this is for later.

          I am ok with just having RPM packages and keeping out debian since as you suggest debian already has this.

          Show
          Mahadev konar added a comment - thomas, never mind. Ignore my comments. I think it would be great to have debian packages for every commit. Is that possible? I think you can poll/register for notification. But again all this is for later. I am ok with just having RPM packages and keeping out debian since as you suggest debian already has this.
          Hide
          Eric Yang added a comment -

          Thomas, Owen proposed a standard layout (wireframe) of the directory structure in HADOOP-6255, PDF attachment in HADOOP-6255 describes the layout. HADOOP-6255 also links to a list of jiras related to packages for Hadoop stack. Hadoop stack composed of Hadoop, Pig, HBase, Hive, Chukwa and Mahout.

          All packages have layout the same as the proposed paper.

          Show
          Eric Yang added a comment - Thomas, Owen proposed a standard layout (wireframe) of the directory structure in HADOOP-6255 , PDF attachment in HADOOP-6255 describes the layout. HADOOP-6255 also links to a list of jiras related to packages for Hadoop stack. Hadoop stack composed of Hadoop, Pig, HBase, Hive, Chukwa and Mahout. All packages have layout the same as the proposed paper.
          Hide
          Eric Yang added a comment -

          Package builder design

          For supporting multiple type of packages, this project layout the packaging source code structure like this:

          src/packages/rpm
                      /deb
                      /conf-pseudo
          

          rpm - meta data for creating rpm packages. SysV init style startup script is also included for start up process in Redhat like environment.

          deb - meta data for creating debian packages. BSD init style startup script is also included for start up process in Ubuntu like environment.

          conf-pseudo - Configuration template for demo pseudo cluster setup. By default both rpm, or deb binary package does not startup the system. The purpose of conf-pseudo is to create a (rpm/deb) package as demonstration of how to setup a single node cluster and turn on services by configuration.

          Software home directory is designed to locate in:

          $

          {prefix}

          /share/$

          {project}

          src/packages/update-${project}

          -env.sh runs in the post installation phase which creates symlinks and making software structure to map to the proposed layout in HADOOP-6255

          /etc/default/$

          {project}

          -evn.sh is symlinked to the project environment script. Hence, project environment variables are shared across projects.

          Project build file can override the package path in the build phase:

          Sample build.properties

          package.prefix=/usr
          package.conf.dir=/etc/project
          package.log.dir=/var/log/project
          package.pid.dir=/var/log/project
          

          For RPM package, it is possible to override location at installation phase by specifying:

          rpm -i [project]-[version]-[rev].[arch].rpm \
            --relocate /usr=/usr/local/zookeeper \
            --relocate /etc/zookeeper=/usr/local/etc/zookeeper \
            --relocate /var/log/zookeeper=/opt/logs/zookeeper \
            --relocate /var/run/zookeeper=/opt/run/zookeeper
          

          The same build structure can be apply to both ant or maven build scripts. It also expandable to include mac native package installer using this design pattern.

          Show
          Eric Yang added a comment - Package builder design For supporting multiple type of packages, this project layout the packaging source code structure like this: src/packages/rpm /deb /conf-pseudo rpm - meta data for creating rpm packages. SysV init style startup script is also included for start up process in Redhat like environment. deb - meta data for creating debian packages. BSD init style startup script is also included for start up process in Ubuntu like environment. conf-pseudo - Configuration template for demo pseudo cluster setup. By default both rpm, or deb binary package does not startup the system. The purpose of conf-pseudo is to create a (rpm/deb) package as demonstration of how to setup a single node cluster and turn on services by configuration. Software home directory is designed to locate in: $ {prefix} /share/$ {project} src/packages/update-${project} -env.sh runs in the post installation phase which creates symlinks and making software structure to map to the proposed layout in HADOOP-6255 /etc/default/$ {project} -evn.sh is symlinked to the project environment script. Hence, project environment variables are shared across projects. Project build file can override the package path in the build phase: Sample build.properties package.prefix=/usr package.conf.dir=/etc/project package.log.dir=/var/log/project package.pid.dir=/var/log/project For RPM package, it is possible to override location at installation phase by specifying: rpm -i [project]-[version]-[rev].[arch].rpm \ --relocate /usr=/usr/local/zookeeper \ --relocate /etc/zookeeper=/usr/local/etc/zookeeper \ --relocate /var/log/zookeeper=/opt/logs/zookeeper \ --relocate /var/run/zookeeper=/opt/run/zookeeper The same build structure can be apply to both ant or maven build scripts. It also expandable to include mac native package installer using this design pattern.
          Hide
          Eric Yang added a comment -

          Revised patch to include C/Python binding as part of rpm/deb package builds. Realign directory structure to Linux Standard Base format (same as Owen's proposal).

          Show
          Eric Yang added a comment - Revised patch to include C/Python binding as part of rpm/deb package builds. Realign directory structure to Linux Standard Base format (same as Owen's proposal).
          Hide
          Eric Yang added a comment -

          ZOOKEEPER-999-2.patch revised the version number for zkpython to be the same as zookeeper version.

          Show
          Eric Yang added a comment - ZOOKEEPER-999 -2.patch revised the version number for zkpython to be the same as zookeeper version.
          Hide
          Patrick Hunt added a comment -

          Hi Eric, are you ready to go patch available on this?

          Show
          Patrick Hunt added a comment - Hi Eric, are you ready to go patch available on this?
          Hide
          Eric Yang added a comment -
          • Remove conf-pseudo rpm. RPM works out of the box without additional config tweaks.
          • Improved handling of environment variables.
          Show
          Eric Yang added a comment - Remove conf-pseudo rpm. RPM works out of the box without additional config tweaks. Improved handling of environment variables.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12483378/ZOOKEEPER-999-3.patch
          against trunk revision 1138213.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 11 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          -1 javac. The patch appears to cause tar ant target to fail.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/344//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/344//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/344//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12483378/ZOOKEEPER-999-3.patch against trunk revision 1138213. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 11 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. -1 javac. The patch appears to cause tar ant target to fail. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/344//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/344//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/344//console This message is automatically generated.
          Hide
          Eric Yang added a comment -

          I am not sure how the build system check for ant tar failed. It appears to be working from the console output.

          Show
          Eric Yang added a comment - I am not sure how the build system check for ant tar failed. It appears to be working from the console output.
          Hide
          Patrick Hunt added a comment -

          Hi Eric, the javac warnings are saved in the jenkins artifacts, I see some issues here:
          https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/344/artifact/trunk/patchprocess/patchJavacWarnings.txt

          specifically:
          [exec] src/c/zookeeper.c:19:20: error: Python.h: No such file or directory

          Would you be able to talk with Giri about this? I'm not sure why but it seems that python.h is missing on this host (hadoop9), either that or something we have changed/not doing. (any ideas? usually we don't see this issue...)

          Regards.

          Show
          Patrick Hunt added a comment - Hi Eric, the javac warnings are saved in the jenkins artifacts, I see some issues here: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/344/artifact/trunk/patchprocess/patchJavacWarnings.txt specifically: [exec] src/c/zookeeper.c:19:20: error: Python.h: No such file or directory Would you be able to talk with Giri about this? I'm not sure why but it seems that python.h is missing on this host (hadoop9), either that or something we have changed/not doing. (any ideas? usually we don't see this issue...) Regards.
          Hide
          Eric Yang added a comment -

          The build machine does not have python-devel rpm installed, I will work with Giri to see if we can install the header files. Thanks

          Show
          Eric Yang added a comment - The build machine does not have python-devel rpm installed, I will work with Giri to see if we can install the header files. Thanks
          Hide
          Giridharan Kesavan added a comment -

          hadoop build servers are running ubuntu-9.04 which is really old; ATM Im unable to update or install any package with this version of ubuntu. I had to upgrade the os version to add install any package. Im working on it..

          Show
          Giridharan Kesavan added a comment - hadoop build servers are running ubuntu-9.04 which is really old; ATM Im unable to update or install any package with this version of ubuntu. I had to upgrade the os version to add install any package. Im working on it..
          Hide
          Mahadev konar added a comment -

          Eric,

          I applied the patch and tried ant clean package. It fails with the following:

          [exec] building 'zookeeper' extension
          [exec] creating /Users/mahadev/workspace/zookeeper-workspace/zookeeper-git/build/contrib/zkpython/temp.macosx-10.5-i386-2.5
          [exec] creating /Users/mahadev/workspace/zookeeper-workspace/zookeeper-git/build/contrib/zkpython/temp.macosx-10.5-i386-2.5/src
          [exec] creating /Users/mahadev/workspace/zookeeper-workspace/zookeeper-git/build/contrib/zkpython/temp.macosx-10.5-i386-2.5/src/c
          [exec] gcc -fno-strict-aliasing -Wno-long-double -no-cpp-precomp -mno-fused-madd -fno-common -dynamic -DNDEBUG -g -Os -Wall -Wstrict-prototypes -DMACOSX -I/usr/include/ffi -DENABLE_DTRACE -arch i386 -arch ppc -pipe -I../../..//src/c/include -I../../..//build/c -I../../..//src/c/generated -I/System/Library/Frameworks/Python.framework/Versions/2.5/include/python2.5 -c src/c/zookeeper.c -o /Users/mahadev/workspace/zookeeper-workspace/zookeeper-git/build/contrib/zkpython/temp.macosx-10.5-i386-2.5/src/c/zookeeper.o
          [exec] creating /Users/mahadev/workspace/zookeeper-workspace/zookeeper-git/build/contrib/zkpython/lib.macosx-10.5-i386-2.5
          [exec] gcc -Wl,-F. -bundle -undefined dynamic_lookup -arch i386 -arch ppc /Users/mahadev/workspace/zookeeper-workspace/zookeeper-git/build/contrib/zkpython/temp.macosx-10.5-i386-2.5/src/c/zookeeper.o -L../../..//src/c/.libs/ -L../../..//build/c/.libs/ -L../../..//build/test/test-cppunit/.libs -L/usr/local/lib -lzookeeper_mt -o /Users/mahadev/workspace/zookeeper-workspace/zookeeper-git/build/contrib/zkpython/lib.macosx-10.5-i386-2.5/zookeeper.so
          [exec] ld: library not found for -lzookeeper_mt
          [exec] ld: library not found for -lzookeeper_mt

          Looks like you added zkpython as the default build depending on c libraries being installed?

          Show
          Mahadev konar added a comment - Eric, I applied the patch and tried ant clean package. It fails with the following: [exec] building 'zookeeper' extension [exec] creating /Users/mahadev/workspace/zookeeper-workspace/zookeeper-git/build/contrib/zkpython/temp.macosx-10.5-i386-2.5 [exec] creating /Users/mahadev/workspace/zookeeper-workspace/zookeeper-git/build/contrib/zkpython/temp.macosx-10.5-i386-2.5/src [exec] creating /Users/mahadev/workspace/zookeeper-workspace/zookeeper-git/build/contrib/zkpython/temp.macosx-10.5-i386-2.5/src/c [exec] gcc -fno-strict-aliasing -Wno-long-double -no-cpp-precomp -mno-fused-madd -fno-common -dynamic -DNDEBUG -g -Os -Wall -Wstrict-prototypes -DMACOSX -I/usr/include/ffi -DENABLE_DTRACE -arch i386 -arch ppc -pipe -I../../..//src/c/include -I../../..//build/c -I../../..//src/c/generated -I/System/Library/Frameworks/Python.framework/Versions/2.5/include/python2.5 -c src/c/zookeeper.c -o /Users/mahadev/workspace/zookeeper-workspace/zookeeper-git/build/contrib/zkpython/temp.macosx-10.5-i386-2.5/src/c/zookeeper.o [exec] creating /Users/mahadev/workspace/zookeeper-workspace/zookeeper-git/build/contrib/zkpython/lib.macosx-10.5-i386-2.5 [exec] gcc -Wl,-F. -bundle -undefined dynamic_lookup -arch i386 -arch ppc /Users/mahadev/workspace/zookeeper-workspace/zookeeper-git/build/contrib/zkpython/temp.macosx-10.5-i386-2.5/src/c/zookeeper.o -L../../..//src/c/.libs/ -L../../..//build/c/.libs/ -L../../..//build/test/test-cppunit/.libs -L/usr/local/lib -lzookeeper_mt -o /Users/mahadev/workspace/zookeeper-workspace/zookeeper-git/build/contrib/zkpython/lib.macosx-10.5-i386-2.5/zookeeper.so [exec] ld: library not found for -lzookeeper_mt [exec] ld: library not found for -lzookeeper_mt Looks like you added zkpython as the default build depending on c libraries being installed?
          Hide
          Eric Yang added a comment -

          On Mac, C library should have extension .dylib. zkpython Make file only works on linux with .so extension. I will submit another patch to fix zkpython's make file.

          Show
          Eric Yang added a comment - On Mac, C library should have extension .dylib. zkpython Make file only works on linux with .so extension. I will submit another patch to fix zkpython's make file.
          Hide
          Eric Yang added a comment -

          Fix quirks in autoconf configuration.

          zkpython was failing due to missing c binding library. C binding library was failing due to unable to locate cppunit.m4. Since cppunit could be installed anywhere in the system. I modified the build system to have two new properties for specify cppunit location.

          ant tar -Dcppunit.m4=/usr/local/share/aclocal -Dcppunit.lib=/usr/lib

          Show
          Eric Yang added a comment - Fix quirks in autoconf configuration. zkpython was failing due to missing c binding library. C binding library was failing due to unable to locate cppunit.m4. Since cppunit could be installed anywhere in the system. I modified the build system to have two new properties for specify cppunit location. ant tar -Dcppunit.m4=/usr/local/share/aclocal -Dcppunit.lib=/usr/lib
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12484668/ZOOKEEPER-999-4.patch
          against trunk revision 1140017.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 11 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          -1 javac. The patch appears to cause tar ant target to fail.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/357//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/357//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/357//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12484668/ZOOKEEPER-999-4.patch against trunk revision 1140017. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 11 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. -1 javac. The patch appears to cause tar ant target to fail. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/357//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/357//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/357//console This message is automatically generated.
          Hide
          Eric Yang added a comment -

          Giri, any progress on installing Python.h on the build machine? Try:

          dpkg --install python-dev
          
          Show
          Eric Yang added a comment - Giri, any progress on installing Python.h on the build machine? Try: dpkg --install python-dev
          Hide
          Patrick Hunt added a comment -

          Eric, I'd really like to see this in 3.4, perhaps you could turn off python support for the time being? (until jenkins has proper support)

          Show
          Patrick Hunt added a comment - Eric, I'd really like to see this in 3.4, perhaps you could turn off python support for the time being? (until jenkins has proper support)
          Hide
          jiraposter@reviews.apache.org added a comment -

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/1143/#review1119
          -----------------------------------------------------------

          there are a number of places in this patch where ZooKeeper is referred to as Zookeeper, this should be made consistent ("ZooKeeper").

          • Patrick

          On 2011-07-19 22:15:38, Patrick Hunt wrote:

          -----------------------------------------------------------

          This is an automatically generated e-mail. To reply, visit:

          https://reviews.apache.org/r/1143/

          -----------------------------------------------------------

          (Updated 2011-07-19 22:15:38)

          Review request for zookeeper and Mahadev Konar.

          Summary

          -------

          This goal of this ticket is to generate a set of RPM/debian package which integrate well with RPM sets created by HADOOP-6255.

          This addresses bug ZOOKEEPER-999.

          https://issues.apache.org/jira/browse/ZOOKEEPER-999

          Diffs

          -----

          ./bin/zkCleanup.sh 1141173

          ./bin/zkCli.sh 1141173

          ./bin/zkEnv.sh 1141173

          ./bin/zkServer.sh 1141173

          ./build.xml 1141176

          ./ivy.xml 1141173

          ./src/contrib/build-contrib.xml 1141173

          ./src/contrib/build.xml 1141173

          ./src/contrib/zkpython/build.xml 1141173

          ./src/contrib/zkpython/ivy.xml PRE-CREATION

          ./src/contrib/zkpython/src/packages/deb/zkpython.control/control PRE-CREATION

          ./src/contrib/zkpython/src/packages/rpm/spec/zkpython.spec PRE-CREATION

          ./src/contrib/zkpython/src/python/setup.py 1141173

          ./src/packages/deb/init.d/zookeeper PRE-CREATION

          ./src/packages/deb/zookeeper.control/conffile PRE-CREATION

          ./src/packages/deb/zookeeper.control/control PRE-CREATION

          ./src/packages/deb/zookeeper.control/postinst PRE-CREATION

          ./src/packages/deb/zookeeper.control/postrm PRE-CREATION

          ./src/packages/deb/zookeeper.control/preinst PRE-CREATION

          ./src/packages/deb/zookeeper.control/prerm PRE-CREATION

          ./src/packages/rpm/init.d/zookeeper PRE-CREATION

          ./src/packages/rpm/spec/zookeeper.spec PRE-CREATION

          ./src/packages/templates/conf/zoo.cfg PRE-CREATION

          ./src/packages/update-zookeeper-env.sh PRE-CREATION

          ./src/recipes/build-recipes.xml 1141173

          ./src/recipes/build.xml 1141173

          ./src/recipes/lock/build.xml 1141173

          ./src/recipes/queue/build.xml 1141173

          Diff: https://reviews.apache.org/r/1143/diff

          Testing

          -------

          Thanks,

          Patrick

          Show
          jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1143/#review1119 ----------------------------------------------------------- there are a number of places in this patch where ZooKeeper is referred to as Zookeeper, this should be made consistent ("ZooKeeper"). Patrick On 2011-07-19 22:15:38, Patrick Hunt wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1143/ ----------------------------------------------------------- (Updated 2011-07-19 22:15:38) Review request for zookeeper and Mahadev Konar. Summary ------- This goal of this ticket is to generate a set of RPM/debian package which integrate well with RPM sets created by HADOOP-6255 . This addresses bug ZOOKEEPER-999 . https://issues.apache.org/jira/browse/ZOOKEEPER-999 Diffs ----- ./bin/zkCleanup.sh 1141173 ./bin/zkCli.sh 1141173 ./bin/zkEnv.sh 1141173 ./bin/zkServer.sh 1141173 ./build.xml 1141176 ./ivy.xml 1141173 ./src/contrib/build-contrib.xml 1141173 ./src/contrib/build.xml 1141173 ./src/contrib/zkpython/build.xml 1141173 ./src/contrib/zkpython/ivy.xml PRE-CREATION ./src/contrib/zkpython/src/packages/deb/zkpython.control/control PRE-CREATION ./src/contrib/zkpython/src/packages/rpm/spec/zkpython.spec PRE-CREATION ./src/contrib/zkpython/src/python/setup.py 1141173 ./src/packages/deb/init.d/zookeeper PRE-CREATION ./src/packages/deb/zookeeper.control/conffile PRE-CREATION ./src/packages/deb/zookeeper.control/control PRE-CREATION ./src/packages/deb/zookeeper.control/postinst PRE-CREATION ./src/packages/deb/zookeeper.control/postrm PRE-CREATION ./src/packages/deb/zookeeper.control/preinst PRE-CREATION ./src/packages/deb/zookeeper.control/prerm PRE-CREATION ./src/packages/rpm/init.d/zookeeper PRE-CREATION ./src/packages/rpm/spec/zookeeper.spec PRE-CREATION ./src/packages/templates/conf/zoo.cfg PRE-CREATION ./src/packages/update-zookeeper-env.sh PRE-CREATION ./src/recipes/build-recipes.xml 1141173 ./src/recipes/build.xml 1141173 ./src/recipes/lock/build.xml 1141173 ./src/recipes/queue/build.xml 1141173 Diff: https://reviews.apache.org/r/1143/diff Testing ------- Thanks, Patrick
          Hide
          jiraposter@reviews.apache.org added a comment -

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/1143/
          -----------------------------------------------------------

          Review request for zookeeper and Mahadev Konar.

          Summary
          -------

          This goal of this ticket is to generate a set of RPM/debian package which integrate well with RPM sets created by HADOOP-6255.

          This addresses bug ZOOKEEPER-999.
          https://issues.apache.org/jira/browse/ZOOKEEPER-999

          Diffs


          ./bin/zkCleanup.sh 1141173
          ./bin/zkCli.sh 1141173
          ./bin/zkEnv.sh 1141173
          ./bin/zkServer.sh 1141173
          ./build.xml 1141176
          ./ivy.xml 1141173
          ./src/contrib/build-contrib.xml 1141173
          ./src/contrib/build.xml 1141173
          ./src/contrib/zkpython/build.xml 1141173
          ./src/contrib/zkpython/ivy.xml PRE-CREATION
          ./src/contrib/zkpython/src/packages/deb/zkpython.control/control PRE-CREATION
          ./src/contrib/zkpython/src/packages/rpm/spec/zkpython.spec PRE-CREATION
          ./src/contrib/zkpython/src/python/setup.py 1141173
          ./src/packages/deb/init.d/zookeeper PRE-CREATION
          ./src/packages/deb/zookeeper.control/conffile PRE-CREATION
          ./src/packages/deb/zookeeper.control/control PRE-CREATION
          ./src/packages/deb/zookeeper.control/postinst PRE-CREATION
          ./src/packages/deb/zookeeper.control/postrm PRE-CREATION
          ./src/packages/deb/zookeeper.control/preinst PRE-CREATION
          ./src/packages/deb/zookeeper.control/prerm PRE-CREATION
          ./src/packages/rpm/init.d/zookeeper PRE-CREATION
          ./src/packages/rpm/spec/zookeeper.spec PRE-CREATION
          ./src/packages/templates/conf/zoo.cfg PRE-CREATION
          ./src/packages/update-zookeeper-env.sh PRE-CREATION
          ./src/recipes/build-recipes.xml 1141173
          ./src/recipes/build.xml 1141173
          ./src/recipes/lock/build.xml 1141173
          ./src/recipes/queue/build.xml 1141173

          Diff: https://reviews.apache.org/r/1143/diff

          Testing
          -------

          Thanks,

          Patrick

          Show
          jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1143/ ----------------------------------------------------------- Review request for zookeeper and Mahadev Konar. Summary ------- This goal of this ticket is to generate a set of RPM/debian package which integrate well with RPM sets created by HADOOP-6255 . This addresses bug ZOOKEEPER-999 . https://issues.apache.org/jira/browse/ZOOKEEPER-999 Diffs ./bin/zkCleanup.sh 1141173 ./bin/zkCli.sh 1141173 ./bin/zkEnv.sh 1141173 ./bin/zkServer.sh 1141173 ./build.xml 1141176 ./ivy.xml 1141173 ./src/contrib/build-contrib.xml 1141173 ./src/contrib/build.xml 1141173 ./src/contrib/zkpython/build.xml 1141173 ./src/contrib/zkpython/ivy.xml PRE-CREATION ./src/contrib/zkpython/src/packages/deb/zkpython.control/control PRE-CREATION ./src/contrib/zkpython/src/packages/rpm/spec/zkpython.spec PRE-CREATION ./src/contrib/zkpython/src/python/setup.py 1141173 ./src/packages/deb/init.d/zookeeper PRE-CREATION ./src/packages/deb/zookeeper.control/conffile PRE-CREATION ./src/packages/deb/zookeeper.control/control PRE-CREATION ./src/packages/deb/zookeeper.control/postinst PRE-CREATION ./src/packages/deb/zookeeper.control/postrm PRE-CREATION ./src/packages/deb/zookeeper.control/preinst PRE-CREATION ./src/packages/deb/zookeeper.control/prerm PRE-CREATION ./src/packages/rpm/init.d/zookeeper PRE-CREATION ./src/packages/rpm/spec/zookeeper.spec PRE-CREATION ./src/packages/templates/conf/zoo.cfg PRE-CREATION ./src/packages/update-zookeeper-env.sh PRE-CREATION ./src/recipes/build-recipes.xml 1141173 ./src/recipes/build.xml 1141173 ./src/recipes/lock/build.xml 1141173 ./src/recipes/queue/build.xml 1141173 Diff: https://reviews.apache.org/r/1143/diff Testing ------- Thanks, Patrick
          Hide
          Patrick Hunt added a comment -

          Updated with some comments/concerns.

          Show
          Patrick Hunt added a comment - Updated with some comments/concerns.
          Hide
          jiraposter@reviews.apache.org added a comment -

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/1143/#review1120
          -----------------------------------------------------------

          1) src/recipes/election has been added recently to trunk, are changes needed there as well? (see my comments below - seems like if we separated out pkg building from regular build it would make this more explicit/obvious)

          2) i've been wondering for a while, perhaps we should have different scripts for zkServer.sh depending upon whether running in "development mode" and running in "package mode". There's alot of cruft in there having to do with determining which mode we are in and then setting up appropriately (zkCli, zkServer, zkCleanup, etc...).

          ./bin/zkEnv.sh
          <https://reviews.apache.org/r/1143/#comment2312>

          this was recently changed by ZOOKEEPER-1084 to either use the variable if passed, or use ../conf (but not ../etc)

          ./build.xml
          <https://reviews.apache.org/r/1143/#comment2310>

          in my case aclocal does not reside in /usr/local... (ubuntu natty) but rather /usr/share

          can we determine this in some other way?

          ./build.xml
          <https://reviews.apache.org/r/1143/#comment2311>

          I think this is going to cause problems for our normal release - we don't compile the c bindings as part of this process. This should be separated out.

          I think what we'd really need is to have separate targets for building the source artifact, and any additional "binary convenience" artifacts. Avro does this very successfully.

          How about separating out the building of packages entirely from building/testing the java code? Say by having a separate build-packages.xml (ant build file) instead?

          ./ivy.xml
          <https://reviews.apache.org/r/1143/#comment2296>

          jdeb is listed as a default dependency, shouldn't this only be used for building, not default? (similar to say rat)

          ./src/contrib/zkpython/ivy.xml
          <https://reviews.apache.org/r/1143/#comment2314>

          sorry, why do we need this in zkpython?

          ./src/contrib/zkpython/ivy.xml
          <https://reviews.apache.org/r/1143/#comment2298>

          replace Hadoop with ZooKeeper

          ./src/contrib/zkpython/src/packages/deb/zkpython.control/control
          <https://reviews.apache.org/r/1143/#comment2299>

          maintainer should be dev@zookeeper

          ./src/contrib/zkpython/src/packages/rpm/spec/zkpython.spec
          <https://reviews.apache.org/r/1143/#comment2300>

          Hadoop?

          ./src/contrib/zkpython/src/packages/rpm/spec/zkpython.spec
          <https://reviews.apache.org/r/1143/#comment2301>

          zookeeper rather than hadoop?

          ./src/packages/deb/init.d/zookeeper
          <https://reviews.apache.org/r/1143/#comment2304>

          hadoop->zookeeper

          ./src/packages/deb/zookeeper.control/control
          <https://reviews.apache.org/r/1143/#comment2306>

          dev@zookeeper ?

          ./src/packages/rpm/spec/zookeeper.spec
          <https://reviews.apache.org/r/1143/#comment2307>

          zookeeper

          ./src/packages/rpm/spec/zookeeper.spec
          <https://reviews.apache.org/r/1143/#comment2308>

          zookeeper?

          ./src/packages/templates/conf/zoo.cfg
          <https://reviews.apache.org/r/1143/#comment2309>

          is there a way to not duplicate this? (a sample is also in conf)

          ./src/packages/update-zookeeper-env.sh
          <https://reviews.apache.org/r/1143/#comment2303>

          the group used is hadoop? (seems fine, just wondering...)

          • Patrick

          On 2011-07-19 22:15:38, Patrick Hunt wrote:

          -----------------------------------------------------------

          This is an automatically generated e-mail. To reply, visit:

          https://reviews.apache.org/r/1143/

          -----------------------------------------------------------

          (Updated 2011-07-19 22:15:38)

          Review request for zookeeper and Mahadev Konar.

          Summary

          -------

          This goal of this ticket is to generate a set of RPM/debian package which integrate well with RPM sets created by HADOOP-6255.

          This addresses bug ZOOKEEPER-999.

          https://issues.apache.org/jira/browse/ZOOKEEPER-999

          Diffs

          -----

          ./bin/zkCleanup.sh 1141173

          ./bin/zkCli.sh 1141173

          ./bin/zkEnv.sh 1141173

          ./bin/zkServer.sh 1141173

          ./build.xml 1141176

          ./ivy.xml 1141173

          ./src/contrib/build-contrib.xml 1141173

          ./src/contrib/build.xml 1141173

          ./src/contrib/zkpython/build.xml 1141173

          ./src/contrib/zkpython/ivy.xml PRE-CREATION

          ./src/contrib/zkpython/src/packages/deb/zkpython.control/control PRE-CREATION

          ./src/contrib/zkpython/src/packages/rpm/spec/zkpython.spec PRE-CREATION

          ./src/contrib/zkpython/src/python/setup.py 1141173

          ./src/packages/deb/init.d/zookeeper PRE-CREATION

          ./src/packages/deb/zookeeper.control/conffile PRE-CREATION

          ./src/packages/deb/zookeeper.control/control PRE-CREATION

          ./src/packages/deb/zookeeper.control/postinst PRE-CREATION

          ./src/packages/deb/zookeeper.control/postrm PRE-CREATION

          ./src/packages/deb/zookeeper.control/preinst PRE-CREATION

          ./src/packages/deb/zookeeper.control/prerm PRE-CREATION

          ./src/packages/rpm/init.d/zookeeper PRE-CREATION

          ./src/packages/rpm/spec/zookeeper.spec PRE-CREATION

          ./src/packages/templates/conf/zoo.cfg PRE-CREATION

          ./src/packages/update-zookeeper-env.sh PRE-CREATION

          ./src/recipes/build-recipes.xml 1141173

          ./src/recipes/build.xml 1141173

          ./src/recipes/lock/build.xml 1141173

          ./src/recipes/queue/build.xml 1141173

          Diff: https://reviews.apache.org/r/1143/diff

          Testing

          -------

          Thanks,

          Patrick

          Show
          jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1143/#review1120 ----------------------------------------------------------- 1) src/recipes/election has been added recently to trunk, are changes needed there as well? (see my comments below - seems like if we separated out pkg building from regular build it would make this more explicit/obvious) 2) i've been wondering for a while, perhaps we should have different scripts for zkServer.sh depending upon whether running in "development mode" and running in "package mode". There's alot of cruft in there having to do with determining which mode we are in and then setting up appropriately (zkCli, zkServer, zkCleanup, etc...). ./bin/zkEnv.sh < https://reviews.apache.org/r/1143/#comment2312 > this was recently changed by ZOOKEEPER-1084 to either use the variable if passed, or use ../conf (but not ../etc) ./build.xml < https://reviews.apache.org/r/1143/#comment2310 > in my case aclocal does not reside in /usr/local... (ubuntu natty) but rather /usr/share can we determine this in some other way? ./build.xml < https://reviews.apache.org/r/1143/#comment2311 > I think this is going to cause problems for our normal release - we don't compile the c bindings as part of this process. This should be separated out. I think what we'd really need is to have separate targets for building the source artifact, and any additional "binary convenience" artifacts. Avro does this very successfully. How about separating out the building of packages entirely from building/testing the java code? Say by having a separate build-packages.xml (ant build file) instead? ./ivy.xml < https://reviews.apache.org/r/1143/#comment2296 > jdeb is listed as a default dependency, shouldn't this only be used for building, not default? (similar to say rat) ./src/contrib/zkpython/ivy.xml < https://reviews.apache.org/r/1143/#comment2314 > sorry, why do we need this in zkpython? ./src/contrib/zkpython/ivy.xml < https://reviews.apache.org/r/1143/#comment2298 > replace Hadoop with ZooKeeper ./src/contrib/zkpython/src/packages/deb/zkpython.control/control < https://reviews.apache.org/r/1143/#comment2299 > maintainer should be dev@zookeeper ./src/contrib/zkpython/src/packages/rpm/spec/zkpython.spec < https://reviews.apache.org/r/1143/#comment2300 > Hadoop? ./src/contrib/zkpython/src/packages/rpm/spec/zkpython.spec < https://reviews.apache.org/r/1143/#comment2301 > zookeeper rather than hadoop? ./src/packages/deb/init.d/zookeeper < https://reviews.apache.org/r/1143/#comment2304 > hadoop->zookeeper ./src/packages/deb/zookeeper.control/control < https://reviews.apache.org/r/1143/#comment2306 > dev@zookeeper ? ./src/packages/rpm/spec/zookeeper.spec < https://reviews.apache.org/r/1143/#comment2307 > zookeeper ./src/packages/rpm/spec/zookeeper.spec < https://reviews.apache.org/r/1143/#comment2308 > zookeeper? ./src/packages/templates/conf/zoo.cfg < https://reviews.apache.org/r/1143/#comment2309 > is there a way to not duplicate this? (a sample is also in conf) ./src/packages/update-zookeeper-env.sh < https://reviews.apache.org/r/1143/#comment2303 > the group used is hadoop? (seems fine, just wondering...) Patrick On 2011-07-19 22:15:38, Patrick Hunt wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1143/ ----------------------------------------------------------- (Updated 2011-07-19 22:15:38) Review request for zookeeper and Mahadev Konar. Summary ------- This goal of this ticket is to generate a set of RPM/debian package which integrate well with RPM sets created by HADOOP-6255 . This addresses bug ZOOKEEPER-999 . https://issues.apache.org/jira/browse/ZOOKEEPER-999 Diffs ----- ./bin/zkCleanup.sh 1141173 ./bin/zkCli.sh 1141173 ./bin/zkEnv.sh 1141173 ./bin/zkServer.sh 1141173 ./build.xml 1141176 ./ivy.xml 1141173 ./src/contrib/build-contrib.xml 1141173 ./src/contrib/build.xml 1141173 ./src/contrib/zkpython/build.xml 1141173 ./src/contrib/zkpython/ivy.xml PRE-CREATION ./src/contrib/zkpython/src/packages/deb/zkpython.control/control PRE-CREATION ./src/contrib/zkpython/src/packages/rpm/spec/zkpython.spec PRE-CREATION ./src/contrib/zkpython/src/python/setup.py 1141173 ./src/packages/deb/init.d/zookeeper PRE-CREATION ./src/packages/deb/zookeeper.control/conffile PRE-CREATION ./src/packages/deb/zookeeper.control/control PRE-CREATION ./src/packages/deb/zookeeper.control/postinst PRE-CREATION ./src/packages/deb/zookeeper.control/postrm PRE-CREATION ./src/packages/deb/zookeeper.control/preinst PRE-CREATION ./src/packages/deb/zookeeper.control/prerm PRE-CREATION ./src/packages/rpm/init.d/zookeeper PRE-CREATION ./src/packages/rpm/spec/zookeeper.spec PRE-CREATION ./src/packages/templates/conf/zoo.cfg PRE-CREATION ./src/packages/update-zookeeper-env.sh PRE-CREATION ./src/recipes/build-recipes.xml 1141173 ./src/recipes/build.xml 1141173 ./src/recipes/lock/build.xml 1141173 ./src/recipes/queue/build.xml 1141173 Diff: https://reviews.apache.org/r/1143/diff Testing ------- Thanks, Patrick
          Hide
          jiraposter@reviews.apache.org added a comment -

          On 2011-07-19 22:46:10, Patrick Hunt wrote:

          > ./bin/zkEnv.sh, lines 31-35

          > <https://reviews.apache.org/r/1143/diff/1/?file=26344#file26344line31>

          >

          > this was recently changed by ZOOKEEPER-1084 to either use the variable if passed, or use ../conf (but not ../etc)

          Hadoop stack software used the same pattern *_HOME/conf for configuration directory. This naming convention doesn't work when *_HOME/conf is collapsed into a single directory, (i.e. /usr) A proposal maded in HADOOP-6255 to address this issue. For packaged software, $PREFIX/etc/$project will be the naming convention for configuration directory. For developer, it will use $PREFIX/conf for source code build. This patch already merged change for ZOOKEEPER-1084, it will honor $ZOOCFGDIR if it is defined.

          On 2011-07-19 22:46:10, Patrick Hunt wrote:

          > ./build.xml, line 155

          > <https://reviews.apache.org/r/1143/diff/1/?file=26346#file26346line155>

          >

          > in my case aclocal does not reside in /usr/local... (ubuntu natty) but rather /usr/share

          >

          > can we determine this in some other way?

          I am fine to use /usr/share as default. It is also possible to overwrite this in build.properties. Conditional checking to set property is not pretty in ant, it may be better to leave this as a property for now.

          On 2011-07-19 22:46:10, Patrick Hunt wrote:

          > ./build.xml, line 627

          > <https://reviews.apache.org/r/1143/diff/1/?file=26346#file26346line627>

          >

          > I think this is going to cause problems for our normal release - we don't compile the c bindings as part of this process. This should be separated out.

          >

          > I think what we'd really need is to have separate targets for building the source artifact, and any additional "binary convenience" artifacts. Avro does this very successfully.

          >

          > How about separating out the building of packages entirely from building/testing the java code? Say by having a separate build-packages.xml (ant build file) instead?

          We can skip compile-native. There is a package-native target for rpm. I will make the change.

          On 2011-07-19 22:46:10, Patrick Hunt wrote:

          > ./ivy.xml, line 52

          > <https://reviews.apache.org/r/1143/diff/1/?file=26347#file26347line52>

          >

          > jdeb is listed as a default dependency, shouldn't this only be used for building, not default? (similar to say rat)

          I will change from "default" to "package" to be sure jdeb is not included in release tarball.

          On 2011-07-19 22:46:10, Patrick Hunt wrote:

          > ./src/contrib/zkpython/ivy.xml, line 1

          > <https://reviews.apache.org/r/1143/diff/1/?file=26351#file26351line1>

          >

          > sorry, why do we need this in zkpython?

          Only jdeb is required for packaging. I will trim down the ivy.xml.

          On 2011-07-19 22:46:10, Patrick Hunt wrote:

          > ./src/packages/update-zookeeper-env.sh, line 131

          > <https://reviews.apache.org/r/1143/diff/1/?file=26365#file26365line131>

          >

          > the group used is hadoop? (seems fine, just wondering...)

          I set the full stack of the software to be ownership by group hadoop for easier file ownership management.

          On 2011-07-19 22:46:10, Patrick Hunt wrote:

          > ./src/packages/templates/conf/zoo.cfg, lines 1-12

          > <https://reviews.apache.org/r/1143/diff/1/?file=26364#file26364line1>

          >

          > is there a way to not duplicate this? (a sample is also in conf)

          How about generate conf/zoo_sample.cfg from src/packages/templates/conf/zoo.cfg as part of the build process?

          • Eric

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/1143/#review1120
          -----------------------------------------------------------

          On 2011-07-19 22:15:38, Patrick Hunt wrote:

          -----------------------------------------------------------

          This is an automatically generated e-mail. To reply, visit:

          https://reviews.apache.org/r/1143/

          -----------------------------------------------------------

          (Updated 2011-07-19 22:15:38)

          Review request for zookeeper and Mahadev Konar.

          Summary

          -------

          This goal of this ticket is to generate a set of RPM/debian package which integrate well with RPM sets created by HADOOP-6255.

          This addresses bug ZOOKEEPER-999.

          https://issues.apache.org/jira/browse/ZOOKEEPER-999

          Diffs

          -----

          ./bin/zkCleanup.sh 1141173

          ./bin/zkCli.sh 1141173

          ./bin/zkEnv.sh 1141173

          ./bin/zkServer.sh 1141173

          ./build.xml 1141176

          ./ivy.xml 1141173

          ./src/contrib/build-contrib.xml 1141173

          ./src/contrib/build.xml 1141173

          ./src/contrib/zkpython/build.xml 1141173

          ./src/contrib/zkpython/ivy.xml PRE-CREATION

          ./src/contrib/zkpython/src/packages/deb/zkpython.control/control PRE-CREATION

          ./src/contrib/zkpython/src/packages/rpm/spec/zkpython.spec PRE-CREATION

          ./src/contrib/zkpython/src/python/setup.py 1141173

          ./src/packages/deb/init.d/zookeeper PRE-CREATION

          ./src/packages/deb/zookeeper.control/conffile PRE-CREATION

          ./src/packages/deb/zookeeper.control/control PRE-CREATION

          ./src/packages/deb/zookeeper.control/postinst PRE-CREATION

          ./src/packages/deb/zookeeper.control/postrm PRE-CREATION

          ./src/packages/deb/zookeeper.control/preinst PRE-CREATION

          ./src/packages/deb/zookeeper.control/prerm PRE-CREATION

          ./src/packages/rpm/init.d/zookeeper PRE-CREATION

          ./src/packages/rpm/spec/zookeeper.spec PRE-CREATION

          ./src/packages/templates/conf/zoo.cfg PRE-CREATION

          ./src/packages/update-zookeeper-env.sh PRE-CREATION

          ./src/recipes/build-recipes.xml 1141173

          ./src/recipes/build.xml 1141173

          ./src/recipes/lock/build.xml 1141173

          ./src/recipes/queue/build.xml 1141173

          Diff: https://reviews.apache.org/r/1143/diff

          Testing

          -------

          Thanks,

          Patrick

          Show
          jiraposter@reviews.apache.org added a comment - On 2011-07-19 22:46:10, Patrick Hunt wrote: > ./bin/zkEnv.sh, lines 31-35 > < https://reviews.apache.org/r/1143/diff/1/?file=26344#file26344line31 > > > this was recently changed by ZOOKEEPER-1084 to either use the variable if passed, or use ../conf (but not ../etc) Hadoop stack software used the same pattern *_HOME/conf for configuration directory. This naming convention doesn't work when *_HOME/conf is collapsed into a single directory, (i.e. /usr) A proposal maded in HADOOP-6255 to address this issue. For packaged software, $PREFIX/etc/$project will be the naming convention for configuration directory. For developer, it will use $PREFIX/conf for source code build. This patch already merged change for ZOOKEEPER-1084 , it will honor $ZOOCFGDIR if it is defined. On 2011-07-19 22:46:10, Patrick Hunt wrote: > ./build.xml, line 155 > < https://reviews.apache.org/r/1143/diff/1/?file=26346#file26346line155 > > > in my case aclocal does not reside in /usr/local... (ubuntu natty) but rather /usr/share > > can we determine this in some other way? I am fine to use /usr/share as default. It is also possible to overwrite this in build.properties. Conditional checking to set property is not pretty in ant, it may be better to leave this as a property for now. On 2011-07-19 22:46:10, Patrick Hunt wrote: > ./build.xml, line 627 > < https://reviews.apache.org/r/1143/diff/1/?file=26346#file26346line627 > > > I think this is going to cause problems for our normal release - we don't compile the c bindings as part of this process. This should be separated out. > > I think what we'd really need is to have separate targets for building the source artifact, and any additional "binary convenience" artifacts. Avro does this very successfully. > > How about separating out the building of packages entirely from building/testing the java code? Say by having a separate build-packages.xml (ant build file) instead? We can skip compile-native. There is a package-native target for rpm. I will make the change. On 2011-07-19 22:46:10, Patrick Hunt wrote: > ./ivy.xml, line 52 > < https://reviews.apache.org/r/1143/diff/1/?file=26347#file26347line52 > > > jdeb is listed as a default dependency, shouldn't this only be used for building, not default? (similar to say rat) I will change from "default" to "package" to be sure jdeb is not included in release tarball. On 2011-07-19 22:46:10, Patrick Hunt wrote: > ./src/contrib/zkpython/ivy.xml, line 1 > < https://reviews.apache.org/r/1143/diff/1/?file=26351#file26351line1 > > > sorry, why do we need this in zkpython? Only jdeb is required for packaging. I will trim down the ivy.xml. On 2011-07-19 22:46:10, Patrick Hunt wrote: > ./src/packages/update-zookeeper-env.sh, line 131 > < https://reviews.apache.org/r/1143/diff/1/?file=26365#file26365line131 > > > the group used is hadoop? (seems fine, just wondering...) I set the full stack of the software to be ownership by group hadoop for easier file ownership management. On 2011-07-19 22:46:10, Patrick Hunt wrote: > ./src/packages/templates/conf/zoo.cfg, lines 1-12 > < https://reviews.apache.org/r/1143/diff/1/?file=26364#file26364line1 > > > is there a way to not duplicate this? (a sample is also in conf) How about generate conf/zoo_sample.cfg from src/packages/templates/conf/zoo.cfg as part of the build process? Eric ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1143/#review1120 ----------------------------------------------------------- On 2011-07-19 22:15:38, Patrick Hunt wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1143/ ----------------------------------------------------------- (Updated 2011-07-19 22:15:38) Review request for zookeeper and Mahadev Konar. Summary ------- This goal of this ticket is to generate a set of RPM/debian package which integrate well with RPM sets created by HADOOP-6255 . This addresses bug ZOOKEEPER-999 . https://issues.apache.org/jira/browse/ZOOKEEPER-999 Diffs ----- ./bin/zkCleanup.sh 1141173 ./bin/zkCli.sh 1141173 ./bin/zkEnv.sh 1141173 ./bin/zkServer.sh 1141173 ./build.xml 1141176 ./ivy.xml 1141173 ./src/contrib/build-contrib.xml 1141173 ./src/contrib/build.xml 1141173 ./src/contrib/zkpython/build.xml 1141173 ./src/contrib/zkpython/ivy.xml PRE-CREATION ./src/contrib/zkpython/src/packages/deb/zkpython.control/control PRE-CREATION ./src/contrib/zkpython/src/packages/rpm/spec/zkpython.spec PRE-CREATION ./src/contrib/zkpython/src/python/setup.py 1141173 ./src/packages/deb/init.d/zookeeper PRE-CREATION ./src/packages/deb/zookeeper.control/conffile PRE-CREATION ./src/packages/deb/zookeeper.control/control PRE-CREATION ./src/packages/deb/zookeeper.control/postinst PRE-CREATION ./src/packages/deb/zookeeper.control/postrm PRE-CREATION ./src/packages/deb/zookeeper.control/preinst PRE-CREATION ./src/packages/deb/zookeeper.control/prerm PRE-CREATION ./src/packages/rpm/init.d/zookeeper PRE-CREATION ./src/packages/rpm/spec/zookeeper.spec PRE-CREATION ./src/packages/templates/conf/zoo.cfg PRE-CREATION ./src/packages/update-zookeeper-env.sh PRE-CREATION ./src/recipes/build-recipes.xml 1141173 ./src/recipes/build.xml 1141173 ./src/recipes/lock/build.xml 1141173 ./src/recipes/queue/build.xml 1141173 Diff: https://reviews.apache.org/r/1143/diff Testing ------- Thanks, Patrick
          Hide
          jiraposter@reviews.apache.org added a comment -

          On 2011-07-19 22:16:54, Patrick Hunt wrote:

          > there are a number of places in this patch where ZooKeeper is referred to as Zookeeper, this should be made consistent ("ZooKeeper").

          Will do.

          • Eric

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/1143/#review1119
          -----------------------------------------------------------

          On 2011-07-19 22:15:38, Patrick Hunt wrote:

          -----------------------------------------------------------

          This is an automatically generated e-mail. To reply, visit:

          https://reviews.apache.org/r/1143/

          -----------------------------------------------------------

          (Updated 2011-07-19 22:15:38)

          Review request for zookeeper and Mahadev Konar.

          Summary

          -------

          This goal of this ticket is to generate a set of RPM/debian package which integrate well with RPM sets created by HADOOP-6255.

          This addresses bug ZOOKEEPER-999.

          https://issues.apache.org/jira/browse/ZOOKEEPER-999

          Diffs

          -----

          ./bin/zkCleanup.sh 1141173

          ./bin/zkCli.sh 1141173

          ./bin/zkEnv.sh 1141173

          ./bin/zkServer.sh 1141173

          ./build.xml 1141176

          ./ivy.xml 1141173

          ./src/contrib/build-contrib.xml 1141173

          ./src/contrib/build.xml 1141173

          ./src/contrib/zkpython/build.xml 1141173

          ./src/contrib/zkpython/ivy.xml PRE-CREATION

          ./src/contrib/zkpython/src/packages/deb/zkpython.control/control PRE-CREATION

          ./src/contrib/zkpython/src/packages/rpm/spec/zkpython.spec PRE-CREATION

          ./src/contrib/zkpython/src/python/setup.py 1141173

          ./src/packages/deb/init.d/zookeeper PRE-CREATION

          ./src/packages/deb/zookeeper.control/conffile PRE-CREATION

          ./src/packages/deb/zookeeper.control/control PRE-CREATION

          ./src/packages/deb/zookeeper.control/postinst PRE-CREATION

          ./src/packages/deb/zookeeper.control/postrm PRE-CREATION

          ./src/packages/deb/zookeeper.control/preinst PRE-CREATION

          ./src/packages/deb/zookeeper.control/prerm PRE-CREATION

          ./src/packages/rpm/init.d/zookeeper PRE-CREATION

          ./src/packages/rpm/spec/zookeeper.spec PRE-CREATION

          ./src/packages/templates/conf/zoo.cfg PRE-CREATION

          ./src/packages/update-zookeeper-env.sh PRE-CREATION

          ./src/recipes/build-recipes.xml 1141173

          ./src/recipes/build.xml 1141173

          ./src/recipes/lock/build.xml 1141173

          ./src/recipes/queue/build.xml 1141173

          Diff: https://reviews.apache.org/r/1143/diff

          Testing

          -------

          Thanks,

          Patrick

          Show
          jiraposter@reviews.apache.org added a comment - On 2011-07-19 22:16:54, Patrick Hunt wrote: > there are a number of places in this patch where ZooKeeper is referred to as Zookeeper, this should be made consistent ("ZooKeeper"). Will do. Eric ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1143/#review1119 ----------------------------------------------------------- On 2011-07-19 22:15:38, Patrick Hunt wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1143/ ----------------------------------------------------------- (Updated 2011-07-19 22:15:38) Review request for zookeeper and Mahadev Konar. Summary ------- This goal of this ticket is to generate a set of RPM/debian package which integrate well with RPM sets created by HADOOP-6255 . This addresses bug ZOOKEEPER-999 . https://issues.apache.org/jira/browse/ZOOKEEPER-999 Diffs ----- ./bin/zkCleanup.sh 1141173 ./bin/zkCli.sh 1141173 ./bin/zkEnv.sh 1141173 ./bin/zkServer.sh 1141173 ./build.xml 1141176 ./ivy.xml 1141173 ./src/contrib/build-contrib.xml 1141173 ./src/contrib/build.xml 1141173 ./src/contrib/zkpython/build.xml 1141173 ./src/contrib/zkpython/ivy.xml PRE-CREATION ./src/contrib/zkpython/src/packages/deb/zkpython.control/control PRE-CREATION ./src/contrib/zkpython/src/packages/rpm/spec/zkpython.spec PRE-CREATION ./src/contrib/zkpython/src/python/setup.py 1141173 ./src/packages/deb/init.d/zookeeper PRE-CREATION ./src/packages/deb/zookeeper.control/conffile PRE-CREATION ./src/packages/deb/zookeeper.control/control PRE-CREATION ./src/packages/deb/zookeeper.control/postinst PRE-CREATION ./src/packages/deb/zookeeper.control/postrm PRE-CREATION ./src/packages/deb/zookeeper.control/preinst PRE-CREATION ./src/packages/deb/zookeeper.control/prerm PRE-CREATION ./src/packages/rpm/init.d/zookeeper PRE-CREATION ./src/packages/rpm/spec/zookeeper.spec PRE-CREATION ./src/packages/templates/conf/zoo.cfg PRE-CREATION ./src/packages/update-zookeeper-env.sh PRE-CREATION ./src/recipes/build-recipes.xml 1141173 ./src/recipes/build.xml 1141173 ./src/recipes/lock/build.xml 1141173 ./src/recipes/queue/build.xml 1141173 Diff: https://reviews.apache.org/r/1143/diff Testing ------- Thanks, Patrick
          Hide
          jiraposter@reviews.apache.org added a comment -

          On 2011-07-19 22:46:10, Patrick Hunt wrote:

          > 1) src/recipes/election has been added recently to trunk, are changes needed there as well? (see my comments below - seems like if we separated out pkg building from regular build it would make this more explicit/obvious)

          >

          > 2) i've been wondering for a while, perhaps we should have different scripts for zkServer.sh depending upon whether running in "development mode" and running in "package mode". There's alot of cruft in there having to do with determining which mode we are in and then setting up appropriately (zkCli, zkServer, zkCleanup, etc...).

          What do you think of this idea (2 in particular?) I guess hadoop is fine with this mixed use? Perhaps we can take some ideas from there an apply?

          On 2011-07-19 22:46:10, Patrick Hunt wrote:

          > ./bin/zkEnv.sh, lines 31-35

          > <https://reviews.apache.org/r/1143/diff/1/?file=26344#file26344line31>

          >

          > this was recently changed by ZOOKEEPER-1084 to either use the variable if passed, or use ../conf (but not ../etc)

          Eric Yang wrote:

          Hadoop stack software used the same pattern *_HOME/conf for configuration directory. This naming convention doesn't work when *_HOME/conf is collapsed into a single directory, (i.e. /usr) A proposal maded in HADOOP-6255 to address this issue. For packaged software, $PREFIX/etc/$project will be the naming convention for configuration directory. For developer, it will use $PREFIX/conf for source code build. This patch already merged change for ZOOKEEPER-1084, it will honor $ZOOCFGDIR if it is defined.

          we should look at moving to best practices, esp if hadoop already figured this out. Would you mind starting a ZK wiki page detailing both the bin/* scripts and how it fits into packaging? Or perhaps we can document it within the scripts themselves? I'd like to see us start deprecating (and eventually removing) the old ways of doing things an moving people to whatever our current best practices are.

          On 2011-07-19 22:46:10, Patrick Hunt wrote:

          > ./build.xml, line 155

          > <https://reviews.apache.org/r/1143/diff/1/?file=26346#file26346line155>

          >

          > in my case aclocal does not reside in /usr/local... (ubuntu natty) but rather /usr/share

          >

          > can we determine this in some other way?

          Eric Yang wrote:

          I am fine to use /usr/share as default. It is also possible to overwrite this in build.properties. Conditional checking to set property is not pretty in ant, it may be better to leave this as a property for now.

          I'm fine either way - as long as it doesn't impact the ability for people to easily checkout the code and build. I wasn't sure how this would effect that.

          On 2011-07-19 22:46:10, Patrick Hunt wrote:

          > ./src/packages/update-zookeeper-env.sh, line 131

          > <https://reviews.apache.org/r/1143/diff/1/?file=26365#file26365line131>

          >

          > the group used is hadoop? (seems fine, just wondering...)

          Eric Yang wrote:

          I set the full stack of the software to be ownership by group hadoop for easier file ownership management.

          seems fine. Are you planning to participate in Bigtop? Would love to have you involved. It would be great to nail all this type of thing down so that it will be consistent. (or make it easy to configure if there's no consensus, ie figure out what ppl agree on and what not).

          On 2011-07-19 22:46:10, Patrick Hunt wrote:

          > ./src/packages/templates/conf/zoo.cfg, lines 1-12

          > <https://reviews.apache.org/r/1143/diff/1/?file=26364#file26364line1>

          >

          > is there a way to not duplicate this? (a sample is also in conf)

          Eric Yang wrote:

          How about generate conf/zoo_sample.cfg from src/packages/templates/conf/zoo.cfg as part of the build process?

          My concerns are: 1) make it easy for ppl to get started with development, 2) try to limit duplication, esp stuff we're likely to forget to update, 3) generated code should go into build (eventually target once maven is here)

          perhaps a conf/zoo_template.cfg that could be used by 1), and generate into build/.../src/packages/templates/conf/zoo.cfg for use in packaging?

          • Patrick

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/1143/#review1120
          -----------------------------------------------------------

          On 2011-07-19 22:15:38, Patrick Hunt wrote:

          -----------------------------------------------------------

          This is an automatically generated e-mail. To reply, visit:

          https://reviews.apache.org/r/1143/

          -----------------------------------------------------------

          (Updated 2011-07-19 22:15:38)

          Review request for zookeeper and Mahadev Konar.

          Summary

          -------

          This goal of this ticket is to generate a set of RPM/debian package which integrate well with RPM sets created by HADOOP-6255.

          This addresses bug ZOOKEEPER-999.

          https://issues.apache.org/jira/browse/ZOOKEEPER-999

          Diffs

          -----

          ./bin/zkCleanup.sh 1141173

          ./bin/zkCli.sh 1141173

          ./bin/zkEnv.sh 1141173

          ./bin/zkServer.sh 1141173

          ./build.xml 1141176

          ./ivy.xml 1141173

          ./src/contrib/build-contrib.xml 1141173

          ./src/contrib/build.xml 1141173

          ./src/contrib/zkpython/build.xml 1141173

          ./src/contrib/zkpython/ivy.xml PRE-CREATION

          ./src/contrib/zkpython/src/packages/deb/zkpython.control/control PRE-CREATION

          ./src/contrib/zkpython/src/packages/rpm/spec/zkpython.spec PRE-CREATION

          ./src/contrib/zkpython/src/python/setup.py 1141173

          ./src/packages/deb/init.d/zookeeper PRE-CREATION

          ./src/packages/deb/zookeeper.control/conffile PRE-CREATION

          ./src/packages/deb/zookeeper.control/control PRE-CREATION

          ./src/packages/deb/zookeeper.control/postinst PRE-CREATION

          ./src/packages/deb/zookeeper.control/postrm PRE-CREATION

          ./src/packages/deb/zookeeper.control/preinst PRE-CREATION

          ./src/packages/deb/zookeeper.control/prerm PRE-CREATION

          ./src/packages/rpm/init.d/zookeeper PRE-CREATION

          ./src/packages/rpm/spec/zookeeper.spec PRE-CREATION

          ./src/packages/templates/conf/zoo.cfg PRE-CREATION

          ./src/packages/update-zookeeper-env.sh PRE-CREATION

          ./src/recipes/build-recipes.xml 1141173

          ./src/recipes/build.xml 1141173

          ./src/recipes/lock/build.xml 1141173

          ./src/recipes/queue/build.xml 1141173

          Diff: https://reviews.apache.org/r/1143/diff

          Testing

          -------

          Thanks,

          Patrick

          Show
          jiraposter@reviews.apache.org added a comment - On 2011-07-19 22:46:10, Patrick Hunt wrote: > 1) src/recipes/election has been added recently to trunk, are changes needed there as well? (see my comments below - seems like if we separated out pkg building from regular build it would make this more explicit/obvious) > > 2) i've been wondering for a while, perhaps we should have different scripts for zkServer.sh depending upon whether running in "development mode" and running in "package mode". There's alot of cruft in there having to do with determining which mode we are in and then setting up appropriately (zkCli, zkServer, zkCleanup, etc...). What do you think of this idea (2 in particular?) I guess hadoop is fine with this mixed use? Perhaps we can take some ideas from there an apply? On 2011-07-19 22:46:10, Patrick Hunt wrote: > ./bin/zkEnv.sh, lines 31-35 > < https://reviews.apache.org/r/1143/diff/1/?file=26344#file26344line31 > > > this was recently changed by ZOOKEEPER-1084 to either use the variable if passed, or use ../conf (but not ../etc) Eric Yang wrote: Hadoop stack software used the same pattern *_HOME/conf for configuration directory. This naming convention doesn't work when *_HOME/conf is collapsed into a single directory, (i.e. /usr) A proposal maded in HADOOP-6255 to address this issue. For packaged software, $PREFIX/etc/$project will be the naming convention for configuration directory. For developer, it will use $PREFIX/conf for source code build. This patch already merged change for ZOOKEEPER-1084 , it will honor $ZOOCFGDIR if it is defined. we should look at moving to best practices, esp if hadoop already figured this out. Would you mind starting a ZK wiki page detailing both the bin/* scripts and how it fits into packaging? Or perhaps we can document it within the scripts themselves? I'd like to see us start deprecating (and eventually removing) the old ways of doing things an moving people to whatever our current best practices are. On 2011-07-19 22:46:10, Patrick Hunt wrote: > ./build.xml, line 155 > < https://reviews.apache.org/r/1143/diff/1/?file=26346#file26346line155 > > > in my case aclocal does not reside in /usr/local... (ubuntu natty) but rather /usr/share > > can we determine this in some other way? Eric Yang wrote: I am fine to use /usr/share as default. It is also possible to overwrite this in build.properties. Conditional checking to set property is not pretty in ant, it may be better to leave this as a property for now. I'm fine either way - as long as it doesn't impact the ability for people to easily checkout the code and build. I wasn't sure how this would effect that. On 2011-07-19 22:46:10, Patrick Hunt wrote: > ./src/packages/update-zookeeper-env.sh, line 131 > < https://reviews.apache.org/r/1143/diff/1/?file=26365#file26365line131 > > > the group used is hadoop? (seems fine, just wondering...) Eric Yang wrote: I set the full stack of the software to be ownership by group hadoop for easier file ownership management. seems fine. Are you planning to participate in Bigtop? Would love to have you involved. It would be great to nail all this type of thing down so that it will be consistent. (or make it easy to configure if there's no consensus, ie figure out what ppl agree on and what not). On 2011-07-19 22:46:10, Patrick Hunt wrote: > ./src/packages/templates/conf/zoo.cfg, lines 1-12 > < https://reviews.apache.org/r/1143/diff/1/?file=26364#file26364line1 > > > is there a way to not duplicate this? (a sample is also in conf) Eric Yang wrote: How about generate conf/zoo_sample.cfg from src/packages/templates/conf/zoo.cfg as part of the build process? My concerns are: 1) make it easy for ppl to get started with development, 2) try to limit duplication, esp stuff we're likely to forget to update, 3) generated code should go into build (eventually target once maven is here) perhaps a conf/zoo_template.cfg that could be used by 1), and generate into build/.../src/packages/templates/conf/zoo.cfg for use in packaging? Patrick ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1143/#review1120 ----------------------------------------------------------- On 2011-07-19 22:15:38, Patrick Hunt wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1143/ ----------------------------------------------------------- (Updated 2011-07-19 22:15:38) Review request for zookeeper and Mahadev Konar. Summary ------- This goal of this ticket is to generate a set of RPM/debian package which integrate well with RPM sets created by HADOOP-6255 . This addresses bug ZOOKEEPER-999 . https://issues.apache.org/jira/browse/ZOOKEEPER-999 Diffs ----- ./bin/zkCleanup.sh 1141173 ./bin/zkCli.sh 1141173 ./bin/zkEnv.sh 1141173 ./bin/zkServer.sh 1141173 ./build.xml 1141176 ./ivy.xml 1141173 ./src/contrib/build-contrib.xml 1141173 ./src/contrib/build.xml 1141173 ./src/contrib/zkpython/build.xml 1141173 ./src/contrib/zkpython/ivy.xml PRE-CREATION ./src/contrib/zkpython/src/packages/deb/zkpython.control/control PRE-CREATION ./src/contrib/zkpython/src/packages/rpm/spec/zkpython.spec PRE-CREATION ./src/contrib/zkpython/src/python/setup.py 1141173 ./src/packages/deb/init.d/zookeeper PRE-CREATION ./src/packages/deb/zookeeper.control/conffile PRE-CREATION ./src/packages/deb/zookeeper.control/control PRE-CREATION ./src/packages/deb/zookeeper.control/postinst PRE-CREATION ./src/packages/deb/zookeeper.control/postrm PRE-CREATION ./src/packages/deb/zookeeper.control/preinst PRE-CREATION ./src/packages/deb/zookeeper.control/prerm PRE-CREATION ./src/packages/rpm/init.d/zookeeper PRE-CREATION ./src/packages/rpm/spec/zookeeper.spec PRE-CREATION ./src/packages/templates/conf/zoo.cfg PRE-CREATION ./src/packages/update-zookeeper-env.sh PRE-CREATION ./src/recipes/build-recipes.xml 1141173 ./src/recipes/build.xml 1141173 ./src/recipes/lock/build.xml 1141173 ./src/recipes/queue/build.xml 1141173 Diff: https://reviews.apache.org/r/1143/diff Testing ------- Thanks, Patrick
          Hide
          jiraposter@reviews.apache.org added a comment -

          On 2011-07-19 22:46:10, Patrick Hunt wrote:

          > 1) src/recipes/election has been added recently to trunk, are changes needed there as well? (see my comments below - seems like if we separated out pkg building from regular build it would make this more explicit/obvious)

          >

          > 2) i've been wondering for a while, perhaps we should have different scripts for zkServer.sh depending upon whether running in "development mode" and running in "package mode". There's alot of cruft in there having to do with determining which mode we are in and then setting up appropriately (zkCli, zkServer, zkCleanup, etc...).

          Patrick Hunt wrote:

          What do you think of this idea (2 in particular?) I guess hadoop is fine with this mixed use? Perhaps we can take some ideas from there an apply?

          1) Is there a plan to grow more recipes? If yes, I would recommend to use maven for build script because it allows submodule to call parent build profiles. We can have a centralized template for creating recipes rpm/deb packages. Ant recursive structure is difficult to maintain because the subdirectory build.xml file needs to refer to parent build.xml to include packaging templates, which generates too much repetitive tasks. Let's put recipes packaging as a separate task for future enhancement.

          2) Code reuse would be ideal. I am not sure if we want to have different scripts, perhaps consolidated functions would be sufficient to make organization cleaner.

          • Eric

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/1143/#review1120
          -----------------------------------------------------------

          On 2011-07-19 22:15:38, Patrick Hunt wrote:

          -----------------------------------------------------------

          This is an automatically generated e-mail. To reply, visit:

          https://reviews.apache.org/r/1143/

          -----------------------------------------------------------

          (Updated 2011-07-19 22:15:38)

          Review request for zookeeper and Mahadev Konar.

          Summary

          -------

          This goal of this ticket is to generate a set of RPM/debian package which integrate well with RPM sets created by HADOOP-6255.

          This addresses bug ZOOKEEPER-999.

          https://issues.apache.org/jira/browse/ZOOKEEPER-999

          Diffs

          -----

          ./bin/zkCleanup.sh 1141173

          ./bin/zkCli.sh 1141173

          ./bin/zkEnv.sh 1141173

          ./bin/zkServer.sh 1141173

          ./build.xml 1141176

          ./ivy.xml 1141173

          ./src/contrib/build-contrib.xml 1141173

          ./src/contrib/build.xml 1141173

          ./src/contrib/zkpython/build.xml 1141173

          ./src/contrib/zkpython/ivy.xml PRE-CREATION

          ./src/contrib/zkpython/src/packages/deb/zkpython.control/control PRE-CREATION

          ./src/contrib/zkpython/src/packages/rpm/spec/zkpython.spec PRE-CREATION

          ./src/contrib/zkpython/src/python/setup.py 1141173

          ./src/packages/deb/init.d/zookeeper PRE-CREATION

          ./src/packages/deb/zookeeper.control/conffile PRE-CREATION

          ./src/packages/deb/zookeeper.control/control PRE-CREATION

          ./src/packages/deb/zookeeper.control/postinst PRE-CREATION

          ./src/packages/deb/zookeeper.control/postrm PRE-CREATION

          ./src/packages/deb/zookeeper.control/preinst PRE-CREATION

          ./src/packages/deb/zookeeper.control/prerm PRE-CREATION

          ./src/packages/rpm/init.d/zookeeper PRE-CREATION

          ./src/packages/rpm/spec/zookeeper.spec PRE-CREATION

          ./src/packages/templates/conf/zoo.cfg PRE-CREATION

          ./src/packages/update-zookeeper-env.sh PRE-CREATION

          ./src/recipes/build-recipes.xml 1141173

          ./src/recipes/build.xml 1141173

          ./src/recipes/lock/build.xml 1141173

          ./src/recipes/queue/build.xml 1141173

          Diff: https://reviews.apache.org/r/1143/diff

          Testing

          -------

          Thanks,

          Patrick

          Show
          jiraposter@reviews.apache.org added a comment - On 2011-07-19 22:46:10, Patrick Hunt wrote: > 1) src/recipes/election has been added recently to trunk, are changes needed there as well? (see my comments below - seems like if we separated out pkg building from regular build it would make this more explicit/obvious) > > 2) i've been wondering for a while, perhaps we should have different scripts for zkServer.sh depending upon whether running in "development mode" and running in "package mode". There's alot of cruft in there having to do with determining which mode we are in and then setting up appropriately (zkCli, zkServer, zkCleanup, etc...). Patrick Hunt wrote: What do you think of this idea (2 in particular?) I guess hadoop is fine with this mixed use? Perhaps we can take some ideas from there an apply? 1) Is there a plan to grow more recipes? If yes, I would recommend to use maven for build script because it allows submodule to call parent build profiles. We can have a centralized template for creating recipes rpm/deb packages. Ant recursive structure is difficult to maintain because the subdirectory build.xml file needs to refer to parent build.xml to include packaging templates, which generates too much repetitive tasks. Let's put recipes packaging as a separate task for future enhancement. 2) Code reuse would be ideal. I am not sure if we want to have different scripts, perhaps consolidated functions would be sufficient to make organization cleaner. Eric ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1143/#review1120 ----------------------------------------------------------- On 2011-07-19 22:15:38, Patrick Hunt wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1143/ ----------------------------------------------------------- (Updated 2011-07-19 22:15:38) Review request for zookeeper and Mahadev Konar. Summary ------- This goal of this ticket is to generate a set of RPM/debian package which integrate well with RPM sets created by HADOOP-6255 . This addresses bug ZOOKEEPER-999 . https://issues.apache.org/jira/browse/ZOOKEEPER-999 Diffs ----- ./bin/zkCleanup.sh 1141173 ./bin/zkCli.sh 1141173 ./bin/zkEnv.sh 1141173 ./bin/zkServer.sh 1141173 ./build.xml 1141176 ./ivy.xml 1141173 ./src/contrib/build-contrib.xml 1141173 ./src/contrib/build.xml 1141173 ./src/contrib/zkpython/build.xml 1141173 ./src/contrib/zkpython/ivy.xml PRE-CREATION ./src/contrib/zkpython/src/packages/deb/zkpython.control/control PRE-CREATION ./src/contrib/zkpython/src/packages/rpm/spec/zkpython.spec PRE-CREATION ./src/contrib/zkpython/src/python/setup.py 1141173 ./src/packages/deb/init.d/zookeeper PRE-CREATION ./src/packages/deb/zookeeper.control/conffile PRE-CREATION ./src/packages/deb/zookeeper.control/control PRE-CREATION ./src/packages/deb/zookeeper.control/postinst PRE-CREATION ./src/packages/deb/zookeeper.control/postrm PRE-CREATION ./src/packages/deb/zookeeper.control/preinst PRE-CREATION ./src/packages/deb/zookeeper.control/prerm PRE-CREATION ./src/packages/rpm/init.d/zookeeper PRE-CREATION ./src/packages/rpm/spec/zookeeper.spec PRE-CREATION ./src/packages/templates/conf/zoo.cfg PRE-CREATION ./src/packages/update-zookeeper-env.sh PRE-CREATION ./src/recipes/build-recipes.xml 1141173 ./src/recipes/build.xml 1141173 ./src/recipes/lock/build.xml 1141173 ./src/recipes/queue/build.xml 1141173 Diff: https://reviews.apache.org/r/1143/diff Testing ------- Thanks, Patrick
          Hide
          jiraposter@reviews.apache.org added a comment -

          On 2011-07-19 22:46:10, Patrick Hunt wrote:

          > 1) src/recipes/election has been added recently to trunk, are changes needed there as well? (see my comments below - seems like if we separated out pkg building from regular build it would make this more explicit/obvious)

          >

          > 2) i've been wondering for a while, perhaps we should have different scripts for zkServer.sh depending upon whether running in "development mode" and running in "package mode". There's alot of cruft in there having to do with determining which mode we are in and then setting up appropriately (zkCli, zkServer, zkCleanup, etc...).

          Patrick Hunt wrote:

          What do you think of this idea (2 in particular?) I guess hadoop is fine with this mixed use? Perhaps we can take some ideas from there an apply?

          Eric Yang wrote:

          1) Is there a plan to grow more recipes? If yes, I would recommend to use maven for build script because it allows submodule to call parent build profiles. We can have a centralized template for creating recipes rpm/deb packages. Ant recursive structure is difficult to maintain because the subdirectory build.xml file needs to refer to parent build.xml to include packaging templates, which generates too much repetitive tasks. Let's put recipes packaging as a separate task for future enhancement.

          2) Code reuse would be ideal. I am not sure if we want to have different scripts, perhaps consolidated functions would be sufficient to make organization cleaner.

          RE on 2) reapply some logic from Hadoop would be good. i.e. $PREFIX/sbin/-daemon.sh and $PREFIX/libexec/-config.sh would make the pattern cleaner.

          On 2011-07-19 22:46:10, Patrick Hunt wrote:

          > ./src/packages/update-zookeeper-env.sh, line 131

          > <https://reviews.apache.org/r/1143/diff/1/?file=26365#file26365line131>

          >

          > the group used is hadoop? (seems fine, just wondering...)

          Eric Yang wrote:

          I set the full stack of the software to be ownership by group hadoop for easier file ownership management.

          Patrick Hunt wrote:

          seems fine. Are you planning to participate in Bigtop? Would love to have you involved. It would be great to nail all this type of thing down so that it will be consistent. (or make it easy to configure if there's no consensus, ie figure out what ppl agree on and what not).

          I love to participate in Bigtop. For now, I am making sure the packages are consistent.

          • Eric

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/1143/#review1120
          -----------------------------------------------------------

          On 2011-07-19 22:15:38, Patrick Hunt wrote:

          -----------------------------------------------------------

          This is an automatically generated e-mail. To reply, visit:

          https://reviews.apache.org/r/1143/

          -----------------------------------------------------------

          (Updated 2011-07-19 22:15:38)

          Review request for zookeeper and Mahadev Konar.

          Summary

          -------

          This goal of this ticket is to generate a set of RPM/debian package which integrate well with RPM sets created by HADOOP-6255.

          This addresses bug ZOOKEEPER-999.

          https://issues.apache.org/jira/browse/ZOOKEEPER-999

          Diffs

          -----

          ./bin/zkCleanup.sh 1141173

          ./bin/zkCli.sh 1141173

          ./bin/zkEnv.sh 1141173

          ./bin/zkServer.sh 1141173

          ./build.xml 1141176

          ./ivy.xml 1141173

          ./src/contrib/build-contrib.xml 1141173

          ./src/contrib/build.xml 1141173

          ./src/contrib/zkpython/build.xml 1141173

          ./src/contrib/zkpython/ivy.xml PRE-CREATION

          ./src/contrib/zkpython/src/packages/deb/zkpython.control/control PRE-CREATION

          ./src/contrib/zkpython/src/packages/rpm/spec/zkpython.spec PRE-CREATION

          ./src/contrib/zkpython/src/python/setup.py 1141173

          ./src/packages/deb/init.d/zookeeper PRE-CREATION

          ./src/packages/deb/zookeeper.control/conffile PRE-CREATION

          ./src/packages/deb/zookeeper.control/control PRE-CREATION

          ./src/packages/deb/zookeeper.control/postinst PRE-CREATION

          ./src/packages/deb/zookeeper.control/postrm PRE-CREATION

          ./src/packages/deb/zookeeper.control/preinst PRE-CREATION

          ./src/packages/deb/zookeeper.control/prerm PRE-CREATION

          ./src/packages/rpm/init.d/zookeeper PRE-CREATION

          ./src/packages/rpm/spec/zookeeper.spec PRE-CREATION

          ./src/packages/templates/conf/zoo.cfg PRE-CREATION

          ./src/packages/update-zookeeper-env.sh PRE-CREATION

          ./src/recipes/build-recipes.xml 1141173

          ./src/recipes/build.xml 1141173

          ./src/recipes/lock/build.xml 1141173

          ./src/recipes/queue/build.xml 1141173

          Diff: https://reviews.apache.org/r/1143/diff

          Testing

          -------

          Thanks,

          Patrick

          Show
          jiraposter@reviews.apache.org added a comment - On 2011-07-19 22:46:10, Patrick Hunt wrote: > 1) src/recipes/election has been added recently to trunk, are changes needed there as well? (see my comments below - seems like if we separated out pkg building from regular build it would make this more explicit/obvious) > > 2) i've been wondering for a while, perhaps we should have different scripts for zkServer.sh depending upon whether running in "development mode" and running in "package mode". There's alot of cruft in there having to do with determining which mode we are in and then setting up appropriately (zkCli, zkServer, zkCleanup, etc...). Patrick Hunt wrote: What do you think of this idea (2 in particular?) I guess hadoop is fine with this mixed use? Perhaps we can take some ideas from there an apply? Eric Yang wrote: 1) Is there a plan to grow more recipes? If yes, I would recommend to use maven for build script because it allows submodule to call parent build profiles. We can have a centralized template for creating recipes rpm/deb packages. Ant recursive structure is difficult to maintain because the subdirectory build.xml file needs to refer to parent build.xml to include packaging templates, which generates too much repetitive tasks. Let's put recipes packaging as a separate task for future enhancement. 2) Code reuse would be ideal. I am not sure if we want to have different scripts, perhaps consolidated functions would be sufficient to make organization cleaner. RE on 2) reapply some logic from Hadoop would be good. i.e. $PREFIX/sbin/ -daemon.sh and $PREFIX/libexec/ -config.sh would make the pattern cleaner. On 2011-07-19 22:46:10, Patrick Hunt wrote: > ./src/packages/update-zookeeper-env.sh, line 131 > < https://reviews.apache.org/r/1143/diff/1/?file=26365#file26365line131 > > > the group used is hadoop? (seems fine, just wondering...) Eric Yang wrote: I set the full stack of the software to be ownership by group hadoop for easier file ownership management. Patrick Hunt wrote: seems fine. Are you planning to participate in Bigtop? Would love to have you involved. It would be great to nail all this type of thing down so that it will be consistent. (or make it easy to configure if there's no consensus, ie figure out what ppl agree on and what not). I love to participate in Bigtop. For now, I am making sure the packages are consistent. Eric ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1143/#review1120 ----------------------------------------------------------- On 2011-07-19 22:15:38, Patrick Hunt wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1143/ ----------------------------------------------------------- (Updated 2011-07-19 22:15:38) Review request for zookeeper and Mahadev Konar. Summary ------- This goal of this ticket is to generate a set of RPM/debian package which integrate well with RPM sets created by HADOOP-6255 . This addresses bug ZOOKEEPER-999 . https://issues.apache.org/jira/browse/ZOOKEEPER-999 Diffs ----- ./bin/zkCleanup.sh 1141173 ./bin/zkCli.sh 1141173 ./bin/zkEnv.sh 1141173 ./bin/zkServer.sh 1141173 ./build.xml 1141176 ./ivy.xml 1141173 ./src/contrib/build-contrib.xml 1141173 ./src/contrib/build.xml 1141173 ./src/contrib/zkpython/build.xml 1141173 ./src/contrib/zkpython/ivy.xml PRE-CREATION ./src/contrib/zkpython/src/packages/deb/zkpython.control/control PRE-CREATION ./src/contrib/zkpython/src/packages/rpm/spec/zkpython.spec PRE-CREATION ./src/contrib/zkpython/src/python/setup.py 1141173 ./src/packages/deb/init.d/zookeeper PRE-CREATION ./src/packages/deb/zookeeper.control/conffile PRE-CREATION ./src/packages/deb/zookeeper.control/control PRE-CREATION ./src/packages/deb/zookeeper.control/postinst PRE-CREATION ./src/packages/deb/zookeeper.control/postrm PRE-CREATION ./src/packages/deb/zookeeper.control/preinst PRE-CREATION ./src/packages/deb/zookeeper.control/prerm PRE-CREATION ./src/packages/rpm/init.d/zookeeper PRE-CREATION ./src/packages/rpm/spec/zookeeper.spec PRE-CREATION ./src/packages/templates/conf/zoo.cfg PRE-CREATION ./src/packages/update-zookeeper-env.sh PRE-CREATION ./src/recipes/build-recipes.xml 1141173 ./src/recipes/build.xml 1141173 ./src/recipes/lock/build.xml 1141173 ./src/recipes/queue/build.xml 1141173 Diff: https://reviews.apache.org/r/1143/diff Testing ------- Thanks, Patrick
          Hide
          Eric Yang added a comment -

          Address all issues found in path 4 except the release package would include C/Python binding libraries.

          Show
          Eric Yang added a comment - Address all issues found in path 4 except the release package would include C/Python binding libraries.
          Hide
          Eric Yang added a comment -

          Fix zoo.cfg template generation code to use trunk/conf/zoo_sample.cfg as base of the template.

          Show
          Eric Yang added a comment - Fix zoo.cfg template generation code to use trunk/conf/zoo_sample.cfg as base of the template.
          Hide
          jiraposter@reviews.apache.org added a comment -

          On 2011-07-19 22:46:10, Patrick Hunt wrote:

          > 1) src/recipes/election has been added recently to trunk, are changes needed there as well? (see my comments below - seems like if we separated out pkg building from regular build it would make this more explicit/obvious)

          >

          > 2) i've been wondering for a while, perhaps we should have different scripts for zkServer.sh depending upon whether running in "development mode" and running in "package mode". There's alot of cruft in there having to do with determining which mode we are in and then setting up appropriately (zkCli, zkServer, zkCleanup, etc...).

          Patrick Hunt wrote:

          What do you think of this idea (2 in particular?) I guess hadoop is fine with this mixed use? Perhaps we can take some ideas from there an apply?

          Eric Yang wrote:

          1) Is there a plan to grow more recipes? If yes, I would recommend to use maven for build script because it allows submodule to call parent build profiles. We can have a centralized template for creating recipes rpm/deb packages. Ant recursive structure is difficult to maintain because the subdirectory build.xml file needs to refer to parent build.xml to include packaging templates, which generates too much repetitive tasks. Let's put recipes packaging as a separate task for future enhancement.

          2) Code reuse would be ideal. I am not sure if we want to have different scripts, perhaps consolidated functions would be sufficient to make organization cleaner.

          Eric Yang wrote:

          RE on 2) reapply some logic from Hadoop would be good. i.e. $PREFIX/sbin/-daemon.sh and $PREFIX/libexec/-config.sh would make the pattern cleaner.

          re your 1) "Is there a plan to grow more recipes", yes, however I've proposed that we move it to it's own release artifact, so I think we are in wild agreement here, see:
          http://markmail.org/message/6nljas2ouivw53mw
          I'd like to do the same for contrib as well.

          re maven, I've submitted an initial patch here:
          https://issues.apache.org/jira/browse/ZOOKEEPER-1078
          I'd like to move everything over to maven, ping Mahadev to commit this.

          re 2) if you'd like to work on moving us over to some of that please do.

          • Patrick

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/1143/#review1120
          -----------------------------------------------------------

          On 2011-07-19 22:15:38, Patrick Hunt wrote:

          -----------------------------------------------------------

          This is an automatically generated e-mail. To reply, visit:

          https://reviews.apache.org/r/1143/

          -----------------------------------------------------------

          (Updated 2011-07-19 22:15:38)

          Review request for zookeeper and Mahadev Konar.

          Summary

          -------

          This goal of this ticket is to generate a set of RPM/debian package which integrate well with RPM sets created by HADOOP-6255.

          This addresses bug ZOOKEEPER-999.

          https://issues.apache.org/jira/browse/ZOOKEEPER-999

          Diffs

          -----

          ./bin/zkCleanup.sh 1141173

          ./bin/zkCli.sh 1141173

          ./bin/zkEnv.sh 1141173

          ./bin/zkServer.sh 1141173

          ./build.xml 1141176

          ./ivy.xml 1141173

          ./src/contrib/build-contrib.xml 1141173

          ./src/contrib/build.xml 1141173

          ./src/contrib/zkpython/build.xml 1141173

          ./src/contrib/zkpython/ivy.xml PRE-CREATION

          ./src/contrib/zkpython/src/packages/deb/zkpython.control/control PRE-CREATION

          ./src/contrib/zkpython/src/packages/rpm/spec/zkpython.spec PRE-CREATION

          ./src/contrib/zkpython/src/python/setup.py 1141173

          ./src/packages/deb/init.d/zookeeper PRE-CREATION

          ./src/packages/deb/zookeeper.control/conffile PRE-CREATION

          ./src/packages/deb/zookeeper.control/control PRE-CREATION

          ./src/packages/deb/zookeeper.control/postinst PRE-CREATION

          ./src/packages/deb/zookeeper.control/postrm PRE-CREATION

          ./src/packages/deb/zookeeper.control/preinst PRE-CREATION

          ./src/packages/deb/zookeeper.control/prerm PRE-CREATION

          ./src/packages/rpm/init.d/zookeeper PRE-CREATION

          ./src/packages/rpm/spec/zookeeper.spec PRE-CREATION

          ./src/packages/templates/conf/zoo.cfg PRE-CREATION

          ./src/packages/update-zookeeper-env.sh PRE-CREATION

          ./src/recipes/build-recipes.xml 1141173

          ./src/recipes/build.xml 1141173

          ./src/recipes/lock/build.xml 1141173

          ./src/recipes/queue/build.xml 1141173

          Diff: https://reviews.apache.org/r/1143/diff

          Testing

          -------

          Thanks,

          Patrick

          Show
          jiraposter@reviews.apache.org added a comment - On 2011-07-19 22:46:10, Patrick Hunt wrote: > 1) src/recipes/election has been added recently to trunk, are changes needed there as well? (see my comments below - seems like if we separated out pkg building from regular build it would make this more explicit/obvious) > > 2) i've been wondering for a while, perhaps we should have different scripts for zkServer.sh depending upon whether running in "development mode" and running in "package mode". There's alot of cruft in there having to do with determining which mode we are in and then setting up appropriately (zkCli, zkServer, zkCleanup, etc...). Patrick Hunt wrote: What do you think of this idea (2 in particular?) I guess hadoop is fine with this mixed use? Perhaps we can take some ideas from there an apply? Eric Yang wrote: 1) Is there a plan to grow more recipes? If yes, I would recommend to use maven for build script because it allows submodule to call parent build profiles. We can have a centralized template for creating recipes rpm/deb packages. Ant recursive structure is difficult to maintain because the subdirectory build.xml file needs to refer to parent build.xml to include packaging templates, which generates too much repetitive tasks. Let's put recipes packaging as a separate task for future enhancement. 2) Code reuse would be ideal. I am not sure if we want to have different scripts, perhaps consolidated functions would be sufficient to make organization cleaner. Eric Yang wrote: RE on 2) reapply some logic from Hadoop would be good. i.e. $PREFIX/sbin/ -daemon.sh and $PREFIX/libexec/ -config.sh would make the pattern cleaner. re your 1) "Is there a plan to grow more recipes", yes, however I've proposed that we move it to it's own release artifact, so I think we are in wild agreement here, see: http://markmail.org/message/6nljas2ouivw53mw I'd like to do the same for contrib as well. re maven, I've submitted an initial patch here: https://issues.apache.org/jira/browse/ZOOKEEPER-1078 I'd like to move everything over to maven, ping Mahadev to commit this. re 2) if you'd like to work on moving us over to some of that please do. Patrick ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1143/#review1120 ----------------------------------------------------------- On 2011-07-19 22:15:38, Patrick Hunt wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1143/ ----------------------------------------------------------- (Updated 2011-07-19 22:15:38) Review request for zookeeper and Mahadev Konar. Summary ------- This goal of this ticket is to generate a set of RPM/debian package which integrate well with RPM sets created by HADOOP-6255 . This addresses bug ZOOKEEPER-999 . https://issues.apache.org/jira/browse/ZOOKEEPER-999 Diffs ----- ./bin/zkCleanup.sh 1141173 ./bin/zkCli.sh 1141173 ./bin/zkEnv.sh 1141173 ./bin/zkServer.sh 1141173 ./build.xml 1141176 ./ivy.xml 1141173 ./src/contrib/build-contrib.xml 1141173 ./src/contrib/build.xml 1141173 ./src/contrib/zkpython/build.xml 1141173 ./src/contrib/zkpython/ivy.xml PRE-CREATION ./src/contrib/zkpython/src/packages/deb/zkpython.control/control PRE-CREATION ./src/contrib/zkpython/src/packages/rpm/spec/zkpython.spec PRE-CREATION ./src/contrib/zkpython/src/python/setup.py 1141173 ./src/packages/deb/init.d/zookeeper PRE-CREATION ./src/packages/deb/zookeeper.control/conffile PRE-CREATION ./src/packages/deb/zookeeper.control/control PRE-CREATION ./src/packages/deb/zookeeper.control/postinst PRE-CREATION ./src/packages/deb/zookeeper.control/postrm PRE-CREATION ./src/packages/deb/zookeeper.control/preinst PRE-CREATION ./src/packages/deb/zookeeper.control/prerm PRE-CREATION ./src/packages/rpm/init.d/zookeeper PRE-CREATION ./src/packages/rpm/spec/zookeeper.spec PRE-CREATION ./src/packages/templates/conf/zoo.cfg PRE-CREATION ./src/packages/update-zookeeper-env.sh PRE-CREATION ./src/recipes/build-recipes.xml 1141173 ./src/recipes/build.xml 1141173 ./src/recipes/lock/build.xml 1141173 ./src/recipes/queue/build.xml 1141173 Diff: https://reviews.apache.org/r/1143/diff Testing ------- Thanks, Patrick
          Hide
          jiraposter@reviews.apache.org added a comment -

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/1143/
          -----------------------------------------------------------

          (Updated 2011-07-20 17:45:08.665910)

          Review request for zookeeper and Mahadev Konar.

          Changes
          -------

          updated from Eric.

          Summary
          -------

          This goal of this ticket is to generate a set of RPM/debian package which integrate well with RPM sets created by HADOOP-6255.

          This addresses bug ZOOKEEPER-999.
          https://issues.apache.org/jira/browse/ZOOKEEPER-999

          Diffs (updated)


          ./bin/zkCleanup.sh 1148587
          ./bin/zkCli.sh 1148587
          ./bin/zkEnv.sh 1148587
          ./bin/zkServer.sh 1148587
          ./build.xml 1148587
          ./ivy.xml 1148587
          ./src/contrib/build-contrib.xml 1148587
          ./src/contrib/build.xml 1148587
          ./src/contrib/zkpython/build.xml 1148587
          ./src/contrib/zkpython/ivy.xml PRE-CREATION
          ./src/contrib/zkpython/src/packages/deb/zkpython.control/control PRE-CREATION
          ./src/contrib/zkpython/src/packages/rpm/spec/zkpython.spec PRE-CREATION
          ./src/contrib/zkpython/src/python/setup.py 1148587
          ./src/packages/deb/init.d/zookeeper PRE-CREATION
          ./src/packages/deb/zookeeper.control/conffile PRE-CREATION
          ./src/packages/deb/zookeeper.control/control PRE-CREATION
          ./src/packages/deb/zookeeper.control/postinst PRE-CREATION
          ./src/packages/deb/zookeeper.control/postrm PRE-CREATION
          ./src/packages/deb/zookeeper.control/preinst PRE-CREATION
          ./src/packages/deb/zookeeper.control/prerm PRE-CREATION
          ./src/packages/rpm/init.d/zookeeper PRE-CREATION
          ./src/packages/rpm/spec/zookeeper.spec PRE-CREATION
          ./src/packages/templates/conf/zookeeper-env.sh PRE-CREATION
          ./src/packages/update-zookeeper-env.sh PRE-CREATION
          ./src/recipes/build-recipes.xml 1148587
          ./src/recipes/build.xml 1148587
          ./src/recipes/lock/build.xml 1148587
          ./src/recipes/queue/build.xml 1148587

          Diff: https://reviews.apache.org/r/1143/diff

          Testing
          -------

          Thanks,

          Patrick

          Show
          jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1143/ ----------------------------------------------------------- (Updated 2011-07-20 17:45:08.665910) Review request for zookeeper and Mahadev Konar. Changes ------- updated from Eric. Summary ------- This goal of this ticket is to generate a set of RPM/debian package which integrate well with RPM sets created by HADOOP-6255 . This addresses bug ZOOKEEPER-999 . https://issues.apache.org/jira/browse/ZOOKEEPER-999 Diffs (updated) ./bin/zkCleanup.sh 1148587 ./bin/zkCli.sh 1148587 ./bin/zkEnv.sh 1148587 ./bin/zkServer.sh 1148587 ./build.xml 1148587 ./ivy.xml 1148587 ./src/contrib/build-contrib.xml 1148587 ./src/contrib/build.xml 1148587 ./src/contrib/zkpython/build.xml 1148587 ./src/contrib/zkpython/ivy.xml PRE-CREATION ./src/contrib/zkpython/src/packages/deb/zkpython.control/control PRE-CREATION ./src/contrib/zkpython/src/packages/rpm/spec/zkpython.spec PRE-CREATION ./src/contrib/zkpython/src/python/setup.py 1148587 ./src/packages/deb/init.d/zookeeper PRE-CREATION ./src/packages/deb/zookeeper.control/conffile PRE-CREATION ./src/packages/deb/zookeeper.control/control PRE-CREATION ./src/packages/deb/zookeeper.control/postinst PRE-CREATION ./src/packages/deb/zookeeper.control/postrm PRE-CREATION ./src/packages/deb/zookeeper.control/preinst PRE-CREATION ./src/packages/deb/zookeeper.control/prerm PRE-CREATION ./src/packages/rpm/init.d/zookeeper PRE-CREATION ./src/packages/rpm/spec/zookeeper.spec PRE-CREATION ./src/packages/templates/conf/zookeeper-env.sh PRE-CREATION ./src/packages/update-zookeeper-env.sh PRE-CREATION ./src/recipes/build-recipes.xml 1148587 ./src/recipes/build.xml 1148587 ./src/recipes/lock/build.xml 1148587 ./src/recipes/queue/build.xml 1148587 Diff: https://reviews.apache.org/r/1143/diff Testing ------- Thanks, Patrick
          Hide
          jiraposter@reviews.apache.org added a comment -

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/1143/#review1140
          -----------------------------------------------------------

          a few small issues

          ./build.xml
          <https://reviews.apache.org/r/1143/#comment2369>

          yes, much nicer.

          we should add building pkgs as a job on jenkins - to verify we don't break this/other things. (would you mind filing a jira?)

          ./src/contrib/zkpython/ivy.xml
          <https://reviews.apache.org/r/1143/#comment2370>

          zookeeper?

          ./src/packages/templates/conf/zoo.cfg
          <https://reviews.apache.org/r/1143/#comment2371>

          no longer needed?

          ./build.xml
          <https://reviews.apache.org/r/1143/#comment2372>

          don't you mean to have a dependency on package-native here rather than compile-native?

          • Patrick

          On 2011-07-20 17:45:08, Patrick Hunt wrote:

          -----------------------------------------------------------

          This is an automatically generated e-mail. To reply, visit:

          https://reviews.apache.org/r/1143/

          -----------------------------------------------------------

          (Updated 2011-07-20 17:45:08)

          Review request for zookeeper and Mahadev Konar.

          Summary

          -------

          This goal of this ticket is to generate a set of RPM/debian package which integrate well with RPM sets created by HADOOP-6255.

          This addresses bug ZOOKEEPER-999.

          https://issues.apache.org/jira/browse/ZOOKEEPER-999

          Diffs

          -----

          ./bin/zkCleanup.sh 1148587

          ./bin/zkCli.sh 1148587

          ./bin/zkEnv.sh 1148587

          ./bin/zkServer.sh 1148587

          ./build.xml 1148587

          ./ivy.xml 1148587

          ./src/contrib/build-contrib.xml 1148587

          ./src/contrib/build.xml 1148587

          ./src/contrib/zkpython/build.xml 1148587

          ./src/contrib/zkpython/ivy.xml PRE-CREATION

          ./src/contrib/zkpython/src/packages/deb/zkpython.control/control PRE-CREATION

          ./src/contrib/zkpython/src/packages/rpm/spec/zkpython.spec PRE-CREATION

          ./src/contrib/zkpython/src/python/setup.py 1148587

          ./src/packages/deb/init.d/zookeeper PRE-CREATION

          ./src/packages/deb/zookeeper.control/conffile PRE-CREATION

          ./src/packages/deb/zookeeper.control/control PRE-CREATION

          ./src/packages/deb/zookeeper.control/postinst PRE-CREATION

          ./src/packages/deb/zookeeper.control/postrm PRE-CREATION

          ./src/packages/deb/zookeeper.control/preinst PRE-CREATION

          ./src/packages/deb/zookeeper.control/prerm PRE-CREATION

          ./src/packages/rpm/init.d/zookeeper PRE-CREATION

          ./src/packages/rpm/spec/zookeeper.spec PRE-CREATION

          ./src/packages/templates/conf/zookeeper-env.sh PRE-CREATION

          ./src/packages/update-zookeeper-env.sh PRE-CREATION

          ./src/recipes/build-recipes.xml 1148587

          ./src/recipes/build.xml 1148587

          ./src/recipes/lock/build.xml 1148587

          ./src/recipes/queue/build.xml 1148587

          Diff: https://reviews.apache.org/r/1143/diff

          Testing

          -------

          Thanks,

          Patrick

          Show
          jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1143/#review1140 ----------------------------------------------------------- a few small issues ./build.xml < https://reviews.apache.org/r/1143/#comment2369 > yes, much nicer. we should add building pkgs as a job on jenkins - to verify we don't break this/other things. (would you mind filing a jira?) ./src/contrib/zkpython/ivy.xml < https://reviews.apache.org/r/1143/#comment2370 > zookeeper? ./src/packages/templates/conf/zoo.cfg < https://reviews.apache.org/r/1143/#comment2371 > no longer needed? ./build.xml < https://reviews.apache.org/r/1143/#comment2372 > don't you mean to have a dependency on package-native here rather than compile-native? Patrick On 2011-07-20 17:45:08, Patrick Hunt wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1143/ ----------------------------------------------------------- (Updated 2011-07-20 17:45:08) Review request for zookeeper and Mahadev Konar. Summary ------- This goal of this ticket is to generate a set of RPM/debian package which integrate well with RPM sets created by HADOOP-6255 . This addresses bug ZOOKEEPER-999 . https://issues.apache.org/jira/browse/ZOOKEEPER-999 Diffs ----- ./bin/zkCleanup.sh 1148587 ./bin/zkCli.sh 1148587 ./bin/zkEnv.sh 1148587 ./bin/zkServer.sh 1148587 ./build.xml 1148587 ./ivy.xml 1148587 ./src/contrib/build-contrib.xml 1148587 ./src/contrib/build.xml 1148587 ./src/contrib/zkpython/build.xml 1148587 ./src/contrib/zkpython/ivy.xml PRE-CREATION ./src/contrib/zkpython/src/packages/deb/zkpython.control/control PRE-CREATION ./src/contrib/zkpython/src/packages/rpm/spec/zkpython.spec PRE-CREATION ./src/contrib/zkpython/src/python/setup.py 1148587 ./src/packages/deb/init.d/zookeeper PRE-CREATION ./src/packages/deb/zookeeper.control/conffile PRE-CREATION ./src/packages/deb/zookeeper.control/control PRE-CREATION ./src/packages/deb/zookeeper.control/postinst PRE-CREATION ./src/packages/deb/zookeeper.control/postrm PRE-CREATION ./src/packages/deb/zookeeper.control/preinst PRE-CREATION ./src/packages/deb/zookeeper.control/prerm PRE-CREATION ./src/packages/rpm/init.d/zookeeper PRE-CREATION ./src/packages/rpm/spec/zookeeper.spec PRE-CREATION ./src/packages/templates/conf/zookeeper-env.sh PRE-CREATION ./src/packages/update-zookeeper-env.sh PRE-CREATION ./src/recipes/build-recipes.xml 1148587 ./src/recipes/build.xml 1148587 ./src/recipes/lock/build.xml 1148587 ./src/recipes/queue/build.xml 1148587 Diff: https://reviews.apache.org/r/1143/diff Testing ------- Thanks, Patrick
          Hide
          Eric Yang added a comment -

          Jenkins server has Python.h installed, submit patch for build test.

          Show
          Eric Yang added a comment - Jenkins server has Python.h installed, submit patch for build test.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12487204/ZOOKEEPER-999-7.patch
          against trunk revision 1148553.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 12 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          -1 release audit. The applied patch generated 31 release audit warnings (more than the trunk's current 24 warnings).

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/405//testReport/
          Release audit warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/405//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
          Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/405//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/405//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12487204/ZOOKEEPER-999-7.patch against trunk revision 1148553. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 12 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. -1 release audit. The applied patch generated 31 release audit warnings (more than the trunk's current 24 warnings). +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/405//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/405//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/405//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/405//console This message is automatically generated.
          Hide
          jiraposter@reviews.apache.org added a comment -

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/1143/
          -----------------------------------------------------------

          (Updated 2011-07-21 05:31:05.468929)

          Review request for zookeeper and Mahadev Konar.

          Changes
          -------

          update from Eric

          Summary
          -------

          This goal of this ticket is to generate a set of RPM/debian package which integrate well with RPM sets created by HADOOP-6255.

          This addresses bug ZOOKEEPER-999.
          https://issues.apache.org/jira/browse/ZOOKEEPER-999

          Diffs (updated)


          ./bin/zkCleanup.sh 1148587
          ./bin/zkCli.sh 1148587
          ./bin/zkEnv.sh 1148587
          ./bin/zkServer.sh 1148587
          ./build.xml 1148587
          ./ivy.xml 1148587
          ./src/contrib/build-contrib.xml 1148587
          ./src/contrib/build.xml 1148587
          ./src/contrib/zkpython/build.xml 1148587
          ./src/contrib/zkpython/ivy.xml PRE-CREATION
          ./src/contrib/zkpython/src/packages/deb/zkpython.control/control PRE-CREATION
          ./src/contrib/zkpython/src/packages/rpm/spec/zkpython.spec PRE-CREATION
          ./src/contrib/zkpython/src/python/setup.py 1148587
          ./src/packages/deb/init.d/zookeeper PRE-CREATION
          ./src/packages/deb/zookeeper.control/conffile PRE-CREATION
          ./src/packages/deb/zookeeper.control/control PRE-CREATION
          ./src/packages/deb/zookeeper.control/postinst PRE-CREATION
          ./src/packages/deb/zookeeper.control/postrm PRE-CREATION
          ./src/packages/deb/zookeeper.control/preinst PRE-CREATION
          ./src/packages/deb/zookeeper.control/prerm PRE-CREATION
          ./src/packages/rpm/init.d/zookeeper PRE-CREATION
          ./src/packages/rpm/spec/zookeeper.spec PRE-CREATION
          ./src/packages/templates/conf/zookeeper-env.sh PRE-CREATION
          ./src/packages/update-zookeeper-env.sh PRE-CREATION
          ./src/recipes/build-recipes.xml 1148587
          ./src/recipes/build.xml 1148587
          ./src/recipes/lock/build.xml 1148587
          ./src/recipes/queue/build.xml 1148587

          Diff: https://reviews.apache.org/r/1143/diff

          Testing
          -------

          Thanks,

          Patrick

          Show
          jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1143/ ----------------------------------------------------------- (Updated 2011-07-21 05:31:05.468929) Review request for zookeeper and Mahadev Konar. Changes ------- update from Eric Summary ------- This goal of this ticket is to generate a set of RPM/debian package which integrate well with RPM sets created by HADOOP-6255 . This addresses bug ZOOKEEPER-999 . https://issues.apache.org/jira/browse/ZOOKEEPER-999 Diffs (updated) ./bin/zkCleanup.sh 1148587 ./bin/zkCli.sh 1148587 ./bin/zkEnv.sh 1148587 ./bin/zkServer.sh 1148587 ./build.xml 1148587 ./ivy.xml 1148587 ./src/contrib/build-contrib.xml 1148587 ./src/contrib/build.xml 1148587 ./src/contrib/zkpython/build.xml 1148587 ./src/contrib/zkpython/ivy.xml PRE-CREATION ./src/contrib/zkpython/src/packages/deb/zkpython.control/control PRE-CREATION ./src/contrib/zkpython/src/packages/rpm/spec/zkpython.spec PRE-CREATION ./src/contrib/zkpython/src/python/setup.py 1148587 ./src/packages/deb/init.d/zookeeper PRE-CREATION ./src/packages/deb/zookeeper.control/conffile PRE-CREATION ./src/packages/deb/zookeeper.control/control PRE-CREATION ./src/packages/deb/zookeeper.control/postinst PRE-CREATION ./src/packages/deb/zookeeper.control/postrm PRE-CREATION ./src/packages/deb/zookeeper.control/preinst PRE-CREATION ./src/packages/deb/zookeeper.control/prerm PRE-CREATION ./src/packages/rpm/init.d/zookeeper PRE-CREATION ./src/packages/rpm/spec/zookeeper.spec PRE-CREATION ./src/packages/templates/conf/zookeeper-env.sh PRE-CREATION ./src/packages/update-zookeeper-env.sh PRE-CREATION ./src/recipes/build-recipes.xml 1148587 ./src/recipes/build.xml 1148587 ./src/recipes/lock/build.xml 1148587 ./src/recipes/queue/build.xml 1148587 Diff: https://reviews.apache.org/r/1143/diff Testing ------- Thanks, Patrick
          Hide
          jiraposter@reviews.apache.org added a comment -

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/1143/#review1149
          -----------------------------------------------------------

          I ran "ant deb" successfully, although I have not yet tried to install it. I noticed a couple issues with the generated package.

          shouldn't /etc/zookeeper contain zoo.cfg?

          drwxr-xr-x 0/0 0 2011-07-20 22:41 ./etc/
          drwxr-xr-x 0/0 0 2011-07-20 22:41 ./etc/zookeeper/
          rw-rr- 0/0 535 2011-07-20 22:41 ./etc/zookeeper/configuration.xsl
          rw-rr- 0/0 2161 2011-07-20 22:41 ./etc/zookeeper/log4j.properties
          rw-rr- 0/0 447 2011-07-20 22:41 ./etc/zookeeper/zoo_sample.cfg

          shouldn't we be creating (if doesn't exist) the /var/lib/zookeeper directory? ZK does this currently, however I'm planning to file a bug for this - really we shouldn't come up if we can't find this directory (handles case of misconfiguration - we stop rather than start with an empty data hierarchy)

          Can you add some documentation? Nothing fancy, perhaps a README_packaging.txt at the toplevel that describes the currently supported packages, some basic information about them, how to build "ant deb" etc..., additional requirements to build, etc... something basic to help out someone trying to build the packages.

          ./src/packages/deb/zookeeper.control/control
          <https://reviews.apache.org/r/1143/#comment2380>

          ZooKeeper only supports sun jdk/jre, not openjdk

          • Patrick

          On 2011-07-21 05:31:05, Patrick Hunt wrote:

          -----------------------------------------------------------

          This is an automatically generated e-mail. To reply, visit:

          https://reviews.apache.org/r/1143/

          -----------------------------------------------------------

          (Updated 2011-07-21 05:31:05)

          Review request for zookeeper and Mahadev Konar.

          Summary

          -------

          This goal of this ticket is to generate a set of RPM/debian package which integrate well with RPM sets created by HADOOP-6255.

          This addresses bug ZOOKEEPER-999.

          https://issues.apache.org/jira/browse/ZOOKEEPER-999

          Diffs

          -----

          ./bin/zkCleanup.sh 1148587

          ./bin/zkCli.sh 1148587

          ./bin/zkEnv.sh 1148587

          ./bin/zkServer.sh 1148587

          ./build.xml 1148587

          ./ivy.xml 1148587

          ./src/contrib/build-contrib.xml 1148587

          ./src/contrib/build.xml 1148587

          ./src/contrib/zkpython/build.xml 1148587

          ./src/contrib/zkpython/ivy.xml PRE-CREATION

          ./src/contrib/zkpython/src/packages/deb/zkpython.control/control PRE-CREATION

          ./src/contrib/zkpython/src/packages/rpm/spec/zkpython.spec PRE-CREATION

          ./src/contrib/zkpython/src/python/setup.py 1148587

          ./src/packages/deb/init.d/zookeeper PRE-CREATION

          ./src/packages/deb/zookeeper.control/conffile PRE-CREATION

          ./src/packages/deb/zookeeper.control/control PRE-CREATION

          ./src/packages/deb/zookeeper.control/postinst PRE-CREATION

          ./src/packages/deb/zookeeper.control/postrm PRE-CREATION

          ./src/packages/deb/zookeeper.control/preinst PRE-CREATION

          ./src/packages/deb/zookeeper.control/prerm PRE-CREATION

          ./src/packages/rpm/init.d/zookeeper PRE-CREATION

          ./src/packages/rpm/spec/zookeeper.spec PRE-CREATION

          ./src/packages/templates/conf/zookeeper-env.sh PRE-CREATION

          ./src/packages/update-zookeeper-env.sh PRE-CREATION

          ./src/recipes/build-recipes.xml 1148587

          ./src/recipes/build.xml 1148587

          ./src/recipes/lock/build.xml 1148587

          ./src/recipes/queue/build.xml 1148587

          Diff: https://reviews.apache.org/r/1143/diff

          Testing

          -------

          Thanks,

          Patrick

          Show
          jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1143/#review1149 ----------------------------------------------------------- I ran "ant deb" successfully, although I have not yet tried to install it. I noticed a couple issues with the generated package. shouldn't /etc/zookeeper contain zoo.cfg? drwxr-xr-x 0/0 0 2011-07-20 22:41 ./etc/ drwxr-xr-x 0/0 0 2011-07-20 22:41 ./etc/zookeeper/ rw-r r - 0/0 535 2011-07-20 22:41 ./etc/zookeeper/configuration.xsl rw-r r - 0/0 2161 2011-07-20 22:41 ./etc/zookeeper/log4j.properties rw-r r - 0/0 447 2011-07-20 22:41 ./etc/zookeeper/zoo_sample.cfg shouldn't we be creating (if doesn't exist) the /var/lib/zookeeper directory? ZK does this currently, however I'm planning to file a bug for this - really we shouldn't come up if we can't find this directory (handles case of misconfiguration - we stop rather than start with an empty data hierarchy) Can you add some documentation? Nothing fancy, perhaps a README_packaging.txt at the toplevel that describes the currently supported packages, some basic information about them, how to build "ant deb" etc..., additional requirements to build, etc... something basic to help out someone trying to build the packages. ./src/packages/deb/zookeeper.control/control < https://reviews.apache.org/r/1143/#comment2380 > ZooKeeper only supports sun jdk/jre, not openjdk Patrick On 2011-07-21 05:31:05, Patrick Hunt wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1143/ ----------------------------------------------------------- (Updated 2011-07-21 05:31:05) Review request for zookeeper and Mahadev Konar. Summary ------- This goal of this ticket is to generate a set of RPM/debian package which integrate well with RPM sets created by HADOOP-6255 . This addresses bug ZOOKEEPER-999 . https://issues.apache.org/jira/browse/ZOOKEEPER-999 Diffs ----- ./bin/zkCleanup.sh 1148587 ./bin/zkCli.sh 1148587 ./bin/zkEnv.sh 1148587 ./bin/zkServer.sh 1148587 ./build.xml 1148587 ./ivy.xml 1148587 ./src/contrib/build-contrib.xml 1148587 ./src/contrib/build.xml 1148587 ./src/contrib/zkpython/build.xml 1148587 ./src/contrib/zkpython/ivy.xml PRE-CREATION ./src/contrib/zkpython/src/packages/deb/zkpython.control/control PRE-CREATION ./src/contrib/zkpython/src/packages/rpm/spec/zkpython.spec PRE-CREATION ./src/contrib/zkpython/src/python/setup.py 1148587 ./src/packages/deb/init.d/zookeeper PRE-CREATION ./src/packages/deb/zookeeper.control/conffile PRE-CREATION ./src/packages/deb/zookeeper.control/control PRE-CREATION ./src/packages/deb/zookeeper.control/postinst PRE-CREATION ./src/packages/deb/zookeeper.control/postrm PRE-CREATION ./src/packages/deb/zookeeper.control/preinst PRE-CREATION ./src/packages/deb/zookeeper.control/prerm PRE-CREATION ./src/packages/rpm/init.d/zookeeper PRE-CREATION ./src/packages/rpm/spec/zookeeper.spec PRE-CREATION ./src/packages/templates/conf/zookeeper-env.sh PRE-CREATION ./src/packages/update-zookeeper-env.sh PRE-CREATION ./src/recipes/build-recipes.xml 1148587 ./src/recipes/build.xml 1148587 ./src/recipes/lock/build.xml 1148587 ./src/recipes/queue/build.xml 1148587 Diff: https://reviews.apache.org/r/1143/diff Testing ------- Thanks, Patrick
          Hide
          jiraposter@reviews.apache.org added a comment -

          On 2011-07-20 18:00:29, Patrick Hunt wrote:

          > ./src/packages/templates/conf/zoo.cfg, lines 1-12

          > <https://reviews.apache.org/r/1143/diff/1/?file=26364#file26364line1>

          >

          > no longer needed?

          Yes

          On 2011-07-20 18:00:29, Patrick Hunt wrote:

          > ./build.xml, lines 750-754

          > <https://reviews.apache.org/r/1143/diff/1-2/?file=26346#file26346line750>

          >

          > yes, much nicer.

          >

          > we should add building pkgs as a job on jenkins - to verify we don't break this/other things. (would you mind filing a jira?)

          https://issues.apache.org/jira/browse/ZOOKEEPER-1129 filed.

          On 2011-07-20 18:00:29, Patrick Hunt wrote:

          > ./src/contrib/zkpython/ivy.xml, line 24

          > <https://reviews.apache.org/r/1143/diff/1-2/?file=26351#file26351line24>

          >

          > zookeeper?

          Fixed in ZOOKEEPER-999-7.patch

          On 2011-07-20 18:00:29, Patrick Hunt wrote:

          > ./build.xml, line 905

          > <https://reviews.apache.org/r/1143/diff/2/?file=26497#file26497line905>

          >

          > don't you mean to have a dependency on package-native here rather than compile-native?

          Good catch. Fixed in ZOOKEEPER-999-7.patch.

          • Eric

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/1143/#review1140
          -----------------------------------------------------------

          On 2011-07-21 05:31:05, Patrick Hunt wrote:

          -----------------------------------------------------------

          This is an automatically generated e-mail. To reply, visit:

          https://reviews.apache.org/r/1143/

          -----------------------------------------------------------

          (Updated 2011-07-21 05:31:05)

          Review request for zookeeper and Mahadev Konar.

          Summary

          -------

          This goal of this ticket is to generate a set of RPM/debian package which integrate well with RPM sets created by HADOOP-6255.

          This addresses bug ZOOKEEPER-999.

          https://issues.apache.org/jira/browse/ZOOKEEPER-999

          Diffs

          -----

          ./bin/zkCleanup.sh 1148587

          ./bin/zkCli.sh 1148587

          ./bin/zkEnv.sh 1148587

          ./bin/zkServer.sh 1148587

          ./build.xml 1148587

          ./ivy.xml 1148587

          ./src/contrib/build-contrib.xml 1148587

          ./src/contrib/build.xml 1148587

          ./src/contrib/zkpython/build.xml 1148587

          ./src/contrib/zkpython/ivy.xml PRE-CREATION

          ./src/contrib/zkpython/src/packages/deb/zkpython.control/control PRE-CREATION

          ./src/contrib/zkpython/src/packages/rpm/spec/zkpython.spec PRE-CREATION

          ./src/contrib/zkpython/src/python/setup.py 1148587

          ./src/packages/deb/init.d/zookeeper PRE-CREATION

          ./src/packages/deb/zookeeper.control/conffile PRE-CREATION

          ./src/packages/deb/zookeeper.control/control PRE-CREATION

          ./src/packages/deb/zookeeper.control/postinst PRE-CREATION

          ./src/packages/deb/zookeeper.control/postrm PRE-CREATION

          ./src/packages/deb/zookeeper.control/preinst PRE-CREATION

          ./src/packages/deb/zookeeper.control/prerm PRE-CREATION

          ./src/packages/rpm/init.d/zookeeper PRE-CREATION

          ./src/packages/rpm/spec/zookeeper.spec PRE-CREATION

          ./src/packages/templates/conf/zookeeper-env.sh PRE-CREATION

          ./src/packages/update-zookeeper-env.sh PRE-CREATION

          ./src/recipes/build-recipes.xml 1148587

          ./src/recipes/build.xml 1148587

          ./src/recipes/lock/build.xml 1148587

          ./src/recipes/queue/build.xml 1148587

          Diff: https://reviews.apache.org/r/1143/diff

          Testing

          -------

          Thanks,

          Patrick

          Show
          jiraposter@reviews.apache.org added a comment - On 2011-07-20 18:00:29, Patrick Hunt wrote: > ./src/packages/templates/conf/zoo.cfg, lines 1-12 > < https://reviews.apache.org/r/1143/diff/1/?file=26364#file26364line1 > > > no longer needed? Yes On 2011-07-20 18:00:29, Patrick Hunt wrote: > ./build.xml, lines 750-754 > < https://reviews.apache.org/r/1143/diff/1-2/?file=26346#file26346line750 > > > yes, much nicer. > > we should add building pkgs as a job on jenkins - to verify we don't break this/other things. (would you mind filing a jira?) https://issues.apache.org/jira/browse/ZOOKEEPER-1129 filed. On 2011-07-20 18:00:29, Patrick Hunt wrote: > ./src/contrib/zkpython/ivy.xml, line 24 > < https://reviews.apache.org/r/1143/diff/1-2/?file=26351#file26351line24 > > > zookeeper? Fixed in ZOOKEEPER-999 -7.patch On 2011-07-20 18:00:29, Patrick Hunt wrote: > ./build.xml, line 905 > < https://reviews.apache.org/r/1143/diff/2/?file=26497#file26497line905 > > > don't you mean to have a dependency on package-native here rather than compile-native? Good catch. Fixed in ZOOKEEPER-999 -7.patch. Eric ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1143/#review1140 ----------------------------------------------------------- On 2011-07-21 05:31:05, Patrick Hunt wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1143/ ----------------------------------------------------------- (Updated 2011-07-21 05:31:05) Review request for zookeeper and Mahadev Konar. Summary ------- This goal of this ticket is to generate a set of RPM/debian package which integrate well with RPM sets created by HADOOP-6255 . This addresses bug ZOOKEEPER-999 . https://issues.apache.org/jira/browse/ZOOKEEPER-999 Diffs ----- ./bin/zkCleanup.sh 1148587 ./bin/zkCli.sh 1148587 ./bin/zkEnv.sh 1148587 ./bin/zkServer.sh 1148587 ./build.xml 1148587 ./ivy.xml 1148587 ./src/contrib/build-contrib.xml 1148587 ./src/contrib/build.xml 1148587 ./src/contrib/zkpython/build.xml 1148587 ./src/contrib/zkpython/ivy.xml PRE-CREATION ./src/contrib/zkpython/src/packages/deb/zkpython.control/control PRE-CREATION ./src/contrib/zkpython/src/packages/rpm/spec/zkpython.spec PRE-CREATION ./src/contrib/zkpython/src/python/setup.py 1148587 ./src/packages/deb/init.d/zookeeper PRE-CREATION ./src/packages/deb/zookeeper.control/conffile PRE-CREATION ./src/packages/deb/zookeeper.control/control PRE-CREATION ./src/packages/deb/zookeeper.control/postinst PRE-CREATION ./src/packages/deb/zookeeper.control/postrm PRE-CREATION ./src/packages/deb/zookeeper.control/preinst PRE-CREATION ./src/packages/deb/zookeeper.control/prerm PRE-CREATION ./src/packages/rpm/init.d/zookeeper PRE-CREATION ./src/packages/rpm/spec/zookeeper.spec PRE-CREATION ./src/packages/templates/conf/zookeeper-env.sh PRE-CREATION ./src/packages/update-zookeeper-env.sh PRE-CREATION ./src/recipes/build-recipes.xml 1148587 ./src/recipes/build.xml 1148587 ./src/recipes/lock/build.xml 1148587 ./src/recipes/queue/build.xml 1148587 Diff: https://reviews.apache.org/r/1143/diff Testing ------- Thanks, Patrick
          Hide
          Eric Yang added a comment -

          Updated README_packaging.txt, and fix start up script for running ZooKeeper in Debian flavor of Linux.

          Show
          Eric Yang added a comment - Updated README_packaging.txt, and fix start up script for running ZooKeeper in Debian flavor of Linux.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12487370/ZOOKEEPER-999-8.patch
          against trunk revision 1148553.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 12 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          -1 release audit. The applied patch generated 32 release audit warnings (more than the trunk's current 24 warnings).

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/407//testReport/
          Release audit warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/407//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
          Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/407//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/407//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12487370/ZOOKEEPER-999-8.patch against trunk revision 1148553. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 12 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. -1 release audit. The applied patch generated 32 release audit warnings (more than the trunk's current 24 warnings). +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/407//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/407//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/407//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/407//console This message is automatically generated.
          Hide
          jiraposter@reviews.apache.org added a comment -

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/1143/
          -----------------------------------------------------------

          (Updated 2011-07-22 18:24:20.565434)

          Review request for zookeeper and Mahadev Konar.

          Changes
          -------

          update 8 from eric

          Summary
          -------

          This goal of this ticket is to generate a set of RPM/debian package which integrate well with RPM sets created by HADOOP-6255.

          This addresses bug ZOOKEEPER-999.
          https://issues.apache.org/jira/browse/ZOOKEEPER-999

          Diffs (updated)


          ./README_packaging.txt PRE-CREATION
          ./bin/zkCleanup.sh 1148587
          ./bin/zkCli.sh 1148587
          ./bin/zkEnv.sh 1148587
          ./bin/zkServer.sh 1148587
          ./build.xml 1148587
          ./ivy.xml 1148587
          ./src/contrib/build-contrib.xml 1148587
          ./src/contrib/build.xml 1148587
          ./src/contrib/zkpython/build.xml 1148587
          ./src/contrib/zkpython/ivy.xml PRE-CREATION
          ./src/contrib/zkpython/src/packages/deb/zkpython.control/control PRE-CREATION
          ./src/contrib/zkpython/src/packages/rpm/spec/zkpython.spec PRE-CREATION
          ./src/contrib/zkpython/src/python/setup.py 1148587
          ./src/packages/deb/init.d/zookeeper PRE-CREATION
          ./src/packages/deb/zookeeper.control/conffile PRE-CREATION
          ./src/packages/deb/zookeeper.control/control PRE-CREATION
          ./src/packages/deb/zookeeper.control/postinst PRE-CREATION
          ./src/packages/deb/zookeeper.control/postrm PRE-CREATION
          ./src/packages/deb/zookeeper.control/preinst PRE-CREATION
          ./src/packages/deb/zookeeper.control/prerm PRE-CREATION
          ./src/packages/rpm/init.d/zookeeper PRE-CREATION
          ./src/packages/rpm/spec/zookeeper.spec PRE-CREATION
          ./src/packages/templates/conf/zookeeper-env.sh PRE-CREATION
          ./src/packages/update-zookeeper-env.sh PRE-CREATION
          ./src/recipes/build-recipes.xml 1148587
          ./src/recipes/build.xml 1148587
          ./src/recipes/lock/build.xml 1148587
          ./src/recipes/queue/build.xml 1148587

          Diff: https://reviews.apache.org/r/1143/diff

          Testing
          -------

          Thanks,

          Patrick

          Show
          jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1143/ ----------------------------------------------------------- (Updated 2011-07-22 18:24:20.565434) Review request for zookeeper and Mahadev Konar. Changes ------- update 8 from eric Summary ------- This goal of this ticket is to generate a set of RPM/debian package which integrate well with RPM sets created by HADOOP-6255 . This addresses bug ZOOKEEPER-999 . https://issues.apache.org/jira/browse/ZOOKEEPER-999 Diffs (updated) ./README_packaging.txt PRE-CREATION ./bin/zkCleanup.sh 1148587 ./bin/zkCli.sh 1148587 ./bin/zkEnv.sh 1148587 ./bin/zkServer.sh 1148587 ./build.xml 1148587 ./ivy.xml 1148587 ./src/contrib/build-contrib.xml 1148587 ./src/contrib/build.xml 1148587 ./src/contrib/zkpython/build.xml 1148587 ./src/contrib/zkpython/ivy.xml PRE-CREATION ./src/contrib/zkpython/src/packages/deb/zkpython.control/control PRE-CREATION ./src/contrib/zkpython/src/packages/rpm/spec/zkpython.spec PRE-CREATION ./src/contrib/zkpython/src/python/setup.py 1148587 ./src/packages/deb/init.d/zookeeper PRE-CREATION ./src/packages/deb/zookeeper.control/conffile PRE-CREATION ./src/packages/deb/zookeeper.control/control PRE-CREATION ./src/packages/deb/zookeeper.control/postinst PRE-CREATION ./src/packages/deb/zookeeper.control/postrm PRE-CREATION ./src/packages/deb/zookeeper.control/preinst PRE-CREATION ./src/packages/deb/zookeeper.control/prerm PRE-CREATION ./src/packages/rpm/init.d/zookeeper PRE-CREATION ./src/packages/rpm/spec/zookeeper.spec PRE-CREATION ./src/packages/templates/conf/zookeeper-env.sh PRE-CREATION ./src/packages/update-zookeeper-env.sh PRE-CREATION ./src/recipes/build-recipes.xml 1148587 ./src/recipes/build.xml 1148587 ./src/recipes/lock/build.xml 1148587 ./src/recipes/queue/build.xml 1148587 Diff: https://reviews.apache.org/r/1143/diff Testing ------- Thanks, Patrick
          Hide
          Patrick Hunt added a comment -

          See my updated review - issues installing/using the package under ubuntu.

          Show
          Patrick Hunt added a comment - See my updated review - issues installing/using the package under ubuntu.
          Hide
          jiraposter@reviews.apache.org added a comment -

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/1143/#review1169
          -----------------------------------------------------------

          The packaging code itself looks pretty good now. I've moved on to verifying the installation, however I see issues installing the deb on a clean ubuntu 10.10. Can you try generating the packages, install them and work through these? (ie test on ubuntu and rhel/centos).

          1) the following during install:

          Setting up zookeeper (3.4.0) ...
          ln: creating symbolic link `/usr/etc/zookeeper': No such file or directory

          2) I'm unable to start the server, seems like number of issues: a) why /usr/sbin/../etc/zookeeper for config, should just be /etc/zookeeper no? b) permission issues, notice I am running this as sudo.

          sudo /etc/init.d/zookeeper start

          • Starting Apache ZooKeeper server zookeeper JMX enabled by default
            Using config: /usr/sbin/../etc/zookeeper/zoo.cfg
            grep: /usr/sbin/../etc/zookeeper/zoo.cfg: No such file or directory
            mkdir: cannot create directory `': No such file or directory
            Starting zookeeper ... /usr/bin/../sbin/zkServer.sh: line 109: /zookeeper_server.pid: Permission denied
            FAILED TO WRITE PID
            /usr/bin/../sbin/zkServer.sh: line 105: ./zookeeper.out: Permission denied
            [fail]

          ./src/packages/deb/zookeeper.control/control
          <https://reviews.apache.org/r/1143/#comment2429>

          should we depend on either the jre or the jdk?

          ./README_packaging.txt
          <https://reviews.apache.org/r/1143/#comment2435>

          Nice!

          Would be nice to add - when I build where are the generated deb/rpm files placed?

          Are there any requirements for building? (I don't think so, but I'm not sure)

          ./README_packaging.txt
          <https://reviews.apache.org/r/1143/#comment2437>

          It's great to document the source layout, could we also provide some detail on where things are placed on the install machine? (high level is fine).

          ./src/contrib/zkpython/src/packages/deb/zkpython.control/control
          <https://reviews.apache.org/r/1143/#comment2431>

          missing license - is there a way to add comments here or no?

          ./src/packages/deb/zookeeper.control/conffile
          <https://reviews.apache.org/r/1143/#comment2432>

          license?

          ./src/packages/templates/conf/zookeeper-env.sh
          <https://reviews.apache.org/r/1143/#comment2433>

          need license header here.

          • Patrick

          On 2011-07-22 18:24:20, Patrick Hunt wrote:

          -----------------------------------------------------------

          This is an automatically generated e-mail. To reply, visit:

          https://reviews.apache.org/r/1143/

          -----------------------------------------------------------

          (Updated 2011-07-22 18:24:20)

          Review request for zookeeper and Mahadev Konar.

          Summary

          -------

          This goal of this ticket is to generate a set of RPM/debian package which integrate well with RPM sets created by HADOOP-6255.

          This addresses bug ZOOKEEPER-999.

          https://issues.apache.org/jira/browse/ZOOKEEPER-999

          Diffs

          -----

          ./README_packaging.txt PRE-CREATION

          ./bin/zkCleanup.sh 1148587

          ./bin/zkCli.sh 1148587

          ./bin/zkEnv.sh 1148587

          ./bin/zkServer.sh 1148587

          ./build.xml 1148587

          ./ivy.xml 1148587

          ./src/contrib/build-contrib.xml 1148587

          ./src/contrib/build.xml 1148587

          ./src/contrib/zkpython/build.xml 1148587

          ./src/contrib/zkpython/ivy.xml PRE-CREATION

          ./src/contrib/zkpython/src/packages/deb/zkpython.control/control PRE-CREATION

          ./src/contrib/zkpython/src/packages/rpm/spec/zkpython.spec PRE-CREATION

          ./src/contrib/zkpython/src/python/setup.py 1148587

          ./src/packages/deb/init.d/zookeeper PRE-CREATION

          ./src/packages/deb/zookeeper.control/conffile PRE-CREATION

          ./src/packages/deb/zookeeper.control/control PRE-CREATION

          ./src/packages/deb/zookeeper.control/postinst PRE-CREATION

          ./src/packages/deb/zookeeper.control/postrm PRE-CREATION

          ./src/packages/deb/zookeeper.control/preinst PRE-CREATION

          ./src/packages/deb/zookeeper.control/prerm PRE-CREATION

          ./src/packages/rpm/init.d/zookeeper PRE-CREATION

          ./src/packages/rpm/spec/zookeeper.spec PRE-CREATION

          ./src/packages/templates/conf/zookeeper-env.sh PRE-CREATION

          ./src/packages/update-zookeeper-env.sh PRE-CREATION

          ./src/recipes/build-recipes.xml 1148587

          ./src/recipes/build.xml 1148587

          ./src/recipes/lock/build.xml 1148587

          ./src/recipes/queue/build.xml 1148587

          Diff: https://reviews.apache.org/r/1143/diff

          Testing

          -------

          Thanks,

          Patrick

          Show
          jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1143/#review1169 ----------------------------------------------------------- The packaging code itself looks pretty good now. I've moved on to verifying the installation, however I see issues installing the deb on a clean ubuntu 10.10. Can you try generating the packages, install them and work through these? (ie test on ubuntu and rhel/centos). 1) the following during install: Setting up zookeeper (3.4.0) ... ln: creating symbolic link `/usr/etc/zookeeper': No such file or directory 2) I'm unable to start the server, seems like number of issues: a) why /usr/sbin/../etc/zookeeper for config, should just be /etc/zookeeper no? b) permission issues, notice I am running this as sudo. sudo /etc/init.d/zookeeper start Starting Apache ZooKeeper server zookeeper JMX enabled by default Using config: /usr/sbin/../etc/zookeeper/zoo.cfg grep: /usr/sbin/../etc/zookeeper/zoo.cfg: No such file or directory mkdir: cannot create directory `': No such file or directory Starting zookeeper ... /usr/bin/../sbin/zkServer.sh: line 109: /zookeeper_server.pid: Permission denied FAILED TO WRITE PID /usr/bin/../sbin/zkServer.sh: line 105: ./zookeeper.out: Permission denied [fail] ./src/packages/deb/zookeeper.control/control < https://reviews.apache.org/r/1143/#comment2429 > should we depend on either the jre or the jdk? ./README_packaging.txt < https://reviews.apache.org/r/1143/#comment2435 > Nice! Would be nice to add - when I build where are the generated deb/rpm files placed? Are there any requirements for building? (I don't think so, but I'm not sure) ./README_packaging.txt < https://reviews.apache.org/r/1143/#comment2437 > It's great to document the source layout, could we also provide some detail on where things are placed on the install machine? (high level is fine). ./src/contrib/zkpython/src/packages/deb/zkpython.control/control < https://reviews.apache.org/r/1143/#comment2431 > missing license - is there a way to add comments here or no? ./src/packages/deb/zookeeper.control/conffile < https://reviews.apache.org/r/1143/#comment2432 > license? ./src/packages/templates/conf/zookeeper-env.sh < https://reviews.apache.org/r/1143/#comment2433 > need license header here. Patrick On 2011-07-22 18:24:20, Patrick Hunt wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1143/ ----------------------------------------------------------- (Updated 2011-07-22 18:24:20) Review request for zookeeper and Mahadev Konar. Summary ------- This goal of this ticket is to generate a set of RPM/debian package which integrate well with RPM sets created by HADOOP-6255 . This addresses bug ZOOKEEPER-999 . https://issues.apache.org/jira/browse/ZOOKEEPER-999 Diffs ----- ./README_packaging.txt PRE-CREATION ./bin/zkCleanup.sh 1148587 ./bin/zkCli.sh 1148587 ./bin/zkEnv.sh 1148587 ./bin/zkServer.sh 1148587 ./build.xml 1148587 ./ivy.xml 1148587 ./src/contrib/build-contrib.xml 1148587 ./src/contrib/build.xml 1148587 ./src/contrib/zkpython/build.xml 1148587 ./src/contrib/zkpython/ivy.xml PRE-CREATION ./src/contrib/zkpython/src/packages/deb/zkpython.control/control PRE-CREATION ./src/contrib/zkpython/src/packages/rpm/spec/zkpython.spec PRE-CREATION ./src/contrib/zkpython/src/python/setup.py 1148587 ./src/packages/deb/init.d/zookeeper PRE-CREATION ./src/packages/deb/zookeeper.control/conffile PRE-CREATION ./src/packages/deb/zookeeper.control/control PRE-CREATION ./src/packages/deb/zookeeper.control/postinst PRE-CREATION ./src/packages/deb/zookeeper.control/postrm PRE-CREATION ./src/packages/deb/zookeeper.control/preinst PRE-CREATION ./src/packages/deb/zookeeper.control/prerm PRE-CREATION ./src/packages/rpm/init.d/zookeeper PRE-CREATION ./src/packages/rpm/spec/zookeeper.spec PRE-CREATION ./src/packages/templates/conf/zookeeper-env.sh PRE-CREATION ./src/packages/update-zookeeper-env.sh PRE-CREATION ./src/recipes/build-recipes.xml 1148587 ./src/recipes/build.xml 1148587 ./src/recipes/lock/build.xml 1148587 ./src/recipes/queue/build.xml 1148587 Diff: https://reviews.apache.org/r/1143/diff Testing ------- Thanks, Patrick
          Hide
          jiraposter@reviews.apache.org added a comment -

          On 2011-07-22 18:50:04, Patrick Hunt wrote:

          > The packaging code itself looks pretty good now. I've moved on to verifying the installation, however I see issues installing the deb on a clean ubuntu 10.10. Can you try generating the packages, install them and work through these? (ie test on ubuntu and rhel/centos).

          >

          > 1) the following during install:

          >

          > Setting up zookeeper (3.4.0) ...

          > ln: creating symbolic link `/usr/etc/zookeeper': No such file or directory

          >

          > 2) I'm unable to start the server, seems like number of issues: a) why /usr/sbin/../etc/zookeeper for config, should just be /etc/zookeeper no? b) permission issues, notice I am running this as sudo.

          >

          > sudo /etc/init.d/zookeeper start

          > * Starting Apache ZooKeeper server zookeeper JMX enabled by default

          > Using config: /usr/sbin/../etc/zookeeper/zoo.cfg

          > grep: /usr/sbin/../etc/zookeeper/zoo.cfg: No such file or directory

          > mkdir: cannot create directory `': No such file or directory

          > Starting zookeeper ... /usr/bin/../sbin/zkServer.sh: line 109: /zookeeper_server.pid: Permission denied

          > FAILED TO WRITE PID

          > /usr/bin/../sbin/zkServer.sh: line 105: ./zookeeper.out: Permission denied

          > [fail]

          >

          1,2) My mistake, it should make /usr/etc and symlink /usr/etc/zookeeper to /etc/zookeeper. On my test machines (RHEL, Ubuntu), I have Hadoop installed, which was making /usr/etc. That was why it worked only on my machine. I will correct this mistake.

          On 2011-07-22 18:50:04, Patrick Hunt wrote:

          > ./src/packages/deb/zookeeper.control/control, line 6

          > <https://reviews.apache.org/r/1143/diff/3-4/?file=26615#file26615line6>

          >

          > should we depend on either the jre or the jdk?

          I have no problem using ZooKeeper with only JRE installed.

          On 2011-07-22 18:50:04, Patrick Hunt wrote:

          > ./README_packaging.txt, line 1

          > <https://reviews.apache.org/r/1143/diff/4/?file=26874#file26874line1>

          >

          > Nice!

          >

          > Would be nice to add - when I build where are the generated deb/rpm files placed?

          >

          > Are there any requirements for building? (I don't think so, but I'm not sure)

          cppunit, and python-setuptools are required. Will include those in README_packaging.txt.

          On 2011-07-22 18:50:04, Patrick Hunt wrote:

          > ./src/contrib/zkpython/src/packages/deb/zkpython.control/control, line 1

          > <https://reviews.apache.org/r/1143/diff/4/?file=26885#file26885line1>

          >

          > missing license - is there a way to add comments here or no?

          Will do.

          On 2011-07-22 18:50:04, Patrick Hunt wrote:

          > ./src/packages/deb/zookeeper.control/conffile, line 1

          > <https://reviews.apache.org/r/1143/diff/4/?file=26889#file26889line1>

          >

          > license?

          Will do.

          On 2011-07-22 18:50:04, Patrick Hunt wrote:

          > ./src/packages/templates/conf/zookeeper-env.sh, line 1

          > <https://reviews.apache.org/r/1143/diff/4/?file=26897#file26897line1>

          >

          > need license header here.

          Will do.

          On 2011-07-22 18:50:04, Patrick Hunt wrote:

          > ./README_packaging.txt, line 9

          > <https://reviews.apache.org/r/1143/diff/4/?file=26874#file26874line9>

          >

          > It's great to document the source layout, could we also provide some detail on where things are placed on the install machine? (high level is fine).

          Included in the README_packaging.txt.

          • Eric

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/1143/#review1169
          -----------------------------------------------------------

          On 2011-07-22 18:24:20, Patrick Hunt wrote:

          -----------------------------------------------------------

          This is an automatically generated e-mail. To reply, visit:

          https://reviews.apache.org/r/1143/

          -----------------------------------------------------------

          (Updated 2011-07-22 18:24:20)

          Review request for zookeeper and Mahadev Konar.

          Summary

          -------

          This goal of this ticket is to generate a set of RPM/debian package which integrate well with RPM sets created by HADOOP-6255.

          This addresses bug ZOOKEEPER-999.

          https://issues.apache.org/jira/browse/ZOOKEEPER-999

          Diffs

          -----

          ./README_packaging.txt PRE-CREATION

          ./bin/zkCleanup.sh 1148587

          ./bin/zkCli.sh 1148587

          ./bin/zkEnv.sh 1148587

          ./bin/zkServer.sh 1148587

          ./build.xml 1148587

          ./ivy.xml 1148587

          ./src/contrib/build-contrib.xml 1148587

          ./src/contrib/build.xml 1148587

          ./src/contrib/zkpython/build.xml 1148587

          ./src/contrib/zkpython/ivy.xml PRE-CREATION

          ./src/contrib/zkpython/src/packages/deb/zkpython.control/control PRE-CREATION

          ./src/contrib/zkpython/src/packages/rpm/spec/zkpython.spec PRE-CREATION

          ./src/contrib/zkpython/src/python/setup.py 1148587

          ./src/packages/deb/init.d/zookeeper PRE-CREATION

          ./src/packages/deb/zookeeper.control/conffile PRE-CREATION

          ./src/packages/deb/zookeeper.control/control PRE-CREATION

          ./src/packages/deb/zookeeper.control/postinst PRE-CREATION

          ./src/packages/deb/zookeeper.control/postrm PRE-CREATION

          ./src/packages/deb/zookeeper.control/preinst PRE-CREATION

          ./src/packages/deb/zookeeper.control/prerm PRE-CREATION

          ./src/packages/rpm/init.d/zookeeper PRE-CREATION

          ./src/packages/rpm/spec/zookeeper.spec PRE-CREATION

          ./src/packages/templates/conf/zookeeper-env.sh PRE-CREATION

          ./src/packages/update-zookeeper-env.sh PRE-CREATION

          ./src/recipes/build-recipes.xml 1148587

          ./src/recipes/build.xml 1148587

          ./src/recipes/lock/build.xml 1148587

          ./src/recipes/queue/build.xml 1148587

          Diff: https://reviews.apache.org/r/1143/diff

          Testing

          -------

          Thanks,

          Patrick

          Show
          jiraposter@reviews.apache.org added a comment - On 2011-07-22 18:50:04, Patrick Hunt wrote: > The packaging code itself looks pretty good now. I've moved on to verifying the installation, however I see issues installing the deb on a clean ubuntu 10.10. Can you try generating the packages, install them and work through these? (ie test on ubuntu and rhel/centos). > > 1) the following during install: > > Setting up zookeeper (3.4.0) ... > ln: creating symbolic link `/usr/etc/zookeeper': No such file or directory > > 2) I'm unable to start the server, seems like number of issues: a) why /usr/sbin/../etc/zookeeper for config, should just be /etc/zookeeper no? b) permission issues, notice I am running this as sudo. > > sudo /etc/init.d/zookeeper start > * Starting Apache ZooKeeper server zookeeper JMX enabled by default > Using config: /usr/sbin/../etc/zookeeper/zoo.cfg > grep: /usr/sbin/../etc/zookeeper/zoo.cfg: No such file or directory > mkdir: cannot create directory `': No such file or directory > Starting zookeeper ... /usr/bin/../sbin/zkServer.sh: line 109: /zookeeper_server.pid: Permission denied > FAILED TO WRITE PID > /usr/bin/../sbin/zkServer.sh: line 105: ./zookeeper.out: Permission denied > [fail] > 1,2) My mistake, it should make /usr/etc and symlink /usr/etc/zookeeper to /etc/zookeeper. On my test machines (RHEL, Ubuntu), I have Hadoop installed, which was making /usr/etc. That was why it worked only on my machine. I will correct this mistake. On 2011-07-22 18:50:04, Patrick Hunt wrote: > ./src/packages/deb/zookeeper.control/control, line 6 > < https://reviews.apache.org/r/1143/diff/3-4/?file=26615#file26615line6 > > > should we depend on either the jre or the jdk? I have no problem using ZooKeeper with only JRE installed. On 2011-07-22 18:50:04, Patrick Hunt wrote: > ./README_packaging.txt, line 1 > < https://reviews.apache.org/r/1143/diff/4/?file=26874#file26874line1 > > > Nice! > > Would be nice to add - when I build where are the generated deb/rpm files placed? > > Are there any requirements for building? (I don't think so, but I'm not sure) cppunit, and python-setuptools are required. Will include those in README_packaging.txt. On 2011-07-22 18:50:04, Patrick Hunt wrote: > ./src/contrib/zkpython/src/packages/deb/zkpython.control/control, line 1 > < https://reviews.apache.org/r/1143/diff/4/?file=26885#file26885line1 > > > missing license - is there a way to add comments here or no? Will do. On 2011-07-22 18:50:04, Patrick Hunt wrote: > ./src/packages/deb/zookeeper.control/conffile, line 1 > < https://reviews.apache.org/r/1143/diff/4/?file=26889#file26889line1 > > > license? Will do. On 2011-07-22 18:50:04, Patrick Hunt wrote: > ./src/packages/templates/conf/zookeeper-env.sh, line 1 > < https://reviews.apache.org/r/1143/diff/4/?file=26897#file26897line1 > > > need license header here. Will do. On 2011-07-22 18:50:04, Patrick Hunt wrote: > ./README_packaging.txt, line 9 > < https://reviews.apache.org/r/1143/diff/4/?file=26874#file26874line9 > > > It's great to document the source layout, could we also provide some detail on where things are placed on the install machine? (high level is fine). Included in the README_packaging.txt. Eric ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1143/#review1169 ----------------------------------------------------------- On 2011-07-22 18:24:20, Patrick Hunt wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1143/ ----------------------------------------------------------- (Updated 2011-07-22 18:24:20) Review request for zookeeper and Mahadev Konar. Summary ------- This goal of this ticket is to generate a set of RPM/debian package which integrate well with RPM sets created by HADOOP-6255 . This addresses bug ZOOKEEPER-999 . https://issues.apache.org/jira/browse/ZOOKEEPER-999 Diffs ----- ./README_packaging.txt PRE-CREATION ./bin/zkCleanup.sh 1148587 ./bin/zkCli.sh 1148587 ./bin/zkEnv.sh 1148587 ./bin/zkServer.sh 1148587 ./build.xml 1148587 ./ivy.xml 1148587 ./src/contrib/build-contrib.xml 1148587 ./src/contrib/build.xml 1148587 ./src/contrib/zkpython/build.xml 1148587 ./src/contrib/zkpython/ivy.xml PRE-CREATION ./src/contrib/zkpython/src/packages/deb/zkpython.control/control PRE-CREATION ./src/contrib/zkpython/src/packages/rpm/spec/zkpython.spec PRE-CREATION ./src/contrib/zkpython/src/python/setup.py 1148587 ./src/packages/deb/init.d/zookeeper PRE-CREATION ./src/packages/deb/zookeeper.control/conffile PRE-CREATION ./src/packages/deb/zookeeper.control/control PRE-CREATION ./src/packages/deb/zookeeper.control/postinst PRE-CREATION ./src/packages/deb/zookeeper.control/postrm PRE-CREATION ./src/packages/deb/zookeeper.control/preinst PRE-CREATION ./src/packages/deb/zookeeper.control/prerm PRE-CREATION ./src/packages/rpm/init.d/zookeeper PRE-CREATION ./src/packages/rpm/spec/zookeeper.spec PRE-CREATION ./src/packages/templates/conf/zookeeper-env.sh PRE-CREATION ./src/packages/update-zookeeper-env.sh PRE-CREATION ./src/recipes/build-recipes.xml 1148587 ./src/recipes/build.xml 1148587 ./src/recipes/lock/build.xml 1148587 ./src/recipes/queue/build.xml 1148587 Diff: https://reviews.apache.org/r/1143/diff Testing ------- Thanks, Patrick
          Hide
          Eric Yang added a comment -
          • Updated license.
          • Updated document for install file layout.
          • Ensure /usr/etc/zookeeper made correctly.
          Show
          Eric Yang added a comment - Updated license. Updated document for install file layout. Ensure /usr/etc/zookeeper made correctly.
          Hide
          jiraposter@reviews.apache.org added a comment -

          On 2011-07-22 18:50:04, Patrick Hunt wrote:

          > The packaging code itself looks pretty good now. I've moved on to verifying the installation, however I see issues installing the deb on a clean ubuntu 10.10. Can you try generating the packages, install them and work through these? (ie test on ubuntu and rhel/centos).

          >

          > 1) the following during install:

          >

          > Setting up zookeeper (3.4.0) ...

          > ln: creating symbolic link `/usr/etc/zookeeper': No such file or directory

          >

          > 2) I'm unable to start the server, seems like number of issues: a) why /usr/sbin/../etc/zookeeper for config, should just be /etc/zookeeper no? b) permission issues, notice I am running this as sudo.

          >

          > sudo /etc/init.d/zookeeper start

          > * Starting Apache ZooKeeper server zookeeper JMX enabled by default

          > Using config: /usr/sbin/../etc/zookeeper/zoo.cfg

          > grep: /usr/sbin/../etc/zookeeper/zoo.cfg: No such file or directory

          > mkdir: cannot create directory `': No such file or directory

          > Starting zookeeper ... /usr/bin/../sbin/zkServer.sh: line 109: /zookeeper_server.pid: Permission denied

          > FAILED TO WRITE PID

          > /usr/bin/../sbin/zkServer.sh: line 105: ./zookeeper.out: Permission denied

          > [fail]

          >

          Eric Yang wrote:

          1,2) My mistake, it should make /usr/etc and symlink /usr/etc/zookeeper to /etc/zookeeper. On my test machines (RHEL, Ubuntu), I have Hadoop installed, which was making /usr/etc. That was why it worked only on my machine. I will correct this mistake.

          you might also want to specify the zk conf directory so that it shows up as /etc/zookeeper/zoo.cfg on the cmdline. (no worries)

          On 2011-07-22 18:50:04, Patrick Hunt wrote:

          > ./src/packages/deb/zookeeper.control/control, line 6

          > <https://reviews.apache.org/r/1143/diff/3-4/?file=26615#file26615line6>

          >

          > should we depend on either the jre or the jdk?

          Eric Yang wrote:

          I have no problem using ZooKeeper with only JRE installed.

          yes, that's fine, my point is that someone else may only have the jdk installed, shouldn't they be able to run w/o installing jre (on ubuntu at least there is no dependency btw jre/jdk afaict).

          On 2011-07-22 18:50:04, Patrick Hunt wrote:

          > ./README_packaging.txt, line 1

          > <https://reviews.apache.org/r/1143/diff/4/?file=26874#file26874line1>

          >

          > Nice!

          >

          > Would be nice to add - when I build where are the generated deb/rpm files placed?

          >

          > Are there any requirements for building? (I don't think so, but I'm not sure)

          Eric Yang wrote:

          cppunit, and python-setuptools are required. Will include those in README_packaging.txt.

          well those are required to build zk itself. you probably shouldn't add that, I was just thinking if anything pkging related was required.

          • Patrick

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/1143/#review1169
          -----------------------------------------------------------

          On 2011-07-22 18:24:20, Patrick Hunt wrote:

          -----------------------------------------------------------

          This is an automatically generated e-mail. To reply, visit:

          https://reviews.apache.org/r/1143/

          -----------------------------------------------------------

          (Updated 2011-07-22 18:24:20)

          Review request for zookeeper and Mahadev Konar.

          Summary

          -------

          This goal of this ticket is to generate a set of RPM/debian package which integrate well with RPM sets created by HADOOP-6255.

          This addresses bug ZOOKEEPER-999.

          https://issues.apache.org/jira/browse/ZOOKEEPER-999

          Diffs

          -----

          ./README_packaging.txt PRE-CREATION

          ./bin/zkCleanup.sh 1148587

          ./bin/zkCli.sh 1148587

          ./bin/zkEnv.sh 1148587

          ./bin/zkServer.sh 1148587

          ./build.xml 1148587

          ./ivy.xml 1148587

          ./src/contrib/build-contrib.xml 1148587

          ./src/contrib/build.xml 1148587

          ./src/contrib/zkpython/build.xml 1148587

          ./src/contrib/zkpython/ivy.xml PRE-CREATION

          ./src/contrib/zkpython/src/packages/deb/zkpython.control/control PRE-CREATION

          ./src/contrib/zkpython/src/packages/rpm/spec/zkpython.spec PRE-CREATION

          ./src/contrib/zkpython/src/python/setup.py 1148587

          ./src/packages/deb/init.d/zookeeper PRE-CREATION

          ./src/packages/deb/zookeeper.control/conffile PRE-CREATION

          ./src/packages/deb/zookeeper.control/control PRE-CREATION

          ./src/packages/deb/zookeeper.control/postinst PRE-CREATION

          ./src/packages/deb/zookeeper.control/postrm PRE-CREATION

          ./src/packages/deb/zookeeper.control/preinst PRE-CREATION

          ./src/packages/deb/zookeeper.control/prerm PRE-CREATION

          ./src/packages/rpm/init.d/zookeeper PRE-CREATION

          ./src/packages/rpm/spec/zookeeper.spec PRE-CREATION

          ./src/packages/templates/conf/zookeeper-env.sh PRE-CREATION

          ./src/packages/update-zookeeper-env.sh PRE-CREATION

          ./src/recipes/build-recipes.xml 1148587

          ./src/recipes/build.xml 1148587

          ./src/recipes/lock/build.xml 1148587

          ./src/recipes/queue/build.xml 1148587

          Diff: https://reviews.apache.org/r/1143/diff

          Testing

          -------

          Thanks,

          Patrick

          Show
          jiraposter@reviews.apache.org added a comment - On 2011-07-22 18:50:04, Patrick Hunt wrote: > The packaging code itself looks pretty good now. I've moved on to verifying the installation, however I see issues installing the deb on a clean ubuntu 10.10. Can you try generating the packages, install them and work through these? (ie test on ubuntu and rhel/centos). > > 1) the following during install: > > Setting up zookeeper (3.4.0) ... > ln: creating symbolic link `/usr/etc/zookeeper': No such file or directory > > 2) I'm unable to start the server, seems like number of issues: a) why /usr/sbin/../etc/zookeeper for config, should just be /etc/zookeeper no? b) permission issues, notice I am running this as sudo. > > sudo /etc/init.d/zookeeper start > * Starting Apache ZooKeeper server zookeeper JMX enabled by default > Using config: /usr/sbin/../etc/zookeeper/zoo.cfg > grep: /usr/sbin/../etc/zookeeper/zoo.cfg: No such file or directory > mkdir: cannot create directory `': No such file or directory > Starting zookeeper ... /usr/bin/../sbin/zkServer.sh: line 109: /zookeeper_server.pid: Permission denied > FAILED TO WRITE PID > /usr/bin/../sbin/zkServer.sh: line 105: ./zookeeper.out: Permission denied > [fail] > Eric Yang wrote: 1,2) My mistake, it should make /usr/etc and symlink /usr/etc/zookeeper to /etc/zookeeper. On my test machines (RHEL, Ubuntu), I have Hadoop installed, which was making /usr/etc. That was why it worked only on my machine. I will correct this mistake. you might also want to specify the zk conf directory so that it shows up as /etc/zookeeper/zoo.cfg on the cmdline. (no worries) On 2011-07-22 18:50:04, Patrick Hunt wrote: > ./src/packages/deb/zookeeper.control/control, line 6 > < https://reviews.apache.org/r/1143/diff/3-4/?file=26615#file26615line6 > > > should we depend on either the jre or the jdk? Eric Yang wrote: I have no problem using ZooKeeper with only JRE installed. yes, that's fine, my point is that someone else may only have the jdk installed, shouldn't they be able to run w/o installing jre (on ubuntu at least there is no dependency btw jre/jdk afaict). On 2011-07-22 18:50:04, Patrick Hunt wrote: > ./README_packaging.txt, line 1 > < https://reviews.apache.org/r/1143/diff/4/?file=26874#file26874line1 > > > Nice! > > Would be nice to add - when I build where are the generated deb/rpm files placed? > > Are there any requirements for building? (I don't think so, but I'm not sure) Eric Yang wrote: cppunit, and python-setuptools are required. Will include those in README_packaging.txt. well those are required to build zk itself. you probably shouldn't add that, I was just thinking if anything pkging related was required. Patrick ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1143/#review1169 ----------------------------------------------------------- On 2011-07-22 18:24:20, Patrick Hunt wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1143/ ----------------------------------------------------------- (Updated 2011-07-22 18:24:20) Review request for zookeeper and Mahadev Konar. Summary ------- This goal of this ticket is to generate a set of RPM/debian package which integrate well with RPM sets created by HADOOP-6255 . This addresses bug ZOOKEEPER-999 . https://issues.apache.org/jira/browse/ZOOKEEPER-999 Diffs ----- ./README_packaging.txt PRE-CREATION ./bin/zkCleanup.sh 1148587 ./bin/zkCli.sh 1148587 ./bin/zkEnv.sh 1148587 ./bin/zkServer.sh 1148587 ./build.xml 1148587 ./ivy.xml 1148587 ./src/contrib/build-contrib.xml 1148587 ./src/contrib/build.xml 1148587 ./src/contrib/zkpython/build.xml 1148587 ./src/contrib/zkpython/ivy.xml PRE-CREATION ./src/contrib/zkpython/src/packages/deb/zkpython.control/control PRE-CREATION ./src/contrib/zkpython/src/packages/rpm/spec/zkpython.spec PRE-CREATION ./src/contrib/zkpython/src/python/setup.py 1148587 ./src/packages/deb/init.d/zookeeper PRE-CREATION ./src/packages/deb/zookeeper.control/conffile PRE-CREATION ./src/packages/deb/zookeeper.control/control PRE-CREATION ./src/packages/deb/zookeeper.control/postinst PRE-CREATION ./src/packages/deb/zookeeper.control/postrm PRE-CREATION ./src/packages/deb/zookeeper.control/preinst PRE-CREATION ./src/packages/deb/zookeeper.control/prerm PRE-CREATION ./src/packages/rpm/init.d/zookeeper PRE-CREATION ./src/packages/rpm/spec/zookeeper.spec PRE-CREATION ./src/packages/templates/conf/zookeeper-env.sh PRE-CREATION ./src/packages/update-zookeeper-env.sh PRE-CREATION ./src/recipes/build-recipes.xml 1148587 ./src/recipes/build.xml 1148587 ./src/recipes/lock/build.xml 1148587 ./src/recipes/queue/build.xml 1148587 Diff: https://reviews.apache.org/r/1143/diff Testing ------- Thanks, Patrick
          Hide
          jiraposter@reviews.apache.org added a comment -

          On 2011-07-22 18:50:04, Patrick Hunt wrote:

          > ./src/contrib/zkpython/src/packages/deb/zkpython.control/control, line 1

          > <https://reviews.apache.org/r/1143/diff/4/?file=26885#file26885line1>

          >

          > missing license - is there a way to add comments here or no?

          Eric Yang wrote:

          Will do.

          I did, ZOOKEEPER-999-9.patch shows the license, but for some reason review board isn't picking up the additions.

          On 2011-07-22 18:50:04, Patrick Hunt wrote:

          > ./README_packaging.txt, line 1

          > <https://reviews.apache.org/r/1143/diff/4/?file=26874#file26874line1>

          >

          > Nice!

          >

          > Would be nice to add - when I build where are the generated deb/rpm files placed?

          >

          > Are there any requirements for building? (I don't think so, but I'm not sure)

          Eric Yang wrote:

          cppunit, and python-setuptools are required. Will include those in README_packaging.txt.

          Patrick Hunt wrote:

          well those are required to build zk itself. you probably shouldn't add that, I was just thinking if anything pkging related was required.

          For rpm, it will require RHEL or CentOS because it depends on rpmbuild. Debian build is base on java plugin, hence it can build on both RHEL or Ubuntu.

          On 2011-07-22 18:50:04, Patrick Hunt wrote:

          > ./src/packages/deb/zookeeper.control/control, line 6

          > <https://reviews.apache.org/r/1143/diff/3-4/?file=26615#file26615line6>

          >

          > should we depend on either the jre or the jdk?

          Eric Yang wrote:

          I have no problem using ZooKeeper with only JRE installed.

          Patrick Hunt wrote:

          yes, that's fine, my point is that someone else may only have the jdk installed, shouldn't they be able to run w/o installing jre (on ubuntu at least there is no dependency btw jre/jdk afaict).

          I just tested installing sun-java6-jdk without jre on Ubuntu 11.04. It doesn't let me install. I think the dependency is right.

          • Eric

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/1143/#review1169
          -----------------------------------------------------------

          On 2011-07-22 18:24:20, Patrick Hunt wrote:

          -----------------------------------------------------------

          This is an automatically generated e-mail. To reply, visit:

          https://reviews.apache.org/r/1143/

          -----------------------------------------------------------

          (Updated 2011-07-22 18:24:20)

          Review request for zookeeper and Mahadev Konar.

          Summary

          -------

          This goal of this ticket is to generate a set of RPM/debian package which integrate well with RPM sets created by HADOOP-6255.

          This addresses bug ZOOKEEPER-999.

          https://issues.apache.org/jira/browse/ZOOKEEPER-999

          Diffs

          -----

          ./README_packaging.txt PRE-CREATION

          ./bin/zkCleanup.sh 1148587

          ./bin/zkCli.sh 1148587

          ./bin/zkEnv.sh 1148587

          ./bin/zkServer.sh 1148587

          ./build.xml 1148587

          ./ivy.xml 1148587

          ./src/contrib/build-contrib.xml 1148587

          ./src/contrib/build.xml 1148587

          ./src/contrib/zkpython/build.xml 1148587

          ./src/contrib/zkpython/ivy.xml PRE-CREATION

          ./src/contrib/zkpython/src/packages/deb/zkpython.control/control PRE-CREATION

          ./src/contrib/zkpython/src/packages/rpm/spec/zkpython.spec PRE-CREATION

          ./src/contrib/zkpython/src/python/setup.py 1148587

          ./src/packages/deb/init.d/zookeeper PRE-CREATION

          ./src/packages/deb/zookeeper.control/conffile PRE-CREATION

          ./src/packages/deb/zookeeper.control/control PRE-CREATION

          ./src/packages/deb/zookeeper.control/postinst PRE-CREATION

          ./src/packages/deb/zookeeper.control/postrm PRE-CREATION

          ./src/packages/deb/zookeeper.control/preinst PRE-CREATION

          ./src/packages/deb/zookeeper.control/prerm PRE-CREATION

          ./src/packages/rpm/init.d/zookeeper PRE-CREATION

          ./src/packages/rpm/spec/zookeeper.spec PRE-CREATION

          ./src/packages/templates/conf/zookeeper-env.sh PRE-CREATION

          ./src/packages/update-zookeeper-env.sh PRE-CREATION

          ./src/recipes/build-recipes.xml 1148587

          ./src/recipes/build.xml 1148587

          ./src/recipes/lock/build.xml 1148587

          ./src/recipes/queue/build.xml 1148587

          Diff: https://reviews.apache.org/r/1143/diff

          Testing

          -------

          Thanks,

          Patrick

          Show
          jiraposter@reviews.apache.org added a comment - On 2011-07-22 18:50:04, Patrick Hunt wrote: > ./src/contrib/zkpython/src/packages/deb/zkpython.control/control, line 1 > < https://reviews.apache.org/r/1143/diff/4/?file=26885#file26885line1 > > > missing license - is there a way to add comments here or no? Eric Yang wrote: Will do. I did, ZOOKEEPER-999 -9.patch shows the license, but for some reason review board isn't picking up the additions. On 2011-07-22 18:50:04, Patrick Hunt wrote: > ./README_packaging.txt, line 1 > < https://reviews.apache.org/r/1143/diff/4/?file=26874#file26874line1 > > > Nice! > > Would be nice to add - when I build where are the generated deb/rpm files placed? > > Are there any requirements for building? (I don't think so, but I'm not sure) Eric Yang wrote: cppunit, and python-setuptools are required. Will include those in README_packaging.txt. Patrick Hunt wrote: well those are required to build zk itself. you probably shouldn't add that, I was just thinking if anything pkging related was required. For rpm, it will require RHEL or CentOS because it depends on rpmbuild. Debian build is base on java plugin, hence it can build on both RHEL or Ubuntu. On 2011-07-22 18:50:04, Patrick Hunt wrote: > ./src/packages/deb/zookeeper.control/control, line 6 > < https://reviews.apache.org/r/1143/diff/3-4/?file=26615#file26615line6 > > > should we depend on either the jre or the jdk? Eric Yang wrote: I have no problem using ZooKeeper with only JRE installed. Patrick Hunt wrote: yes, that's fine, my point is that someone else may only have the jdk installed, shouldn't they be able to run w/o installing jre (on ubuntu at least there is no dependency btw jre/jdk afaict). I just tested installing sun-java6-jdk without jre on Ubuntu 11.04. It doesn't let me install. I think the dependency is right. Eric ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1143/#review1169 ----------------------------------------------------------- On 2011-07-22 18:24:20, Patrick Hunt wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1143/ ----------------------------------------------------------- (Updated 2011-07-22 18:24:20) Review request for zookeeper and Mahadev Konar. Summary ------- This goal of this ticket is to generate a set of RPM/debian package which integrate well with RPM sets created by HADOOP-6255 . This addresses bug ZOOKEEPER-999 . https://issues.apache.org/jira/browse/ZOOKEEPER-999 Diffs ----- ./README_packaging.txt PRE-CREATION ./bin/zkCleanup.sh 1148587 ./bin/zkCli.sh 1148587 ./bin/zkEnv.sh 1148587 ./bin/zkServer.sh 1148587 ./build.xml 1148587 ./ivy.xml 1148587 ./src/contrib/build-contrib.xml 1148587 ./src/contrib/build.xml 1148587 ./src/contrib/zkpython/build.xml 1148587 ./src/contrib/zkpython/ivy.xml PRE-CREATION ./src/contrib/zkpython/src/packages/deb/zkpython.control/control PRE-CREATION ./src/contrib/zkpython/src/packages/rpm/spec/zkpython.spec PRE-CREATION ./src/contrib/zkpython/src/python/setup.py 1148587 ./src/packages/deb/init.d/zookeeper PRE-CREATION ./src/packages/deb/zookeeper.control/conffile PRE-CREATION ./src/packages/deb/zookeeper.control/control PRE-CREATION ./src/packages/deb/zookeeper.control/postinst PRE-CREATION ./src/packages/deb/zookeeper.control/postrm PRE-CREATION ./src/packages/deb/zookeeper.control/preinst PRE-CREATION ./src/packages/deb/zookeeper.control/prerm PRE-CREATION ./src/packages/rpm/init.d/zookeeper PRE-CREATION ./src/packages/rpm/spec/zookeeper.spec PRE-CREATION ./src/packages/templates/conf/zookeeper-env.sh PRE-CREATION ./src/packages/update-zookeeper-env.sh PRE-CREATION ./src/recipes/build-recipes.xml 1148587 ./src/recipes/build.xml 1148587 ./src/recipes/lock/build.xml 1148587 ./src/recipes/queue/build.xml 1148587 Diff: https://reviews.apache.org/r/1143/diff Testing ------- Thanks, Patrick
          Hide
          jiraposter@reviews.apache.org added a comment -

          On 2011-07-21 06:02:33, Patrick Hunt wrote:

          > I ran "ant deb" successfully, although I have not yet tried to install it. I noticed a couple issues with the generated package.

          >

          > shouldn't /etc/zookeeper contain zoo.cfg?

          >

          > drwxr-xr-x 0/0 0 2011-07-20 22:41 ./etc/

          > drwxr-xr-x 0/0 0 2011-07-20 22:41 ./etc/zookeeper/

          > rw-rr- 0/0 535 2011-07-20 22:41 ./etc/zookeeper/configuration.xsl

          > rw-rr- 0/0 2161 2011-07-20 22:41 ./etc/zookeeper/log4j.properties

          > rw-rr- 0/0 447 2011-07-20 22:41 ./etc/zookeeper/zoo_sample.cfg

          >

          > shouldn't we be creating (if doesn't exist) the /var/lib/zookeeper directory? ZK does this currently, however I'm planning to file a bug for this - really we shouldn't come up if we can't find this directory (handles case of misconfiguration - we stop rather than start with an empty data hierarchy)

          >

          > Can you add some documentation? Nothing fancy, perhaps a README_packaging.txt at the toplevel that describes the currently supported packages, some basic information about them, how to build "ant deb" etc..., additional requirements to build, etc... something basic to help out someone trying to build the packages.

          The system should generate zoo.cfg, if it doesn't exist. It looks like a bug. I will look into it. I will add README_packaging.txt in the next patch. Same for sun jdk.

          • Eric

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/1143/#review1149
          -----------------------------------------------------------

          On 2011-07-22 18:24:20, Patrick Hunt wrote:

          -----------------------------------------------------------

          This is an automatically generated e-mail. To reply, visit:

          https://reviews.apache.org/r/1143/

          -----------------------------------------------------------

          (Updated 2011-07-22 18:24:20)

          Review request for zookeeper and Mahadev Konar.

          Summary

          -------

          This goal of this ticket is to generate a set of RPM/debian package which integrate well with RPM sets created by HADOOP-6255.

          This addresses bug ZOOKEEPER-999.

          https://issues.apache.org/jira/browse/ZOOKEEPER-999

          Diffs

          -----

          ./README_packaging.txt PRE-CREATION

          ./bin/zkCleanup.sh 1148587

          ./bin/zkCli.sh 1148587

          ./bin/zkEnv.sh 1148587

          ./bin/zkServer.sh 1148587

          ./build.xml 1148587

          ./ivy.xml 1148587

          ./src/contrib/build-contrib.xml 1148587

          ./src/contrib/build.xml 1148587

          ./src/contrib/zkpython/build.xml 1148587

          ./src/contrib/zkpython/ivy.xml PRE-CREATION

          ./src/contrib/zkpython/src/packages/deb/zkpython.control/control PRE-CREATION

          ./src/contrib/zkpython/src/packages/rpm/spec/zkpython.spec PRE-CREATION

          ./src/contrib/zkpython/src/python/setup.py 1148587

          ./src/packages/deb/init.d/zookeeper PRE-CREATION

          ./src/packages/deb/zookeeper.control/conffile PRE-CREATION

          ./src/packages/deb/zookeeper.control/control PRE-CREATION

          ./src/packages/deb/zookeeper.control/postinst PRE-CREATION

          ./src/packages/deb/zookeeper.control/postrm PRE-CREATION

          ./src/packages/deb/zookeeper.control/preinst PRE-CREATION

          ./src/packages/deb/zookeeper.control/prerm PRE-CREATION

          ./src/packages/rpm/init.d/zookeeper PRE-CREATION

          ./src/packages/rpm/spec/zookeeper.spec PRE-CREATION

          ./src/packages/templates/conf/zookeeper-env.sh PRE-CREATION

          ./src/packages/update-zookeeper-env.sh PRE-CREATION

          ./src/recipes/build-recipes.xml 1148587

          ./src/recipes/build.xml 1148587

          ./src/recipes/lock/build.xml 1148587

          ./src/recipes/queue/build.xml 1148587

          Diff: https://reviews.apache.org/r/1143/diff

          Testing

          -------

          Thanks,

          Patrick

          Show
          jiraposter@reviews.apache.org added a comment - On 2011-07-21 06:02:33, Patrick Hunt wrote: > I ran "ant deb" successfully, although I have not yet tried to install it. I noticed a couple issues with the generated package. > > shouldn't /etc/zookeeper contain zoo.cfg? > > drwxr-xr-x 0/0 0 2011-07-20 22:41 ./etc/ > drwxr-xr-x 0/0 0 2011-07-20 22:41 ./etc/zookeeper/ > rw-r r - 0/0 535 2011-07-20 22:41 ./etc/zookeeper/configuration.xsl > rw-r r - 0/0 2161 2011-07-20 22:41 ./etc/zookeeper/log4j.properties > rw-r r - 0/0 447 2011-07-20 22:41 ./etc/zookeeper/zoo_sample.cfg > > shouldn't we be creating (if doesn't exist) the /var/lib/zookeeper directory? ZK does this currently, however I'm planning to file a bug for this - really we shouldn't come up if we can't find this directory (handles case of misconfiguration - we stop rather than start with an empty data hierarchy) > > Can you add some documentation? Nothing fancy, perhaps a README_packaging.txt at the toplevel that describes the currently supported packages, some basic information about them, how to build "ant deb" etc..., additional requirements to build, etc... something basic to help out someone trying to build the packages. The system should generate zoo.cfg, if it doesn't exist. It looks like a bug. I will look into it. I will add README_packaging.txt in the next patch. Same for sun jdk. Eric ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1143/#review1149 ----------------------------------------------------------- On 2011-07-22 18:24:20, Patrick Hunt wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1143/ ----------------------------------------------------------- (Updated 2011-07-22 18:24:20) Review request for zookeeper and Mahadev Konar. Summary ------- This goal of this ticket is to generate a set of RPM/debian package which integrate well with RPM sets created by HADOOP-6255 . This addresses bug ZOOKEEPER-999 . https://issues.apache.org/jira/browse/ZOOKEEPER-999 Diffs ----- ./README_packaging.txt PRE-CREATION ./bin/zkCleanup.sh 1148587 ./bin/zkCli.sh 1148587 ./bin/zkEnv.sh 1148587 ./bin/zkServer.sh 1148587 ./build.xml 1148587 ./ivy.xml 1148587 ./src/contrib/build-contrib.xml 1148587 ./src/contrib/build.xml 1148587 ./src/contrib/zkpython/build.xml 1148587 ./src/contrib/zkpython/ivy.xml PRE-CREATION ./src/contrib/zkpython/src/packages/deb/zkpython.control/control PRE-CREATION ./src/contrib/zkpython/src/packages/rpm/spec/zkpython.spec PRE-CREATION ./src/contrib/zkpython/src/python/setup.py 1148587 ./src/packages/deb/init.d/zookeeper PRE-CREATION ./src/packages/deb/zookeeper.control/conffile PRE-CREATION ./src/packages/deb/zookeeper.control/control PRE-CREATION ./src/packages/deb/zookeeper.control/postinst PRE-CREATION ./src/packages/deb/zookeeper.control/postrm PRE-CREATION ./src/packages/deb/zookeeper.control/preinst PRE-CREATION ./src/packages/deb/zookeeper.control/prerm PRE-CREATION ./src/packages/rpm/init.d/zookeeper PRE-CREATION ./src/packages/rpm/spec/zookeeper.spec PRE-CREATION ./src/packages/templates/conf/zookeeper-env.sh PRE-CREATION ./src/packages/update-zookeeper-env.sh PRE-CREATION ./src/recipes/build-recipes.xml 1148587 ./src/recipes/build.xml 1148587 ./src/recipes/lock/build.xml 1148587 ./src/recipes/queue/build.xml 1148587 Diff: https://reviews.apache.org/r/1143/diff Testing ------- Thanks, Patrick
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12487479/ZOOKEEPER-999-9.patch
          against trunk revision 1150937.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 12 new or modified tests.

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/411//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12487479/ZOOKEEPER-999-9.patch against trunk revision 1150937. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 12 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/411//console This message is automatically generated.
          Hide
          Eric Yang added a comment -

          Sync up with trunk.

          Show
          Eric Yang added a comment - Sync up with trunk.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12487858/ZOOKEEPER-999-10.patch
          against trunk revision 1150937.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 12 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          -1 release audit. The applied patch generated 28 release audit warnings (more than the trunk's current 24 warnings).

          -1 core tests. The patch failed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/412//testReport/
          Release audit warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/412//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
          Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/412//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/412//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12487858/ZOOKEEPER-999-10.patch against trunk revision 1150937. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 12 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. -1 release audit. The applied patch generated 28 release audit warnings (more than the trunk's current 24 warnings). -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/412//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/412//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/412//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/412//console This message is automatically generated.
          Hide
          Eric Yang added a comment -

          Core test failed does not seem to be related with this patch.

          Show
          Eric Yang added a comment - Core test failed does not seem to be related with this patch.
          Hide
          Mahadev konar added a comment -

          Eric, can you please resubmit?

          Show
          Mahadev konar added a comment - Eric, can you please resubmit?
          Hide
          Eric Yang added a comment -

          ZOOKEEPER-999-10.patch is in sync with trunk.

          Show
          Eric Yang added a comment - ZOOKEEPER-999 -10.patch is in sync with trunk.
          Hide
          jiraposter@reviews.apache.org added a comment -

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/1143/
          -----------------------------------------------------------

          (Updated 2011-07-28 07:13:52.220703)

          Review request for zookeeper and Mahadev Konar.

          Changes
          -------

          update 10 from eric

          Summary
          -------

          This goal of this ticket is to generate a set of RPM/debian package which integrate well with RPM sets created by HADOOP-6255.

          This addresses bug ZOOKEEPER-999.
          https://issues.apache.org/jira/browse/ZOOKEEPER-999

          Diffs (updated)


          ./README_packaging.txt PRE-CREATION
          ./bin/zkCleanup.sh 1151144
          ./bin/zkCli.sh 1151144
          ./bin/zkEnv.sh 1151144
          ./bin/zkServer.sh 1151144
          ./build.xml 1151144
          ./ivy.xml 1151144
          ./src/contrib/build-contrib.xml 1151144
          ./src/contrib/build.xml 1151144
          ./src/contrib/zkpython/build.xml 1151144
          ./src/contrib/zkpython/ivy.xml PRE-CREATION
          ./src/contrib/zkpython/src/packages/deb/zkpython.control/control PRE-CREATION
          ./src/contrib/zkpython/src/packages/rpm/spec/zkpython.spec PRE-CREATION
          ./src/contrib/zkpython/src/python/setup.py 1151144
          ./src/packages/deb/init.d/zookeeper PRE-CREATION
          ./src/packages/deb/zookeeper.control/conffile PRE-CREATION
          ./src/packages/deb/zookeeper.control/control PRE-CREATION
          ./src/packages/deb/zookeeper.control/postinst PRE-CREATION
          ./src/packages/deb/zookeeper.control/postrm PRE-CREATION
          ./src/packages/deb/zookeeper.control/preinst PRE-CREATION
          ./src/packages/deb/zookeeper.control/prerm PRE-CREATION
          ./src/packages/rpm/init.d/zookeeper PRE-CREATION
          ./src/packages/rpm/spec/zookeeper.spec PRE-CREATION
          ./src/packages/templates/conf/zookeeper-env.sh PRE-CREATION
          ./src/packages/update-zookeeper-env.sh PRE-CREATION
          ./src/recipes/build-recipes.xml 1151144
          ./src/recipes/build.xml 1151144
          ./src/recipes/lock/build.xml 1151144
          ./src/recipes/queue/build.xml 1151144

          Diff: https://reviews.apache.org/r/1143/diff

          Testing
          -------

          Thanks,

          Patrick

          Show
          jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1143/ ----------------------------------------------------------- (Updated 2011-07-28 07:13:52.220703) Review request for zookeeper and Mahadev Konar. Changes ------- update 10 from eric Summary ------- This goal of this ticket is to generate a set of RPM/debian package which integrate well with RPM sets created by HADOOP-6255 . This addresses bug ZOOKEEPER-999 . https://issues.apache.org/jira/browse/ZOOKEEPER-999 Diffs (updated) ./README_packaging.txt PRE-CREATION ./bin/zkCleanup.sh 1151144 ./bin/zkCli.sh 1151144 ./bin/zkEnv.sh 1151144 ./bin/zkServer.sh 1151144 ./build.xml 1151144 ./ivy.xml 1151144 ./src/contrib/build-contrib.xml 1151144 ./src/contrib/build.xml 1151144 ./src/contrib/zkpython/build.xml 1151144 ./src/contrib/zkpython/ivy.xml PRE-CREATION ./src/contrib/zkpython/src/packages/deb/zkpython.control/control PRE-CREATION ./src/contrib/zkpython/src/packages/rpm/spec/zkpython.spec PRE-CREATION ./src/contrib/zkpython/src/python/setup.py 1151144 ./src/packages/deb/init.d/zookeeper PRE-CREATION ./src/packages/deb/zookeeper.control/conffile PRE-CREATION ./src/packages/deb/zookeeper.control/control PRE-CREATION ./src/packages/deb/zookeeper.control/postinst PRE-CREATION ./src/packages/deb/zookeeper.control/postrm PRE-CREATION ./src/packages/deb/zookeeper.control/preinst PRE-CREATION ./src/packages/deb/zookeeper.control/prerm PRE-CREATION ./src/packages/rpm/init.d/zookeeper PRE-CREATION ./src/packages/rpm/spec/zookeeper.spec PRE-CREATION ./src/packages/templates/conf/zookeeper-env.sh PRE-CREATION ./src/packages/update-zookeeper-env.sh PRE-CREATION ./src/recipes/build-recipes.xml 1151144 ./src/recipes/build.xml 1151144 ./src/recipes/lock/build.xml 1151144 ./src/recipes/queue/build.xml 1151144 Diff: https://reviews.apache.org/r/1143/diff Testing ------- Thanks, Patrick
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12487858/ZOOKEEPER-999-10.patch
          against trunk revision 1152141.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 12 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          -1 javac. The patch appears to cause tar ant target to fail.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/443//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/443//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/443//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12487858/ZOOKEEPER-999-10.patch against trunk revision 1152141. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 12 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. -1 javac. The patch appears to cause tar ant target to fail. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/443//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/443//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/443//console This message is automatically generated.
          Hide
          Eric Yang added a comment -

          Previous pre-commit build compiled fine, but the same patch did not build properly in the second trigger. It looks like a build machine issue. Resubmit the patch to build again.

          Show
          Eric Yang added a comment - Previous pre-commit build compiled fine, but the same patch did not build properly in the second trigger. It looks like a build machine issue. Resubmit the patch to build again.
          Hide
          Eric Yang added a comment -

          Test patch-10 again.

          Show
          Eric Yang added a comment - Test patch-10 again.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12487858/ZOOKEEPER-999-10.patch
          against trunk revision 1152141.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 12 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          -1 javac. The patch appears to cause tar ant target to fail.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/450//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/450//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/450//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12487858/ZOOKEEPER-999-10.patch against trunk revision 1152141. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 12 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. -1 javac. The patch appears to cause tar ant target to fail. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/450//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/450//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/450//console This message is automatically generated.
          Hide
          Mahadev konar added a comment -

          Eric/Pat,
          Is this ready to go in?

          Show
          Mahadev konar added a comment - Eric/Pat, Is this ready to go in?
          Hide
          Eric Yang added a comment -

          Jenkins doesn't have clover setup. Hence, the latest build failed on clover check. I am not sure why other builds passed, but they don't seem to be running clover for release audit.
          This patch is ready from my perspective.

          Show
          Eric Yang added a comment - Jenkins doesn't have clover setup. Hence, the latest build failed on clover check. I am not sure why other builds passed, but they don't seem to be running clover for release audit. This patch is ready from my perspective.
          Hide
          Patrick Hunt added a comment -

          zkpython is failing to build:
          https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/450/artifact/trunk/patchprocess/patchJavacWarnings.txt

          [exec] src/c/zookeeper.c:19:20: error: Python.h: No such file or directory

          We need to get python dev re-installed on the hadoop machines.

          Show
          Patrick Hunt added a comment - zkpython is failing to build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/450/artifact/trunk/patchprocess/patchJavacWarnings.txt [exec] src/c/zookeeper.c:19:20: error: Python.h: No such file or directory We need to get python dev re-installed on the hadoop machines.
          Hide
          Patrick Hunt added a comment -

          Committed - thanks Eric!

          Show
          Patrick Hunt added a comment - Committed - thanks Eric!
          Hide
          Eric Yang added a comment -

          Thank you Patrick.

          Show
          Eric Yang added a comment - Thank you Patrick.
          Hide
          Hudson added a comment -

          Integrated in ZooKeeper-trunk #1262 (See https://builds.apache.org/job/ZooKeeper-trunk/1262/)
          ZOOKEEPER-999. Create an package integration project (Eric Yang via phunt)

          phunt : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1156752
          Files :

          • /zookeeper/trunk/README_packaging.txt
          • /zookeeper/trunk/src/packages/templates/conf/zookeeper-env.sh
          • /zookeeper/trunk/src/packages/templates/conf
          • /zookeeper/trunk/bin/zkCleanup.sh
          • /zookeeper/trunk/src/packages
          • /zookeeper/trunk/src/packages/deb/zookeeper.control/postrm
          • /zookeeper/trunk/src/packages/rpm/spec/zookeeper.spec
          • /zookeeper/trunk/src/contrib/build.xml
          • /zookeeper/trunk/bin/zkCli.sh
          • /zookeeper/trunk/src/contrib/zkpython/src/packages/rpm/spec/zkpython.spec
          • /zookeeper/trunk/src/packages/deb/zookeeper.control/conffile
          • /zookeeper/trunk/src/contrib/zkpython/src/packages/rpm
          • /zookeeper/trunk/src/contrib/zkpython/src/packages/deb/zkpython.control
          • /zookeeper/trunk/src/contrib/zkpython/src/python/setup.py
          • /zookeeper/trunk/src/packages/update-zookeeper-env.sh
          • /zookeeper/trunk/src/packages/deb/zookeeper.control/postinst
          • /zookeeper/trunk/src/contrib/build-contrib.xml
          • /zookeeper/trunk/src/recipes/build.xml
          • /zookeeper/trunk/src/recipes/queue/build.xml
          • /zookeeper/trunk/src/contrib/zkpython/src/packages/deb/zkpython.control/control
          • /zookeeper/trunk/src/packages/deb/init.d/zookeeper
          • /zookeeper/trunk/bin/zkEnv.sh
          • /zookeeper/trunk/src/contrib/zkpython/src/packages/rpm/spec
          • /zookeeper/trunk/src/packages/deb/init.d
          • /zookeeper/trunk/src/contrib/zkpython/src/packages/deb
          • /zookeeper/trunk/src/contrib/zkpython/ivy.xml
          • /zookeeper/trunk/src/contrib/zkpython/build.xml
          • /zookeeper/trunk/src/packages/deb/zookeeper.control
          • /zookeeper/trunk/src/packages/rpm/spec
          • /zookeeper/trunk/src/packages/rpm
          • /zookeeper/trunk/ivy.xml
          • /zookeeper/trunk/build.xml
          • /zookeeper/trunk/src/contrib/zkpython/src/packages
          • /zookeeper/trunk/src/packages/rpm/init.d/zookeeper
          • /zookeeper/trunk/src/recipes/build-recipes.xml
          • /zookeeper/trunk/src/packages/templates
          • /zookeeper/trunk/src/packages/rpm/init.d
          • /zookeeper/trunk/src/packages/deb/zookeeper.control/control
          • /zookeeper/trunk/src/packages/deb/zookeeper.control/prerm
          • /zookeeper/trunk/src/recipes/lock/build.xml
          • /zookeeper/trunk/src/packages/deb
          • /zookeeper/trunk/CHANGES.txt
          • /zookeeper/trunk/bin/zkServer.sh
          • /zookeeper/trunk/src/packages/deb/zookeeper.control/preinst
          Show
          Hudson added a comment - Integrated in ZooKeeper-trunk #1262 (See https://builds.apache.org/job/ZooKeeper-trunk/1262/ ) ZOOKEEPER-999 . Create an package integration project (Eric Yang via phunt) phunt : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1156752 Files : /zookeeper/trunk/README_packaging.txt /zookeeper/trunk/src/packages/templates/conf/zookeeper-env.sh /zookeeper/trunk/src/packages/templates/conf /zookeeper/trunk/bin/zkCleanup.sh /zookeeper/trunk/src/packages /zookeeper/trunk/src/packages/deb/zookeeper.control/postrm /zookeeper/trunk/src/packages/rpm/spec/zookeeper.spec /zookeeper/trunk/src/contrib/build.xml /zookeeper/trunk/bin/zkCli.sh /zookeeper/trunk/src/contrib/zkpython/src/packages/rpm/spec/zkpython.spec /zookeeper/trunk/src/packages/deb/zookeeper.control/conffile /zookeeper/trunk/src/contrib/zkpython/src/packages/rpm /zookeeper/trunk/src/contrib/zkpython/src/packages/deb/zkpython.control /zookeeper/trunk/src/contrib/zkpython/src/python/setup.py /zookeeper/trunk/src/packages/update-zookeeper-env.sh /zookeeper/trunk/src/packages/deb/zookeeper.control/postinst /zookeeper/trunk/src/contrib/build-contrib.xml /zookeeper/trunk/src/recipes/build.xml /zookeeper/trunk/src/recipes/queue/build.xml /zookeeper/trunk/src/contrib/zkpython/src/packages/deb/zkpython.control/control /zookeeper/trunk/src/packages/deb/init.d/zookeeper /zookeeper/trunk/bin/zkEnv.sh /zookeeper/trunk/src/contrib/zkpython/src/packages/rpm/spec /zookeeper/trunk/src/packages/deb/init.d /zookeeper/trunk/src/contrib/zkpython/src/packages/deb /zookeeper/trunk/src/contrib/zkpython/ivy.xml /zookeeper/trunk/src/contrib/zkpython/build.xml /zookeeper/trunk/src/packages/deb/zookeeper.control /zookeeper/trunk/src/packages/rpm/spec /zookeeper/trunk/src/packages/rpm /zookeeper/trunk/ivy.xml /zookeeper/trunk/build.xml /zookeeper/trunk/src/contrib/zkpython/src/packages /zookeeper/trunk/src/packages/rpm/init.d/zookeeper /zookeeper/trunk/src/recipes/build-recipes.xml /zookeeper/trunk/src/packages/templates /zookeeper/trunk/src/packages/rpm/init.d /zookeeper/trunk/src/packages/deb/zookeeper.control/control /zookeeper/trunk/src/packages/deb/zookeeper.control/prerm /zookeeper/trunk/src/recipes/lock/build.xml /zookeeper/trunk/src/packages/deb /zookeeper/trunk/CHANGES.txt /zookeeper/trunk/bin/zkServer.sh /zookeeper/trunk/src/packages/deb/zookeeper.control/preinst
          Hide
          Patrick Hunt added a comment -

          I had to revert this - jenkins was failing because of the change to "package" target. We should not be building native code as part of package - rather we need to separate building native code into a target separate from "package". (package should only be java jars and source, etc..., but not machine compiled binaries).

          Show
          Patrick Hunt added a comment - I had to revert this - jenkins was failing because of the change to "package" target. We should not be building native code as part of package - rather we need to separate building native code into a target separate from "package". (package should only be java jars and source, etc..., but not machine compiled binaries).
          Hide
          Hudson added a comment -

          Integrated in ZooKeeper-trunk #1263 (See https://builds.apache.org/job/ZooKeeper-trunk/1263/)
          Reverted ZOOKEEPER-999, small build issue on jenkins

          phunt : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1156845
          Files :

          • /zookeeper/trunk/README_packaging.txt
          • /zookeeper/trunk/src/contrib/zkpython/ivy.xml
          • /zookeeper/trunk/src/contrib/zkpython/build.xml
          • /zookeeper/trunk/src/packages
          • /zookeeper/trunk/bin/zkCleanup.sh
          • /zookeeper/trunk/ivy.xml
          • /zookeeper/trunk/bin/zkCli.sh
          • /zookeeper/trunk/src/contrib/build.xml
          • /zookeeper/trunk/build.xml
          • /zookeeper/trunk/src/contrib/zkpython/src/packages
          • /zookeeper/trunk/src/recipes/build-recipes.xml
          • /zookeeper/trunk/src/contrib/zkpython/src/python/setup.py
          • /zookeeper/trunk/src/recipes/lock/build.xml
          • /zookeeper/trunk/src/recipes/build.xml
          • /zookeeper/trunk/src/contrib/build-contrib.xml
          • /zookeeper/trunk/src/recipes/queue/build.xml
          • /zookeeper/trunk/CHANGES.txt
          • /zookeeper/trunk/bin/zkServer.sh
          • /zookeeper/trunk/bin/zkEnv.sh
          Show
          Hudson added a comment - Integrated in ZooKeeper-trunk #1263 (See https://builds.apache.org/job/ZooKeeper-trunk/1263/ ) Reverted ZOOKEEPER-999 , small build issue on jenkins phunt : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1156845 Files : /zookeeper/trunk/README_packaging.txt /zookeeper/trunk/src/contrib/zkpython/ivy.xml /zookeeper/trunk/src/contrib/zkpython/build.xml /zookeeper/trunk/src/packages /zookeeper/trunk/bin/zkCleanup.sh /zookeeper/trunk/ivy.xml /zookeeper/trunk/bin/zkCli.sh /zookeeper/trunk/src/contrib/build.xml /zookeeper/trunk/build.xml /zookeeper/trunk/src/contrib/zkpython/src/packages /zookeeper/trunk/src/recipes/build-recipes.xml /zookeeper/trunk/src/contrib/zkpython/src/python/setup.py /zookeeper/trunk/src/recipes/lock/build.xml /zookeeper/trunk/src/recipes/build.xml /zookeeper/trunk/src/contrib/build-contrib.xml /zookeeper/trunk/src/recipes/queue/build.xml /zookeeper/trunk/CHANGES.txt /zookeeper/trunk/bin/zkServer.sh /zookeeper/trunk/bin/zkEnv.sh
          Hide
          Eric Yang added a comment -

          Skip native build for "ant tar".

          Show
          Eric Yang added a comment - Skip native build for "ant tar".
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12490306/ZOOKEEPER-999-11.patch
          against trunk revision 1156845.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 12 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/455//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/455//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/455//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12490306/ZOOKEEPER-999-11.patch against trunk revision 1156845. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 12 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/455//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/455//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/455//console This message is automatically generated.
          Hide
          Mahadev konar added a comment -

          Eric, Looks like ant tar is still calling cpp-unit-configure?

          Show
          Mahadev konar added a comment - Eric, Looks like ant tar is still calling cpp-unit-configure?
          Hide
          Eric Yang added a comment -

          Remove create-cppunit-configure dependency for tar, Sync up with trunk.

          Show
          Eric Yang added a comment - Remove create-cppunit-configure dependency for tar, Sync up with trunk.
          Hide
          Eric Yang added a comment -

          Trigger Jenkins to test again.

          Show
          Eric Yang added a comment - Trigger Jenkins to test again.
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12490901/ZOOKEEPER-999-12.patch
          against trunk revision 1159432.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 12 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/466//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/466//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/466//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12490901/ZOOKEEPER-999-12.patch against trunk revision 1159432. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 12 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/466//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/466//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/466//console This message is automatically generated.
          Hide
          Patrick Hunt added a comment -

          Why was create-cppunit-configure removed as a dependency? We have that there originally so that people downloading the source artifact can easily run "configure" w/o needing the tools necessary to "autoreconf". We explicitly added that at some point in order to resolve problems users were seeing.

          I believe we need to add that back. (create-cppunit-configure as a dependency of package)

          Show
          Patrick Hunt added a comment - Why was create-cppunit-configure removed as a dependency? We have that there originally so that people downloading the source artifact can easily run "configure" w/o needing the tools necessary to "autoreconf". We explicitly added that at some point in order to resolve problems users were seeing. I believe we need to add that back. (create-cppunit-configure as a dependency of package)
          Hide
          Eric Yang added a comment -

          create-cppunit-configure was removed per Mahadev's request. The only delta between ZOOKEEPER-999-11.patch and ZOOKEEPER-999-12.patch is create-cppunit-configure. Hence, this issue can still be resolved by ZOOKEEPER-999-11.patch.

          Show
          Eric Yang added a comment - create-cppunit-configure was removed per Mahadev's request. The only delta between ZOOKEEPER-999 -11.patch and ZOOKEEPER-999 -12.patch is create-cppunit-configure. Hence, this issue can still be resolved by ZOOKEEPER-999 -11.patch.
          Hide
          Eric Yang added a comment -

          Upload ZOOKEEPER-999-11.patch as ZOOKEEPER-999-13.patch.

          Show
          Eric Yang added a comment - Upload ZOOKEEPER-999 -11.patch as ZOOKEEPER-999 -13.patch.
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12492098/ZOOKEEPER-999-13.patch
          against trunk revision 1162013.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 12 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/475//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/475//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/475//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12492098/ZOOKEEPER-999-13.patch against trunk revision 1162013. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 12 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/475//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/475//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/475//console This message is automatically generated.
          Hide
          Hudson added a comment -

          Integrated in ZooKeeper-trunk #1287 (See https://builds.apache.org/job/ZooKeeper-trunk/1287/)
          ZOOKEEPER-999. Create an package integration project

          phunt : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1163014
          Files :

          • /zookeeper/trunk/README_packaging.txt
          • /zookeeper/trunk/bin/zkCleanup.sh
          • /zookeeper/trunk/bin/zkCli.sh
          • /zookeeper/trunk/bin/zkEnv.sh
          • /zookeeper/trunk/bin/zkServer.sh
          • /zookeeper/trunk/build.xml
          • /zookeeper/trunk/ivy.xml
          • /zookeeper/trunk/src/contrib/build-contrib.xml
          • /zookeeper/trunk/src/contrib/build.xml
          • /zookeeper/trunk/src/contrib/zkpython/build.xml
          • /zookeeper/trunk/src/contrib/zkpython/ivy.xml
          • /zookeeper/trunk/src/contrib/zkpython/src/packages
          • /zookeeper/trunk/src/contrib/zkpython/src/packages/deb
          • /zookeeper/trunk/src/contrib/zkpython/src/packages/deb/zkpython.control
          • /zookeeper/trunk/src/contrib/zkpython/src/packages/deb/zkpython.control/control
          • /zookeeper/trunk/src/contrib/zkpython/src/packages/rpm
          • /zookeeper/trunk/src/contrib/zkpython/src/packages/rpm/spec
          • /zookeeper/trunk/src/contrib/zkpython/src/packages/rpm/spec/zkpython.spec
          • /zookeeper/trunk/src/contrib/zkpython/src/python/setup.py
          • /zookeeper/trunk/src/packages
          • /zookeeper/trunk/src/packages/deb
          • /zookeeper/trunk/src/packages/deb/init.d
          • /zookeeper/trunk/src/packages/deb/init.d/zookeeper
          • /zookeeper/trunk/src/packages/deb/zookeeper.control
          • /zookeeper/trunk/src/packages/deb/zookeeper.control/conffile
          • /zookeeper/trunk/src/packages/deb/zookeeper.control/control
          • /zookeeper/trunk/src/packages/deb/zookeeper.control/postinst
          • /zookeeper/trunk/src/packages/deb/zookeeper.control/postrm
          • /zookeeper/trunk/src/packages/deb/zookeeper.control/preinst
          • /zookeeper/trunk/src/packages/deb/zookeeper.control/prerm
          • /zookeeper/trunk/src/packages/rpm
          • /zookeeper/trunk/src/packages/rpm/init.d
          • /zookeeper/trunk/src/packages/rpm/init.d/zookeeper
          • /zookeeper/trunk/src/packages/rpm/spec
          • /zookeeper/trunk/src/packages/rpm/spec/zookeeper.spec
          • /zookeeper/trunk/src/packages/templates
          • /zookeeper/trunk/src/packages/templates/conf
          • /zookeeper/trunk/src/packages/templates/conf/zookeeper-env.sh
          • /zookeeper/trunk/src/packages/update-zookeeper-env.sh
          • /zookeeper/trunk/src/recipes/build-recipes.xml
          • /zookeeper/trunk/src/recipes/build.xml
          • /zookeeper/trunk/src/recipes/lock/build.xml
          • /zookeeper/trunk/src/recipes/queue/build.xml
          Show
          Hudson added a comment - Integrated in ZooKeeper-trunk #1287 (See https://builds.apache.org/job/ZooKeeper-trunk/1287/ ) ZOOKEEPER-999 . Create an package integration project phunt : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1163014 Files : /zookeeper/trunk/README_packaging.txt /zookeeper/trunk/bin/zkCleanup.sh /zookeeper/trunk/bin/zkCli.sh /zookeeper/trunk/bin/zkEnv.sh /zookeeper/trunk/bin/zkServer.sh /zookeeper/trunk/build.xml /zookeeper/trunk/ivy.xml /zookeeper/trunk/src/contrib/build-contrib.xml /zookeeper/trunk/src/contrib/build.xml /zookeeper/trunk/src/contrib/zkpython/build.xml /zookeeper/trunk/src/contrib/zkpython/ivy.xml /zookeeper/trunk/src/contrib/zkpython/src/packages /zookeeper/trunk/src/contrib/zkpython/src/packages/deb /zookeeper/trunk/src/contrib/zkpython/src/packages/deb/zkpython.control /zookeeper/trunk/src/contrib/zkpython/src/packages/deb/zkpython.control/control /zookeeper/trunk/src/contrib/zkpython/src/packages/rpm /zookeeper/trunk/src/contrib/zkpython/src/packages/rpm/spec /zookeeper/trunk/src/contrib/zkpython/src/packages/rpm/spec/zkpython.spec /zookeeper/trunk/src/contrib/zkpython/src/python/setup.py /zookeeper/trunk/src/packages /zookeeper/trunk/src/packages/deb /zookeeper/trunk/src/packages/deb/init.d /zookeeper/trunk/src/packages/deb/init.d/zookeeper /zookeeper/trunk/src/packages/deb/zookeeper.control /zookeeper/trunk/src/packages/deb/zookeeper.control/conffile /zookeeper/trunk/src/packages/deb/zookeeper.control/control /zookeeper/trunk/src/packages/deb/zookeeper.control/postinst /zookeeper/trunk/src/packages/deb/zookeeper.control/postrm /zookeeper/trunk/src/packages/deb/zookeeper.control/preinst /zookeeper/trunk/src/packages/deb/zookeeper.control/prerm /zookeeper/trunk/src/packages/rpm /zookeeper/trunk/src/packages/rpm/init.d /zookeeper/trunk/src/packages/rpm/init.d/zookeeper /zookeeper/trunk/src/packages/rpm/spec /zookeeper/trunk/src/packages/rpm/spec/zookeeper.spec /zookeeper/trunk/src/packages/templates /zookeeper/trunk/src/packages/templates/conf /zookeeper/trunk/src/packages/templates/conf/zookeeper-env.sh /zookeeper/trunk/src/packages/update-zookeeper-env.sh /zookeeper/trunk/src/recipes/build-recipes.xml /zookeeper/trunk/src/recipes/build.xml /zookeeper/trunk/src/recipes/lock/build.xml /zookeeper/trunk/src/recipes/queue/build.xml
          Hide
          Patrick Hunt added a comment -

          I committed this to trunk, thanks Eric. (I also verified that trunk on jenkins is still building)

          Show
          Patrick Hunt added a comment - I committed this to trunk, thanks Eric. (I also verified that trunk on jenkins is still building)
          Hide
          Eric Yang added a comment -

          Thank you Patrick.

          Show
          Eric Yang added a comment - Thank you Patrick.
          Hide
          Hudson added a comment -

          Integrated in ZooKeeper-trunk #1288 (See https://builds.apache.org/job/ZooKeeper-trunk/1288/)
          ZOOKEEPER-999. Create an package integration project (Eric Yang via phunt)

          phunt : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1163015
          Files :

          • /zookeeper/trunk/CHANGES.txt
          Show
          Hudson added a comment - Integrated in ZooKeeper-trunk #1288 (See https://builds.apache.org/job/ZooKeeper-trunk/1288/ ) ZOOKEEPER-999 . Create an package integration project (Eric Yang via phunt) phunt : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1163015 Files : /zookeeper/trunk/CHANGES.txt

            People

            • Assignee:
              Eric Yang
              Reporter:
              Eric Yang
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development