Uploaded image for project: 'ZooKeeper'
  1. ZooKeeper
  2. ZOOKEEPER-977

passing null for path_buffer in zoo_create

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.4.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      it is unclear from the comments for zoo_create if a NULL can be passed for path_buffer.

        Activity

        Hide
        breed Benjamin Reed added a comment -

        adds a small clarification to the comment for zoo_create

        Show
        breed Benjamin Reed added a comment - adds a small clarification to the comment for zoo_create
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12468781/ZOOKEEPER-977-1.patch
        against trunk revision 1062244.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 findbugs. The patch appears to introduce 9 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/106//testReport/
        Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/106//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/106//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12468781/ZOOKEEPER-977-1.patch against trunk revision 1062244. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 9 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/106//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/106//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/106//console This message is automatically generated.
        Hide
        michi009 Michi Mutsuzaki (Inactive) added a comment -

        +1.

        Show
        michi009 Michi Mutsuzaki (Inactive) added a comment - +1.
        Hide
        mahadev Mahadev konar added a comment -

        +1 the patch looks good.

        Show
        mahadev Mahadev konar added a comment - +1 the patch looks good.
        Hide
        mahadev Mahadev konar added a comment -

        I just committed this to trunk. thanks ben!

        Show
        mahadev Mahadev konar added a comment - I just committed this to trunk. thanks ben!
        Hide
        hudson Hudson added a comment -

        Integrated in ZooKeeper-trunk #1092 (See https://hudson.apache.org/hudson/job/ZooKeeper-trunk/1092/)
        ZOOKEEPER-977. passing null for path_buffer in zoo_create (breed via mahadev)

        Show
        hudson Hudson added a comment - Integrated in ZooKeeper-trunk #1092 (See https://hudson.apache.org/hudson/job/ZooKeeper-trunk/1092/ ) ZOOKEEPER-977 . passing null for path_buffer in zoo_create (breed via mahadev)

          People

          • Assignee:
            breed Benjamin Reed
            Reporter:
            breed Benjamin Reed
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development