ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-913

Version parser fails to parse "3.3.2-dev" from build.xml.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 3.3.1
    • Fix Version/s: 3.3.3, 3.4.0
    • Component/s: build
    • Labels:
      None

      Description

      Cannot build 3.3.1 from release tarball do to VerGen parser inability to parse "3.3.2-dev".

      version-info:
      [java] All version-related parameters must be valid integers!
      [java] Exception in thread "main" java.lang.NumberFormatException: For input string: "2-dev"
      [java] at java.lang.NumberFormatException.forInputString(NumberFormatException.java:65)
      [java] at java.lang.Integer.parseInt(Integer.java:481)
      [java] at java.lang.Integer.parseInt(Integer.java:514)
      [java] at org.apache.zookeeper.version.util.VerGen.main(VerGen.java:131)
      [java] Java Result: 1

      1. zk-build.patch
        0.6 kB
        Anthony Urso
      2. zk-version.patch
        0.7 kB
        Anthony Urso
      3. ZOOKEEPER-913.patch
        9 kB
        Patrick Hunt
      4. ZOOKEEPER-913_br33.patch
        9 kB
        Patrick Hunt

        Activity

        Hide
        Anthony Urso added a comment -

        Two possible solutions. Choose the most effective.

        Show
        Anthony Urso added a comment - Two possible solutions. Choose the most effective.
        Hide
        Patrick Hunt added a comment -

        I like the "version" patch better. However it should be made more general.

        We've had problems with this before. We should parse X.Y.Zblah where anything after Z (Z expected to be a number) gets put into some additional field ("extension"?).

        Show
        Patrick Hunt added a comment - I like the "version" patch better. However it should be made more general. We've had problems with this before. We should parse X.Y.Zblah where anything after Z (Z expected to be a number) gets put into some additional field ("extension"?).
        Hide
        Patrick Hunt added a comment -

        I propose we move to support the same format as maven supports:
        http://www.sonatype.com/books/mvnref-book/reference/pom-relationships-sect-pom-syntax.html

        <major version>.<minor version>.<incremental version>-<qualifier>

        this is close to what we do, but allows for any "qualifier" after the x.y.z-

        Show
        Patrick Hunt added a comment - I propose we move to support the same format as maven supports: http://www.sonatype.com/books/mvnref-book/reference/pom-relationships-sect-pom-syntax.html <major version>.<minor version>.<incremental version>-<qualifier> this is close to what we do, but allows for any "qualifier" after the x.y.z-
        Hide
        Patrick Hunt added a comment -

        this most recent patch implements support for a version format similar to what maven does.

        Added tests, also verified on the command line (build) using -Dversion option. Seems to work ok.

        Show
        Patrick Hunt added a comment - this most recent patch implements support for a version format similar to what maven does. Added tests, also verified on the command line (build) using -Dversion option. Seems to work ok.
        Hide
        Anthony Urso added a comment -

        Looks great, thanks!

        Show
        Anthony Urso added a comment - Looks great, thanks!
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12459194/ZOOKEEPER-913.patch
        against trunk revision 1033155.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 2 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/19//testReport/
        Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/19//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/19//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12459194/ZOOKEEPER-913.patch against trunk revision 1033155. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 2 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/19//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/19//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/19//console This message is automatically generated.
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12459194/ZOOKEEPER-913.patch
        against trunk revision 1033155.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 2 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/20//testReport/
        Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/20//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/20//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12459194/ZOOKEEPER-913.patch against trunk revision 1033155. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 2 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/20//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/20//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/20//console This message is automatically generated.
        Hide
        Benjamin Reed added a comment -

        only committed to trunk. (doesn't compile with 3.3)

        Show
        Benjamin Reed added a comment - only committed to trunk. (doesn't compile with 3.3)
        Hide
        Patrick Hunt added a comment -

        Thanks Ben, however I'd like to see this go in 3.3.3 as well (was working originally). If someone else doesn't jump in before me I'll submit a patch targeting 3.3 branch when I have a chance.

        Show
        Patrick Hunt added a comment - Thanks Ben, however I'd like to see this go in 3.3.3 as well (was working originally). If someone else doesn't jump in before me I'll submit a patch targeting 3.3 branch when I have a chance.
        Hide
        Hudson added a comment -

        Integrated in ZooKeeper-trunk #1031 (See https://hudson.apache.org/hudson/job/ZooKeeper-trunk/1031/)
        ZOOKEEPER-913. Version parser fails to parse "3.3.2-dev" from build.xml

        Show
        Hudson added a comment - Integrated in ZooKeeper-trunk #1031 (See https://hudson.apache.org/hudson/job/ZooKeeper-trunk/1031/ ) ZOOKEEPER-913 . Version parser fails to parse "3.3.2-dev" from build.xml
        Hide
        Patrick Hunt added a comment -

        slight modification to the 913 patch to allow compilation on branch 3.3

        Show
        Patrick Hunt added a comment - slight modification to the 913 patch to allow compilation on branch 3.3
        Hide
        Patrick Hunt added a comment -

        Committed to 3.3 branch.

        Show
        Patrick Hunt added a comment - Committed to 3.3 branch.

          People

          • Assignee:
            Patrick Hunt
            Reporter:
            Anthony Urso
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development