ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-902

Fix findbug issue in trunk "Malicious code vulnerability"

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 3.4.0
    • Fix Version/s: 3.4.0
    • Component/s: quorum, server
    • Labels:
      None

      Description

      https://hudson.apache.org/hudson/view/ZooKeeper/job/ZooKeeper-trunk/970/artifact/trunk/findbugs/zookeeper-findbugs-report.html#Warnings_MALICIOUS_CODE

      Malicious code vulnerability Warnings

      Code Warning
      MS org.apache.zookeeper.server.quorum.LeaderElection.epochGen isn't final but should be

      1. ZOOKEEPER-902.patch
        2 kB
        Patrick Hunt
      2. ZOOKEEPER-902.patch
        7 kB
        Flavio Junqueira
      3. ZOOKEEPER-902.patch
        8 kB
        Flavio Junqueira
      4. ZOOKEEPER-902.patch
        10 kB
        Patrick Hunt
      5. ZOOKEEPER-902.patch
        10 kB
        Patrick Hunt
      6. ZOOKEEPER-902.patch
        11 kB
        Flavio Junqueira
      7. ZOOKEEPER-902.patch
        18 kB
        Flavio Junqueira
      8. ZOOKEEPER-902.patch
        18 kB
        Flavio Junqueira
      9. ZOOKEEPER-902.patch
        20 kB
        Patrick Hunt

        Issue Links

          Activity

          Hide
          Patrick Hunt added a comment -

          The patch queue now has a setting:

          (10:28:53 AM) nigelcdn: There's a new file in src/java/test/bin/test-patch.properties in which is defined the acceptable number of warnings
          (10:29:03 AM) nigelcdn: use it very judiciously

          after this issue is fixed we should adjust that file back to 0.

          Show
          Patrick Hunt added a comment - The patch queue now has a setting: (10:28:53 AM) nigelcdn: There's a new file in src/java/test/bin/test-patch.properties in which is defined the acceptable number of warnings (10:29:03 AM) nigelcdn: use it very judiciously after this issue is fixed we should adjust that file back to 0.
          Hide
          Nigel Daley added a comment -

          The patch for this issue should also update src/java/test/bin/test-patch.properties to set OK_FINDBUGS_WARNINGS=0

          Show
          Nigel Daley added a comment - The patch for this issue should also update src/java/test/bin/test-patch.properties to set OK_FINDBUGS_WARNINGS=0
          Hide
          Flavio Junqueira added a comment -

          This issue has been resolved in ZOOKEEPER-900. We should resolve this issue, perhaps after getting a confirmation from Hudson.

          Show
          Flavio Junqueira added a comment - This issue has been resolved in ZOOKEEPER-900 . We should resolve this issue, perhaps after getting a confirmation from Hudson.
          Hide
          Vishal Kher added a comment -

          fyi, I had not included test-patch.properties file in my diff.

          Show
          Vishal Kher added a comment - fyi, I had not included test-patch.properties file in my diff.
          Hide
          Flavio Junqueira added a comment -

          Agreed, I've seen that 900 didn't include it. I'd rather let Pat take care of wrapping up this issue...

          Show
          Flavio Junqueira added a comment - Agreed, I've seen that 900 didn't include it. I'd rather let Pat take care of wrapping up this issue...
          Hide
          Patrick Hunt added a comment -

          Sounds good. Let's clear out 900 then we can adjust the OK setting back to 0 (as part of this jira) once 900 is committed.

          Show
          Patrick Hunt added a comment - Sounds good. Let's clear out 900 then we can adjust the OK setting back to 0 (as part of this jira) once 900 is committed.
          Hide
          Patrick Hunt added a comment -

          This patch addressed 4 out of 10 of the findbugs issues.

          Flavio please take a look at the remaining 6 - they are in quorum code.

          Show
          Patrick Hunt added a comment - This patch addressed 4 out of 10 of the findbugs issues. Flavio please take a look at the remaining 6 - they are in quorum code.
          Hide
          Flavio Junqueira added a comment -

          I have fixed all remaining warnings, but the ones on QuorumCnxManager. I want to check if they are being fixed in one of the current pending patches that Vishal has been working on. It makes more sense to fix them separately.

          For Follower, Observer, and Learner, I have removed the synchronization blocks around pendingRevalidations. It seems ok to me to remove them, and this is what findbugs was apparently complaining about.

          For AuthFLE, I have fixed synchronization blocks in a different way, by simply replacing the objects we were synchronizing on. In the case of acksqueue, I have replaced the data structure we were using from LinkedBlockQueue to HashSet. It made sense to me to make the change given the way were using acksqueue and fixes the warning.

          Show
          Flavio Junqueira added a comment - I have fixed all remaining warnings, but the ones on QuorumCnxManager. I want to check if they are being fixed in one of the current pending patches that Vishal has been working on. It makes more sense to fix them separately. For Follower, Observer, and Learner, I have removed the synchronization blocks around pendingRevalidations. It seems ok to me to remove them, and this is what findbugs was apparently complaining about. For AuthFLE, I have fixed synchronization blocks in a different way, by simply replacing the objects we were synchronizing on. In the case of acksqueue, I have replaced the data structure we were using from LinkedBlockQueue to HashSet. It made sense to me to make the change given the way were using acksqueue and fixes the warning.
          Hide
          Patrick Hunt added a comment -

          It makes more sense to fix them separately.

          that's fine, except that the patch queue is failing until those jiras are committed (eta?). If we want to go that route let me know and I'll temporarily change the "allow this many fb errors" count on the patch queue. Then when those other jiras are addressed we can change the value back to 0.

          Show
          Patrick Hunt added a comment - It makes more sense to fix them separately. that's fine, except that the patch queue is failing until those jiras are committed (eta?). If we want to go that route let me know and I'll temporarily change the "allow this many fb errors" count on the patch queue. Then when those other jiras are addressed we can change the value back to 0.
          Hide
          Flavio Junqueira added a comment -

          It is ok with me to fix the warnings in QCM to get hudson to work. I'm uploading a new patch.

          Show
          Flavio Junqueira added a comment - It is ok with me to fix the warnings in QCM to get hudson to work. I'm uploading a new patch.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12470067/ZOOKEEPER-902.patch
          against trunk revision 1062244.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 findbugs. The patch appears to introduce 2 new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/111//testReport/
          Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/111//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/111//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12470067/ZOOKEEPER-902.patch against trunk revision 1062244. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 2 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/111//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/111//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/111//console This message is automatically generated.
          Hide
          Patrick Hunt added a comment -

          looks like 2 of the excludes got dropped accidentally. I added them back.

          Show
          Patrick Hunt added a comment - looks like 2 of the excludes got dropped accidentally. I added them back.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12470100/ZOOKEEPER-902.patch
          against trunk revision 1062244.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          -1 patch. The patch command could not apply the patch.

          Console output: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/112//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12470100/ZOOKEEPER-902.patch against trunk revision 1062244. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/112//console This message is automatically generated.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12470100/ZOOKEEPER-902.patch
          against trunk revision 1062244.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          -1 patch. The patch command could not apply the patch.

          Console output: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/113//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12470100/ZOOKEEPER-902.patch against trunk revision 1062244. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/113//console This message is automatically generated.
          Hide
          Patrick Hunt added a comment -

          bad patch, fixed.

          Show
          Patrick Hunt added a comment - bad patch, fixed.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12470112/ZOOKEEPER-902.patch
          against trunk revision 1062244.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/116//testReport/
          Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/116//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/116//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12470112/ZOOKEEPER-902.patch against trunk revision 1062244. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/116//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/116//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/116//console This message is automatically generated.
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12470112/ZOOKEEPER-902.patch
          against trunk revision 1062244.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/117//testReport/
          Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/117//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/117//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12470112/ZOOKEEPER-902.patch against trunk revision 1062244. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/117//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/117//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/117//console This message is automatically generated.
          Hide
          Benjamin Reed added a comment -

          the patch looks good except for two issues i see:

          1) ackset is not consistently synchronized. my impression is that this could be a ConcurrentHashMap and then the single synchronized block can be removed.
          2) challengeMap is not consistently synchronized, so it is hard to understand if that synchronized block is correct.

          Show
          Benjamin Reed added a comment - the patch looks good except for two issues i see: 1) ackset is not consistently synchronized. my impression is that this could be a ConcurrentHashMap and then the single synchronized block can be removed. 2) challengeMap is not consistently synchronized, so it is hard to understand if that synchronized block is correct.
          Hide
          Patrick Hunt added a comment -

          Flavio can you address these concerns? Thanks.

          Show
          Patrick Hunt added a comment - Flavio can you address these concerns? Thanks.
          Hide
          Flavio Junqueira added a comment -

          Thanks for your comments, Ben.

          1- I have made ackset a "ConcurrentHashMap";
          2- The blocks synchronized on challengeMap were to guarantee that challengeMap and challengeMutex are accessed atomically. I have changed the monitor object to "Messenger.this" to avoid confusion, but let me know what you think. I have also made HashMaps concurrent, since there could be multiple threads accessing.

          Show
          Flavio Junqueira added a comment - Thanks for your comments, Ben. 1- I have made ackset a "ConcurrentHashMap"; 2- The blocks synchronized on challengeMap were to guarantee that challengeMap and challengeMutex are accessed atomically. I have changed the monitor object to "Messenger.this" to avoid confusion, but let me know what you think. I have also made HashMaps concurrent, since there could be multiple threads accessing.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12470313/ZOOKEEPER-902.patch
          against trunk revision 1062244.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 findbugs. The patch appears to introduce 6 new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/120//testReport/
          Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/120//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/120//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12470313/ZOOKEEPER-902.patch against trunk revision 1062244. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 6 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/120//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/120//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/120//console This message is automatically generated.
          Hide
          Flavio Junqueira added a comment -

          Another attempt.

          Show
          Flavio Junqueira added a comment - Another attempt.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12470350/ZOOKEEPER-902.patch
          against trunk revision 1062244.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 findbugs. The patch appears to introduce 4 new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/121//testReport/
          Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/121//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/121//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12470350/ZOOKEEPER-902.patch against trunk revision 1062244. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 4 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/121//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/121//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/121//console This message is automatically generated.
          Hide
          Flavio Junqueira added a comment -

          Yet another attempt.

          Show
          Flavio Junqueira added a comment - Yet another attempt.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12470352/ZOOKEEPER-902.patch
          against trunk revision 1062244.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 findbugs. The patch appears to introduce 2 new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/122//testReport/
          Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/122//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/122//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12470352/ZOOKEEPER-902.patch against trunk revision 1062244. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 2 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/122//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/122//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/122//console This message is automatically generated.
          Hide
          Patrick Hunt added a comment -

          Flavio you can run this locally as:
          ant -Dfindbugs.home=/home/phunt/dev/findbugs-1.3.9 findbugs

          Show
          Patrick Hunt added a comment - Flavio you can run this locally as: ant -Dfindbugs.home=/home/phunt/dev/findbugs-1.3.9 findbugs
          Hide
          Flavio Junqueira added a comment -

          For some reason, my setup doesn't report the same issues. In any case, if you check the latest hudson report, there is no warning on quorum.

          Show
          Flavio Junqueira added a comment - For some reason, my setup doesn't report the same issues. In any case, if you check the latest hudson report, there is no warning on quorum.
          Hide
          Patrick Hunt added a comment -

          Flavio you dropped the excludes xml file changes again, I updated the patch to include them.

          I ran this on my machine and it came up with no issues, so we should be good to go.

          Show
          Patrick Hunt added a comment - Flavio you dropped the excludes xml file changes again, I updated the patch to include them. I ran this on my machine and it came up with no issues, so we should be good to go.
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12470421/ZOOKEEPER-902.patch
          against trunk revision 1062244.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/123//testReport/
          Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/123//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/123//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12470421/ZOOKEEPER-902.patch against trunk revision 1062244. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/123//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/123//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/123//console This message is automatically generated.
          Hide
          Benjamin Reed added a comment -

          +1 looks good. thanx flavio!

          Show
          Benjamin Reed added a comment - +1 looks good. thanx flavio!
          Hide
          Patrick Hunt added a comment -

          I've committed this to trunk. Thanks Flavio!

          Show
          Patrick Hunt added a comment - I've committed this to trunk. Thanks Flavio!
          Hide
          Hudson added a comment -

          Integrated in ZooKeeper-trunk #1090 (See https://hudson.apache.org/hudson/job/ZooKeeper-trunk/1090/)
          ZOOKEEPER-902. Fix findbug issue in trunk "Malicious code vulnerability"

          Show
          Hudson added a comment - Integrated in ZooKeeper-trunk #1090 (See https://hudson.apache.org/hudson/job/ZooKeeper-trunk/1090/ ) ZOOKEEPER-902 . Fix findbug issue in trunk "Malicious code vulnerability"

            People

            • Assignee:
              Flavio Junqueira
              Reporter:
              Patrick Hunt
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development