Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.4.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      the zookeeper current trunk build is broken mostly due to some netty changes. This is causing a huge backlog of PA's and other impediments to the review process. For now I plan to disable the test and fix them as part of 3.4 later.

      1. ZOOKEEPER-870.patch
        3 kB
        Mahadev konar
      2. ZOOKEEPER-870.patch
        1 kB
        Mahadev konar

        Activity

        Mahadev konar created issue -
        Hide
        Mahadev konar added a comment -

        Testcase: testHammer took 81.115 sec
        FAILED
        node count not consistent expected:<1771> but was:<0>
        junit.framework.AssertionFailedError: node count not consistent expected:<1771> but was:<0>
        at org.apache.zookeeper.test.ClientBase.verifyRootOfAllServersMatch(ClientBase.java:581)
        at org.apache.zookeeper.test.AsyncHammerTest.testHammer(AsyncHammerTest.java:190)
        at org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:51)

        The test case

        junit] Tests run: 2, Failures: 1, Errors: 0, Time elapsed: 107.528 sec
        [junit] Test org.apache.zookeeper.test.NioNettySuiteHammerTest FAILED

        also fails.

        Show
        Mahadev konar added a comment - Testcase: testHammer took 81.115 sec FAILED node count not consistent expected:<1771> but was:<0> junit.framework.AssertionFailedError: node count not consistent expected:<1771> but was:<0> at org.apache.zookeeper.test.ClientBase.verifyRootOfAllServersMatch(ClientBase.java:581) at org.apache.zookeeper.test.AsyncHammerTest.testHammer(AsyncHammerTest.java:190) at org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:51) The test case junit] Tests run: 2, Failures: 1, Errors: 0, Time elapsed: 107.528 sec [junit] Test org.apache.zookeeper.test.NioNettySuiteHammerTest FAILED also fails.
        Hide
        Mahadev konar added a comment -

        This patch ignores the following assertions for now:

        • the count of fds in ClienTest
        • the count of nodes in ClientBase

        These changes will be reverted back in ZOOKEEPER-871 before 3.4 is released. This is just a patch to get the patch process running so that review is done on time.

        Show
        Mahadev konar added a comment - This patch ignores the following assertions for now: the count of fds in ClienTest the count of nodes in ClientBase These changes will be reverted back in ZOOKEEPER-871 before 3.4 is released. This is just a patch to get the patch process running so that review is done on time.
        Mahadev konar made changes -
        Field Original Value New Value
        Attachment ZOOKEEPER-870.patch [ 12454614 ]
        Mahadev konar made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Patrick Hunt added a comment -

        this looks good, however can you make conditional, where the detail is logged at ERROR level if the original assert failed, and at info level otw? you can use LOG.log(priority, msg... ) where priority is a conditional value. then we can more easily identify errors

        also, I'd suggest opening another jira for this same release to revert this change at some point. (so we don't forget)

        Show
        Patrick Hunt added a comment - this looks good, however can you make conditional, where the detail is logged at ERROR level if the original assert failed, and at info level otw? you can use LOG.log(priority, msg... ) where priority is a conditional value. then we can more easily identify errors also, I'd suggest opening another jira for this same release to revert this change at some point. (so we don't forget)
        Hide
        Mahadev konar added a comment -

        updated patch with comments incorporated.

        Show
        Mahadev konar added a comment - updated patch with comments incorporated.
        Mahadev konar made changes -
        Attachment ZOOKEEPER-870.patch [ 12454617 ]
        Hide
        Patrick Hunt added a comment -

        +1 looks ok. pushed to trunk.

        Show
        Patrick Hunt added a comment - +1 looks ok. pushed to trunk.
        Patrick Hunt made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags [Reviewed]
        Resolution Fixed [ 1 ]
        Hide
        Hudson added a comment -

        Integrated in ZooKeeper-trunk #936 (See https://hudson.apache.org/hudson/job/ZooKeeper-trunk/936/)
        ZOOKEEPER-870. Zookeeper trunk build broken.

        Show
        Hudson added a comment - Integrated in ZooKeeper-trunk #936 (See https://hudson.apache.org/hudson/job/ZooKeeper-trunk/936/ ) ZOOKEEPER-870 . Zookeeper trunk build broken.
        Mahadev konar made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        1h 32m 1 Mahadev konar 15/Sep/10 00:49
        Patch Available Patch Available Resolved Resolved
        6h 8m 1 Patrick Hunt 15/Sep/10 06:57
        Resolved Resolved Closed Closed
        434d 13h 25m 1 Mahadev konar 23/Nov/11 19:22

          People

          • Assignee:
            Mahadev konar
            Reporter:
            Mahadev konar
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development