ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-853

Make zookeeper.is_unrecoverable return True or False and not an integer

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.4.0
    • Component/s: contrib-bindings
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Release Note:
      zookeeper.is_unrecoverable returns True or False

      Description

      This is a patch that fixes a TODO from the python zookeeper extension, it makes zookeeper.is_unrecoverable return True or False and not an integer.

      1. ZOOKEEPER-853.patch
        2 kB
        Andrei Savu
      2. ZOOKEEPER-853.patch
        2 kB
        Andrei Savu

        Activity

        Andrei Savu created issue -
        Andrei Savu made changes -
        Field Original Value New Value
        Attachment ZOOKEEPER-853.patch [ 12452511 ]
        Andrei Savu made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Andrei Savu made changes -
        Status Patch Available [ 10002 ] Open [ 1 ]
        Hide
        Andrei Savu added a comment -

        Fixed patch to do proper reference counting when returning boolean values.

        Show
        Andrei Savu added a comment - Fixed patch to do proper reference counting when returning boolean values.
        Andrei Savu made changes -
        Attachment ZOOKEEPER-853.patch [ 12452514 ]
        Andrei Savu made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Henry Robinson added a comment -

        +1 This looks good to me - thanks.

        Show
        Henry Robinson added a comment - +1 This looks good to me - thanks.
        Henry Robinson made changes -
        Hadoop Flags [Reviewed]
        Hide
        Henry Robinson added a comment -

        I just committed this (to trunk) - thanks Andrei!

        Show
        Henry Robinson added a comment - I just committed this (to trunk) - thanks Andrei!
        Henry Robinson made changes -
        Resolution Fixed [ 1 ]
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hide
        Andrei Savu added a comment -

        Thanks Henry.

        Show
        Andrei Savu added a comment - Thanks Henry.
        Hide
        Hudson added a comment -

        Integrated in ZooKeeper-trunk #936 (See https://hudson.apache.org/hudson/job/ZooKeeper-trunk/936/)

        Show
        Hudson added a comment - Integrated in ZooKeeper-trunk #936 (See https://hudson.apache.org/hudson/job/ZooKeeper-trunk/936/ )
        Mahadev konar made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Andrei Savu
            Reporter:
            Andrei Savu
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development