Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.3.1
    • Fix Version/s: 3.3.2, 3.4.0
    • Component/s: java client
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      ClientCnxn.java currently has the following code:
      if (replyHdr.getXid() == -4) {
      // -2 is the xid for AuthPacket
      // TODO: process AuthPacket here
      if (LOG.isDebugEnabled())

      { LOG.debug("Got auth sessionid:0x" + Long.toHexString(sessionId)); }

      return;
      }

      Auth failures appear to cause the server to disconnect but the client never gets a proper state change or notification that auth has failed, which makes handling this scenario very difficult as it causes the client to go into a loop of sending bad auth, getting disconnected, trying to reconnect, sending bad auth again, over and over.

      1. ZOOKEEPER-844.patch
        4 kB
        Camille Fournier
      2. ZOOKEEPER332-844
        5 kB
        Camille Fournier

        Activity

        Hide
        Camille Fournier added a comment -

        Patch to fix this bug, please review. I looked at the C client and I believe this is the same basic way auth failed is handled in that code. Thanks.

        Show
        Camille Fournier added a comment - Patch to fix this bug, please review. I looked at the C client and I believe this is the same basic way auth failed is handled in that code. Thanks.
        Hide
        Giridharan Kesavan added a comment -

        submitting to hudson

        Show
        Giridharan Kesavan added a comment - submitting to hudson
        Hide
        Camille Fournier added a comment -

        Patch for ZooKeeper 3.3.1 branch

        Show
        Camille Fournier added a comment - Patch for ZooKeeper 3.3.1 branch
        Hide
        Patrick Hunt added a comment -

        This is really a bug, not an improvement.

        Show
        Patrick Hunt added a comment - This is really a bug, not an improvement.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12453719/ZOOKEEPER332-844
        against trunk revision 997192.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        -1 patch. The patch command could not apply the patch.

        Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/112/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12453719/ZOOKEEPER332-844 against trunk revision 997192. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/112/console This message is automatically generated.
        Hide
        Patrick Hunt added a comment -

        IIRC qabot will apply the most recent patch, it only knows about trunk though (no branches).

        The easiest way to address is to attach the patch for br33 first, then attach the patch for trunk. Pretty hacky but it works ok for me.

        The other option is to just attach both patches and state in a comment the problem, ask a committer to review it manually instead of waiting on qabot.

        Thanks!

        Show
        Patrick Hunt added a comment - IIRC qabot will apply the most recent patch, it only knows about trunk though (no branches). The easiest way to address is to attach the patch for br33 first, then attach the patch for trunk. Pretty hacky but it works ok for me. The other option is to just attach both patches and state in a comment the problem, ask a committer to review it manually instead of waiting on qabot. Thanks!
        Hide
        Camille Fournier added a comment -

        First the 3.3.2 patch...

        Show
        Camille Fournier added a comment - First the 3.3.2 patch...
        Hide
        Camille Fournier added a comment -

        patch to HEAD

        Show
        Camille Fournier added a comment - patch to HEAD
        Hide
        Patrick Hunt added a comment -

        +1 looks good to me. Thanks Camille!

        Show
        Patrick Hunt added a comment - +1 looks good to me. Thanks Camille!
        Hide
        Patrick Hunt added a comment -

        Committed to trunk/3.3. Thanks Camille!

        Show
        Patrick Hunt added a comment - Committed to trunk/3.3. Thanks Camille!
        Hide
        Hudson added a comment -

        Integrated in ZooKeeper-trunk #959 (See https://hudson.apache.org/hudson/job/ZooKeeper-trunk/959/)
        ZOOKEEPER-844. handle auth failure in java client

        Show
        Hudson added a comment - Integrated in ZooKeeper-trunk #959 (See https://hudson.apache.org/hudson/job/ZooKeeper-trunk/959/ ) ZOOKEEPER-844 . handle auth failure in java client

          People

          • Assignee:
            Camille Fournier
            Reporter:
            Camille Fournier
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development