[ZOOKEEPER-844] handle auth failure in java client

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.3.1
• Fix Version/s: 3.3.2, 3.4.0
• Component/s: java client
• Hadoop Flags: Reviewed
• Assignee: Camille Fournier
• Reporter: Camille Fournier
• Created: 12/Aug/10 16:05
• Updated: 23/Nov/11 19:22
• Resolved: 06/Oct/10 16:19

Description

ClientCnxn.java currently has the following code:
if (replyHdr.getXid() == -4) {
// -2 is the xid for AuthPacket
// TODO: process AuthPacket here
if (LOG.isDebugEnabled())

{ LOG.debug("Got auth sessionid:0x" + Long.toHexString(sessionId)); }

return;
}

Auth failures appear to cause the server to disconnect but the client never gets a proper state change or notification that auth has failed, which makes handling this scenario very difficult as it causes the client to go into a loop of sending bad auth, getting disconnected, trying to reconnect, sending bad auth again, over and over.