[ZOOKEEPER-837] cyclic dependency ClientCnxn, ZooKeeper

• Type: Sub-task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.3.1
• Fix Version/s: 3.7.0
• Component/s: java client
• Labels: pull-request-available
• Tags: cyclic dependency
• Assignee: Zili Chen
• Reporter: Patrick Datko
• Created: 11/Aug/10 14:47
• Updated: 28/Mar/21 08:55
• Resolved: 17/May/20 13:14

Description

ZooKeeper instantiates ClientCnxn in its ctor with this and therefor builds a
cyclic dependency graph between both objects. This means, you can't have the
one without the other. So why did you bother do make them to separate classes
in the first place?
ClientCnxn accesses ZooKeeper.state. State should rather be a property of
ClientCnxn. And ClientCnxn accesses zooKeeper.get???Watches() in its method
primeConnection(). I've not yet checked, how this dependency should be
resolved better.

Issue Links

• is a clone of: ZOOKEEPER-666 Unsafe publication in client API
• is depended upon by: ZOOKEEPER-911 move operations from methods to individual classes
• links to: GitHub Pull Request #1095