Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.4.0
    • Component/s: contrib
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Activity

      Hide
      Hudson added a comment -

      Integrated in ZooKeeper-trunk #869 (See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/869/)
      ZOOKEEPER-798. Fixup loggraph for FLE changes

      Show
      Hudson added a comment - Integrated in ZooKeeper-trunk #869 (See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/869/ ) ZOOKEEPER-798 . Fixup loggraph for FLE changes
      Hide
      Ivan Kelly added a comment -

      editor updated now.

      Show
      Ivan Kelly added a comment - editor updated now.
      Hide
      Patrick Hunt added a comment -

      +1, thanks Ivan!

      ps - please update your editor settings to use spaces rather than tabs for indentation. I didn't fix this patch because it looks endemic to the loggraph contrib, but you might consider fixing this at some point.

      Show
      Patrick Hunt added a comment - +1, thanks Ivan! ps - please update your editor settings to use spaces rather than tabs for indentation. I didn't fix this patch because it looks endemic to the loggraph contrib, but you might consider fixing this at some point.
      Hide
      Hadoop QA added a comment -

      -1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12448307/ZOOKEEPER-798.patch
      against trunk revision 958096.

      +1 @author. The patch does not contain any @author tags.

      -1 tests included. The patch doesn't appear to include any new or modified tests.
      Please justify why no tests are needed for this patch.

      +1 javadoc. The javadoc tool did not generate any warning messages.

      +1 javac. The applied patch does not increase the total number of javac compiler warnings.

      +1 findbugs. The patch does not introduce any new Findbugs warnings.

      +1 release audit. The applied patch does not increase the total number of release audit warnings.

      +1 core tests. The patch passed core unit tests.

      +1 contrib tests. The patch passed contrib unit tests.

      Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/90/testReport/
      Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/90/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
      Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/90/console

      This message is automatically generated.

      Show
      Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12448307/ZOOKEEPER-798.patch against trunk revision 958096. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/90/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/90/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/90/console This message is automatically generated.
      Hide
      Ivan Kelly added a comment -

      Changes to the loggraph log parsing to allow for flavio's changes to the FLE logging (ZOOKEEPER-789)

      Show
      Ivan Kelly added a comment - Changes to the loggraph log parsing to allow for flavio's changes to the FLE logging ( ZOOKEEPER-789 )

        People

        • Assignee:
          Ivan Kelly
          Reporter:
          Ivan Kelly
        • Votes:
          0 Vote for this issue
          Watchers:
          0 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development