ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-781

provide a generalized "connection strategy" for ZooKeeper clients

    Details

    • Type: New Feature New Feature
    • Status: Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: 3.5.0
    • Component/s: c client, java client
    • Labels:
      None
    • Release Note:
      a draft patch for c client

      Description

      A connection strategy allows control over the way that ZooKeeper clients (we would implement this for both c and java apis) connect to a serving ensemble. Today we have two strategies, randomized round robin (default) and ordered round robin, both of which are hard coded into the client implementation. We would generalize this interface and allow users to create their own.

      See this page for more detail: http://wiki.apache.org/hadoop/ZooKeeper/ConnectionStrategy

      1. ZOOKEEPER-781.patch
        35 kB
        Patrick Hunt
      2. ZOOKEEPER-781.patch
        34 kB
        Qian Ye
      3. ZOOKEEPER-781.patch
        34 kB
        Qian Ye
      4. ZOOKEEPER-781.patch
        34 kB
        Qian Ye
      5. ZOOKEEPER-781.patch
        33 kB
        Michi Mutsuzaki
      6. ZOOKEEPER-781.patch
        33 kB
        Qian Ye
      7. ZOOKEEPER-781.patch
        33 kB
        Qian Ye

        Issue Links

          Activity

          Hide
          Mahadev konar added a comment -

          Moving this out. Not a blocker for 3.4.

          Show
          Mahadev konar added a comment - Moving this out. Not a blocker for 3.4.
          Hide
          Patrick Hunt added a comment -

          While resolving the recent conflict I noticed that zookeeper_init signature is changed by this patch - that's not possible. We need to maintain backward compatibility at the API level. One way to address would be to introduce a new "zookeeper_init_with_strategy(....)" or some such new method. However we cannot change the existing API.

          Show
          Patrick Hunt added a comment - While resolving the recent conflict I noticed that zookeeper_init signature is changed by this patch - that's not possible. We need to maintain backward compatibility at the API level. One way to address would be to introduce a new "zookeeper_init_with_strategy(....)" or some such new method. However we cannot change the existing API.
          Hide
          Patrick Hunt added a comment -

          Fixed the conflict, otw no significant changes.

          Show
          Patrick Hunt added a comment - Fixed the conflict, otw no significant changes.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12483681/ZOOKEEPER-781.patch
          against trunk revision 1148553.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 18 new or modified tests.

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/401//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12483681/ZOOKEEPER-781.patch against trunk revision 1148553. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 18 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/401//console This message is automatically generated.
          Hide
          Qian Ye added a comment -

          Hi Mahadev, I could not find the reason for the failure, the test ran well on my local server

          Show
          Qian Ye added a comment - Hi Mahadev, I could not find the reason for the failure, the test ran well on my local server
          Hide
          Mahadev konar added a comment -

          Qian,
          Any update on this?

          Show
          Mahadev konar added a comment - Qian, Any update on this?
          Hide
          Camille Fournier added a comment -

          [exec] [exec] ./zktest-mt
          [exec] [exec] ZooKeeper server startedRunning
          ...
          [exec] [exec] Zookeeper_simpleSystem::testChroot : elapsed 3016 : OK
          [exec] [exec] Zookeeper_simpleSystem::testAuth ZooKeeper server started ZooKeeper server started : elapsed 31369 : OK
          Build timed out (after 62 minutes). Marking the build as aborted.

          Looks like the mt_c build timed out. Dunno if this is your error, or one of the bugs in the auth portion of the ZK C client that we recently discovered rearing its ugly head.

          Show
          Camille Fournier added a comment - [exec] [exec] ./zktest-mt [exec] [exec] ZooKeeper server startedRunning ... [exec] [exec] Zookeeper_simpleSystem::testChroot : elapsed 3016 : OK [exec] [exec] Zookeeper_simpleSystem::testAuth ZooKeeper server started ZooKeeper server started : elapsed 31369 : OK Build timed out (after 62 minutes). Marking the build as aborted. Looks like the mt_c build timed out. Dunno if this is your error, or one of the bugs in the auth portion of the ZK C client that we recently discovered rearing its ugly head.
          Hide
          Qian Ye added a comment -

          I could not find which test is failed by the patch, somebody help me?

          Show
          Qian Ye added a comment - I could not find which test is failed by the patch, somebody help me?
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12483681/ZOOKEEPER-781.patch
          against trunk revision 1138958.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 18 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/351//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/351//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/351//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12483681/ZOOKEEPER-781.patch against trunk revision 1138958. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 18 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/351//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/351//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/351//console This message is automatically generated.
          Hide
          Qian Ye added a comment -

          fix some test failure

          Show
          Qian Ye added a comment - fix some test failure
          Hide
          Qian Ye added a comment -

          cancel for a new submit

          Show
          Qian Ye added a comment - cancel for a new submit
          Hide
          Qian Ye added a comment -

          re-attach

          Show
          Qian Ye added a comment - re-attach
          Hide
          Qian Ye added a comment -

          fix a test failure

          Show
          Qian Ye added a comment - fix a test failure
          Hide
          Andrei Savu added a comment -

          Would it be possible to use this mechanism to discover servers using a cloud provider API? (thinking about running ZooKeeper in EC2)

          Show
          Andrei Savu added a comment - Would it be possible to use this mechanism to discover servers using a cloud provider API? (thinking about running ZooKeeper in EC2)
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12483674/ZOOKEEPER-781.patch
          against trunk revision 1138958.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 18 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/350//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/350//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/350//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12483674/ZOOKEEPER-781.patch against trunk revision 1138958. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 18 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/350//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/350//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/350//console This message is automatically generated.
          Hide
          Qian Ye added a comment -

          A new patch for this issue

          Show
          Qian Ye added a comment - A new patch for this issue
          Hide
          Benjamin Reed added a comment -

          this looks promising, but it's not passing the tests. please resubmit when tests pass.

          Show
          Benjamin Reed added a comment - this looks promising, but it's not passing the tests. please resubmit when tests pass.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12471092/ZOOKEEPER-781.patch
          against trunk revision 1072085.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 18 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/170//testReport/
          Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/170//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/170//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12471092/ZOOKEEPER-781.patch against trunk revision 1072085. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 18 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/170//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/170//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/170//console This message is automatically generated.
          Hide
          Qian Ye added a comment -

          Thx Michi, I will take a look at it this week.

          Show
          Qian Ye added a comment - Thx Michi, I will take a look at it this week.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12471092/ZOOKEEPER-781.patch
          against trunk revision 1072085.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 18 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/151//testReport/
          Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/151//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/151//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12471092/ZOOKEEPER-781.patch against trunk revision 1072085. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 18 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/151//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/151//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/151//console This message is automatically generated.
          Hide
          Michi Mutsuzaki (Inactive) added a comment -

          It looks like a compilation error in C client. Qian, could you take a look?

          Thanks!
          --Michi

          /PreCommit-ZOOKEEPER-Build/trunk/src/c/generated -DUSE_STATIC_LIB -DZKSERVER_CMD="\"/grid/0/hudson/hudson-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/src/c/tests/zkServer.sh\"" -DZOO_IPV6_ENABLED -g -O2 -MT zktest_st-TestClient.o -MD -MP -MF .deps/zktest_st-TestClient.Tpo -c -o zktest_st-TestClient.o `test -f 'tests/TestClient.cc' || echo '/grid/0/hudson/hudson-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/src/c/'`tests/TestClient.cc
          [exec] [exec] /grid/0/hudson/hudson-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/src/c/include/zookeeper.h: In member function 'zhandle_t* Zookeeper_simpleSystem::createClient(const char*, watchctx_t*)':
          [exec] [exec] /grid/0/hudson/hudson-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/src/c/include/zookeeper.h:353: error: too many arguments to function 'zhandle_t* zookeeper_init(const char*, void (zhandle_t*, int, int, const char*, void*), int, const clientid_t*, void*, int (int, int*, sockaddr_storage*), int (int, int*, sockaddr_storage*), int)'
          [exec] [exec] /grid/0/hudson/hudson-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/src/c/tests/TestClient.cc:234: error: at this point in file
          [exec] [exec] /grid/0/hudson/hudson-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/src/c/include/zookeeper.h: In member function 'zhandle_t* Zookeeper_simpleSystem::createchClient(watchctx_t*, const char*)':
          [exec] [exec] /grid/0/hudson/hudson-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/src/c/include/zookeeper.h:353: error: too many arguments to function 'zhandle_t* zookeeper_init(const char*, void (zhandle_t*, int, int, const char*, void*), int, const clientid_t*, void*, int (int, int*, sockaddr_storage*), int (int, int*, sockaddr_storage*), int)'
          [exec] [exec] /grid/0/hudson/hudson-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/src/c/tests/TestClient.cc:241: error: at this point in file
          [exec] [exec] make[1]: Leaving directory `/grid/0/hudson/hudson-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build/test/test-cppunit'
          [exec] [exec] make[1]: *** [zktest_st-TestClient.o] Error 1
          [exec] [exec] make: *** [check-am] Error 2
          [exec]

          Show
          Michi Mutsuzaki (Inactive) added a comment - It looks like a compilation error in C client. Qian, could you take a look? Thanks! --Michi /PreCommit-ZOOKEEPER-Build/trunk/src/c/generated -DUSE_STATIC_LIB -DZKSERVER_CMD="\"/grid/0/hudson/hudson-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/src/c/tests/zkServer.sh\"" -DZOO_IPV6_ENABLED -g -O2 -MT zktest_st-TestClient.o -MD -MP -MF .deps/zktest_st-TestClient.Tpo -c -o zktest_st-TestClient.o `test -f 'tests/TestClient.cc' || echo '/grid/0/hudson/hudson-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/src/c/'`tests/TestClient.cc [exec] [exec] /grid/0/hudson/hudson-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/src/c/include/zookeeper.h: In member function 'zhandle_t* Zookeeper_simpleSystem::createClient(const char*, watchctx_t*)': [exec] [exec] /grid/0/hudson/hudson-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/src/c/include/zookeeper.h:353: error: too many arguments to function 'zhandle_t* zookeeper_init(const char*, void (zhandle_t*, int, int, const char*, void*), int, const clientid_t*, void*, int (int, int*, sockaddr_storage*), int (int, int*, sockaddr_storage*), int)' [exec] [exec] /grid/0/hudson/hudson-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/src/c/tests/TestClient.cc:234: error: at this point in file [exec] [exec] /grid/0/hudson/hudson-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/src/c/include/zookeeper.h: In member function 'zhandle_t* Zookeeper_simpleSystem::createchClient(watchctx_t*, const char*)': [exec] [exec] /grid/0/hudson/hudson-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/src/c/include/zookeeper.h:353: error: too many arguments to function 'zhandle_t* zookeeper_init(const char*, void (zhandle_t*, int, int, const char*, void*), int, const clientid_t*, void*, int (int, int*, sockaddr_storage*), int (int, int*, sockaddr_storage*), int)' [exec] [exec] /grid/0/hudson/hudson-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/src/c/tests/TestClient.cc:241: error: at this point in file [exec] [exec] make [1] : Leaving directory `/grid/0/hudson/hudson-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build/test/test-cppunit' [exec] [exec] make [1] : *** [zktest_st-TestClient.o] Error 1 [exec] [exec] make: *** [check-am] Error 2 [exec]
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12471092/ZOOKEEPER-781.patch
          against trunk revision 1069169.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 18 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/131//testReport/
          Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/131//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/131//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12471092/ZOOKEEPER-781.patch against trunk revision 1069169. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 18 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/131//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/131//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/131//console This message is automatically generated.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12464959/ZOOKEEPER-781.patch
          against trunk revision 1055924.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 18 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 findbugs. The patch appears to introduce 9 new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/96//testReport/
          Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/96//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/96//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12464959/ZOOKEEPER-781.patch against trunk revision 1055924. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 18 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 9 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/96//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/96//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/96//console This message is automatically generated.
          Hide
          Mahadev konar added a comment -

          Qian,
          Does seem like something wrong with hudson. Pat and myself are taking a look at it .

          thanks

          Show
          Mahadev konar added a comment - Qian, Does seem like something wrong with hudson. Pat and myself are taking a look at it . thanks
          Hide
          Qian Ye added a comment -

          Hi all, is there any wrong with hudson? We have tried several times to make the patch be applied.

          Show
          Qian Ye added a comment - Hi all, is there any wrong with hudson? We have tried several times to make the patch be applied.
          Hide
          Mahadev konar added a comment -

          trying again for hudson. Qian, sometimes the QA bot gets wedged. trying again!

          Show
          Mahadev konar added a comment - trying again for hudson. Qian, sometimes the QA bot gets wedged. trying again!
          Hide
          Qian Ye added a comment -

          To Patrick, I've resubmited my patch, but there is no automatic build result from Hadoop QA. Did I miss something?

          Show
          Qian Ye added a comment - To Patrick, I've resubmited my patch, but there is no automatic build result from Hadoop QA. Did I miss something?
          Hide
          Qian Ye added a comment -

          a new patch fix a path issue

          Show
          Qian Ye added a comment - a new patch fix a path issue
          Hide
          Qian Ye added a comment -

          cancel patch for the new one

          Show
          Qian Ye added a comment - cancel patch for the new one
          Hide
          Patrick Hunt added a comment -

          Typically you would cancel the patch, upload a new attachment, then resubmit the patch. (you don't necessarily need to follow that order...)

          Show
          Patrick Hunt added a comment - Typically you would cancel the patch, upload a new attachment, then resubmit the patch. (you don't necessarily need to follow that order...)
          Hide
          Qian Ye added a comment -

          a question about patch. the applied source path in the last version of the patch is wrong. I fixed this problem in the new patch. However, I found that "Available Workflow Actions" contains only three actions: Cancel Patch, Resolve Issue, Resume Progress. Which one should I use to test my new patch? Thanks.

          Show
          Qian Ye added a comment - a question about patch. the applied source path in the last version of the patch is wrong. I fixed this problem in the new patch. However, I found that "Available Workflow Actions" contains only three actions: Cancel Patch, Resolve Issue, Resume Progress. Which one should I use to test my new patch? Thanks.
          Hide
          Qian Ye added a comment -

          to Thomas: thanks for the info, I will check it out when I modify the java client

          Show
          Qian Ye added a comment - to Thomas: thanks for the info, I will check it out when I modify the java client
          Hide
          Qian Ye added a comment -

          fix the path error in the pervious patch

          Show
          Qian Ye added a comment - fix the path error in the pervious patch
          Hide
          Thomas Koch added a comment -

          Hi,

          in ZOOKEEPER-836 I introduced a HostProvider interface for the java client. Different connection strategies could be implemented as instances of this interface.

          Show
          Thomas Koch added a comment - Hi, in ZOOKEEPER-836 I introduced a HostProvider interface for the java client. Different connection strategies could be implemented as instances of this interface.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12460486/ZOOKEEPER-781.patch
          against trunk revision 1038827.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 18 new or modified tests.

          -1 patch. The patch command could not apply the patch.

          Console output: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/52//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12460486/ZOOKEEPER-781.patch against trunk revision 1038827. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 18 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/52//console This message is automatically generated.
          Hide
          Qian Ye added a comment -

          add a draft patch for c client. Here, I add two function prototypes to support the strategy pattern. The conn_chooser_fn is used to initialize the hosts list, before the prime connection, and the conn_picker_fn is used to descide which hosts will be used in the next connection.

          typedef int (*conn_chooser_fn)(int addrs_count, int *connect_index,
          struct sockaddr_storage *addrs);

          typedef int (*conn_picker_fn)(int addrs_count, int *connect_index,
          struct sockaddr_storage *addrs);

          the patch provide two build-in strategies, which support ordered round robin and randomized round robin like the previous version. Programmers can set their own chooser and piccker when they initalize the zookeeper handler.

          Show
          Qian Ye added a comment - add a draft patch for c client. Here, I add two function prototypes to support the strategy pattern. The conn_chooser_fn is used to initialize the hosts list, before the prime connection, and the conn_picker_fn is used to descide which hosts will be used in the next connection. typedef int (*conn_chooser_fn)(int addrs_count, int *connect_index, struct sockaddr_storage *addrs); typedef int (*conn_picker_fn)(int addrs_count, int *connect_index, struct sockaddr_storage *addrs); the patch provide two build-in strategies, which support ordered round robin and randomized round robin like the previous version. Programmers can set their own chooser and piccker when they initalize the zookeeper handler.

            People

            • Assignee:
              Qian Ye
              Reporter:
              Patrick Hunt
            • Votes:
              2 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:

                Development