ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-772

zkpython segfaults when watcher from async get children is invoked.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.3.2, 3.4.0
    • Component/s: contrib-bindings
    • Labels:
      None
    • Environment:

      ubuntu lucid (10.04) / zk trunk

    • Hadoop Flags:
      Reviewed

      Description

      When utilizing the zkpython async get children api with a watch, i consistently get segfaults when the watcher is invoked to process events.

      1. asyncgetchildren.py
        1 kB
        Kapil Thangavelu
      2. zkpython-testasyncgetchildren.diff
        1 kB
        Kapil Thangavelu
      3. ZOOKEEPER-772.patch
        2 kB
        Henry Robinson
      4. ZOOKEEPER-772.patch
        2 kB
        Henry Robinson

        Activity

        Hide
        Kapil Thangavelu added a comment -

        script that segfaults with async get children watcher, when the watcher is invoked.

        Show
        Kapil Thangavelu added a comment - script that segfaults with async get children watcher, when the watcher is invoked.
        Hide
        Kapil Thangavelu added a comment -

        segfault script as patch for zkpython unit tests.

        Show
        Kapil Thangavelu added a comment - segfault script as patch for zkpython unit tests.
        Hide
        Henry Robinson added a comment -

        Bug was simple when I got round to looking - was incorrectly reusing a watcher that was getting deallocated before getting called.

        Show
        Henry Robinson added a comment - Bug was simple when I got round to looking - was incorrectly reusing a watcher that was getting deallocated before getting called.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12444744/ZOOKEEPER-772.patch
        against trunk revision 944515.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        -1 patch. The patch command could not apply the patch.

        Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/94/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12444744/ZOOKEEPER-772.patch against trunk revision 944515. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/94/console This message is automatically generated.
        Hide
        Henry Robinson added a comment -

        --no-prefix, predictably.

        Show
        Henry Robinson added a comment - --no-prefix, predictably.
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12444746/ZOOKEEPER-772.patch
        against trunk revision 944515.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/95/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/95/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/95/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12444746/ZOOKEEPER-772.patch against trunk revision 944515. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/95/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/95/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/95/console This message is automatically generated.
        Hide
        Patrick Hunt added a comment -

        +1, thanks Henry!

        Show
        Patrick Hunt added a comment - +1, thanks Henry!
        Hide
        Hudson added a comment -

        Integrated in ZooKeeper-trunk #831 (See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/831/)

        Show
        Hudson added a comment - Integrated in ZooKeeper-trunk #831 (See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/831/ )
        Hide
        Kapil Thangavelu added a comment -

        Can this patch be applied on the 3.3 branch as well?

        Show
        Kapil Thangavelu added a comment - Can this patch be applied on the 3.3 branch as well?
        Hide
        Patrick Hunt added a comment -

        sounds reasonable to me, I believe this issue was committed before 3.3.2 was identified. adding 3.3.2, someone will need to apply to 3.3 branch.

        Show
        Patrick Hunt added a comment - sounds reasonable to me, I believe this issue was committed before 3.3.2 was identified. adding 3.3.2, someone will need to apply to 3.3 branch.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12444746/ZOOKEEPER-772.patch
        against trunk revision 980576.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        -1 patch. The patch command could not apply the patch.

        Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/105/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12444746/ZOOKEEPER-772.patch against trunk revision 980576. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/105/console This message is automatically generated.
        Hide
        Mahadev konar added a comment -

        Luckily the 3.4 patch applies to 3.3 branch. I just committed this. thanks henry!

        Show
        Mahadev konar added a comment - Luckily the 3.4 patch applies to 3.3 branch. I just committed this. thanks henry!

          People

          • Assignee:
            Henry Robinson
            Reporter:
            Kapil Thangavelu
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development