[ZOOKEEPER-758] zkpython segfaults on invalid acl with missing key

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.3.0, 3.4.0
• Fix Version/s: 3.3.1, 3.4.0
• Component/s: contrib-bindings

Environment

ubuntu lucid (10.04)

• Hadoop Flags: Reviewed
• Assignee: Kapil Thangavelu
• Reporter: Kapil Thangavelu
• Created: 29/Apr/10 01:28
• Updated: 23/Nov/11 19:22
• Resolved: 01/May/10 01:14

Description

Currently when setting an acl, there is a minimal parse to ensure that its a list of dicts, however if one of the dicts is missing a required key, the subsequent usage doesn't check for it, and will segfault.. for example using an acl of [

{"schema":id, "id":world, permissions:PERM_ALL}

] will segfault if used, because the scheme key is missing (its been purposefully typo'd to schema in example).

I've expanded the check_acl macro to include verifying that all keys are present and added some unit tests against trunk in the attachments.