Uploaded image for project: 'ZooKeeper'
  1. ZooKeeper
  2. ZOOKEEPER-756

some cleanup and improvements for zooinspector

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.3.0
    • Fix Version/s: 3.5.0
    • Component/s: contrib
    • Labels:
    • Hadoop Flags:
      Reviewed
    • Tags:
      zooinspector

      Description

      Copied from the already closed ZOOKEEPER-678:

      • specify the exact URL, where the icons are from. It's best to include the link also in the NOTICE.txt file.

      It seems, that zooinspector finds it's icons only if the icons folder is in the current path. But when I install zooinspector as part of the Zookeeper Debian package, I want to be able to call it regardless of the current path.
      Could you use getRessources or something so that I can point to the icons location from the wrapper shell script?

      Can I place the zooinspector config files in /etc/zookeeper/zooinspector/ ? Could I give zooinspector a property to point to the config file location?

      There are several places, where viewers is missspelled as "Veiwers". Please do a case insensitive search for "veiw" to correct these. Even the config file "defaultNodeVeiwers.cfg" is missspelled like this. This has the potential to confuse the hell out of people when debugging something!

        Attachments

        1. zooInspectorChanges.patch
          118 kB
          Colin Goodheart-Smithe
        2. ZOOKEEPER-756.patch
          376 kB
          Patrick Hunt
        3. zooInspectorChanges.patch
          116 kB
          Colin Goodheart-Smithe
        4. Zooinspector-patch.patch
          362 kB
          Colin Goodheart-Smithe
        5. ZOOKEEPER-756.patch
          92 kB
          Thomas Koch
        6. ZOOKEEPER-756.patch
          93 kB
          Thomas Koch
        7. icons.tar.gz
          42 kB
          Thomas Koch
        8. ZOOKEEPER-756.patch
          93 kB
          Thomas Koch
        9. ZOOKEEPER-756.patch
          93 kB
          Thomas Koch

          Activity

            People

            • Assignee:
              thkoch Thomas Koch
              Reporter:
              thkoch Thomas Koch
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: