Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.4.0
    • Fix Version/s: 3.4.0
    • Component/s: server
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Release Note:
      Added new 4letter word for monitoring: "mntr" The output is compatible with the Java properties format.Your script should expect content changes: new keys could be added in the future.
    • Tags:
      zookeeper monitoring

      Description

      Filing a feature request based on a zookeeper-user discussion.

      Zookeeper should have a new four-letter word that returns key-value pairs appropriate for importing to a monitoring system (such as Ganglia which has a large installed base)

      This command should initially export the following:

      (a) Count of instances in the ensemble.
      (b) Count of up-to-date instances in the ensemble.

      But be designed such that in the future additional data can be added. For example, the output could define the statistic in a comment, then print a key "space character" value line:

      """

      1. Total number of instances in the ensemble
        zk_ensemble_instances_total 5
      2. Number of instances currently participating in the quorum.
        zk_ensemble_instances_active 4
        """

      From the mailing list:

      """
      Date: Mon, 19 Apr 2010 12:10:44 -0700
      From: Patrick Hunt <phunt@apache.org>
      To: zookeeper-user@hadoop.apache.org
      Subject: Re: Recovery issue - how to debug?

      On 04/19/2010 11:55 AM, Travis Crawford wrote:
      > It would be a lot easier from the operations perspective if the leader
      > explicitly published some health stats:
      >
      > (a) Count of instances in the ensemble.
      > (b) Count of up-to-date instances in the ensemble.
      >
      > This would greatly simplify monitoring& alerting - when an instance
      > falls behind one could configure their monitoring system to let
      > someone know and take a look at the logs.

      That's a great idea. Please enter a JIRA for this - a new 4 letter word
      and JMX support. It would also be a great starter project for someone
      interested in becoming more familiar with the server code.

      Patrick
      """

      1. ZOOKEEPER-744.patch
        8 kB
        Andrei Savu
      2. ZOOKEEPER-744.patch
        9 kB
        Andrei Savu
      3. ZOOKEEPER-744.patch
        14 kB
        Andrei Savu
      4. ZOOKEEPER-744.patch
        13 kB
        Patrick Hunt
      5. zk-ganglia.png
        196 kB
        Travis Crawford

        Issue Links

          Activity

          Hide
          Travis Crawford added a comment -

          Attaching a Ganglia screen capture showing an example of how this data would be used. Many monitoring systems have a way to collect & store timeseries data; exporting these data as easily-parsable plaintext will make writing importers to any monitoring system easy.

          Show
          Travis Crawford added a comment - Attaching a Ganglia screen capture showing an example of how this data would be used. Many monitoring systems have a way to collect & store timeseries data; exporting these data as easily-parsable plaintext will make writing importers to any monitoring system easy.
          Hide
          Mahadev konar added a comment -

          thats cool !!!!

          Show
          Mahadev konar added a comment - thats cool !!!!
          Hide
          Andrei Savu added a comment -

          Added one more 4letter word for monitoring: mntr

          Output:
          $ echo mntr | nc localhost 2185

          zk_version 3.4.0--1, built on 05/24/2010 12:38 GMT
          zk_avg_latency 0
          zk_max_latency 0
          zk_min_latency 0
          zk_packets_received 70
          zk_packets_sent 69
          zk_outstanding_requests 0
          zk_server_state leader
          zk_node_count 4
          zk_watch_count 0
          zk_ephemerals_count 0
          zk_approximate_data_size 27
          zk_followers 4
          zk_synced_followers 4
          zk_pending_syncs 0

          What else should I add here?

          Show
          Andrei Savu added a comment - Added one more 4letter word for monitoring: mntr Output: $ echo mntr | nc localhost 2185 zk_version 3.4.0--1, built on 05/24/2010 12:38 GMT zk_avg_latency 0 zk_max_latency 0 zk_min_latency 0 zk_packets_received 70 zk_packets_sent 69 zk_outstanding_requests 0 zk_server_state leader zk_node_count 4 zk_watch_count 0 zk_ephemerals_count 0 zk_approximate_data_size 27 zk_followers 4 zk_synced_followers 4 zk_pending_syncs 0 What else should I add here?
          Hide
          Patrick Hunt added a comment -

          Looks good so far. You should update the forrest docs as part of this change, you should detail the format at least (and expectation that order is not maintained, etc...), that this is compatible with java properties format, the content may change (keys added) over time, etc... That way a user will better understand how to integrate and have a reasonable expectation of b/w compatibliity, implementers will also have insight into how they can change this command over time. We didn't do a good job with this for the other commands, but since this is new and intended for integration into third party tools (vs a human always looking at the results) it's a good idea to add. You should add this command to the Tests as well.

          Show
          Patrick Hunt added a comment - Looks good so far. You should update the forrest docs as part of this change, you should detail the format at least (and expectation that order is not maintained, etc...), that this is compatible with java properties format, the content may change (keys added) over time, etc... That way a user will better understand how to integrate and have a reasonable expectation of b/w compatibliity, implementers will also have insight into how they can change this command over time. We didn't do a good job with this for the other commands, but since this is new and intended for integration into third party tools (vs a human always looking at the results) it's a good idea to add. You should add this command to the Tests as well.
          Hide
          Travis Crawford added a comment -

          Looks awesome! One nit – many monitoring systems do not interpret strings so it may be appropriate to export everything as numbers. For example, consider a script that loops through these values poking them into Ganglia (or other timeseries database). The script would need special-cased to handle "leader". Later, as more values are added the import script would need updated with the new strings. Doing everything as numbers ensures new values would "just work" without updating other systems.

          With that in mind, perhaps:

          zk_server_state 1 (instead of: leader)
          zk_build_timestamp unix_timestamp (instead of build string)

          Show
          Travis Crawford added a comment - Looks awesome! One nit – many monitoring systems do not interpret strings so it may be appropriate to export everything as numbers. For example, consider a script that loops through these values poking them into Ganglia (or other timeseries database). The script would need special-cased to handle "leader". Later, as more values are added the import script would need updated with the new strings. Doing everything as numbers ensures new values would "just work" without updating other systems. With that in mind, perhaps: zk_server_state 1 (instead of: leader) zk_build_timestamp unix_timestamp (instead of build string)
          Hide
          Andrei Savu added a comment -

          I have fixed the patch: changed forrest docs and added tests.

          @Travis: I believe your script should do some sort of filtering / format. Is it really a good idea to just throw any output in Ganglia?

          PS: sorry for the late answer, I had some problems with forrest and java1.6

          Show
          Andrei Savu added a comment - I have fixed the patch: changed forrest docs and added tests. @Travis: I believe your script should do some sort of filtering / format. Is it really a good idea to just throw any output in Ganglia? PS: sorry for the late answer, I had some problems with forrest and java1.6
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12445586/ZOOKEEPER-744.patch
          against trunk revision 947063.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 8 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/109/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/109/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/109/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12445586/ZOOKEEPER-744.patch against trunk revision 947063. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 8 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/109/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/109/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/109/console This message is automatically generated.
          Hide
          Travis Crawford added a comment -

          @savu - Sometimes the "right" thing is publishing everything, sometimes not. In this case I'll have some filtering/formatting in the zk2ganglia script.

          Show
          Travis Crawford added a comment - @savu - Sometimes the "right" thing is publishing everything, sometimes not. In this case I'll have some filtering/formatting in the zk2ganglia script.
          Hide
          Andrei Savu added a comment -

          I have added two more keys:

          zk_open_file_descriptor_count 23
          zk_max_file_descriptor_count 1024

          @Travis could you post the zk2ganglia script?

          Show
          Andrei Savu added a comment - I have added two more keys: zk_open_file_descriptor_count 23 zk_max_file_descriptor_count 1024 @Travis could you post the zk2ganglia script?
          Hide
          Patrick Hunt added a comment -

          Andrei, are you are still working on this or should I review for commit?

          Show
          Patrick Hunt added a comment - Andrei, are you are still working on this or should I review for commit?
          Hide
          Andrei Savu added a comment -

          You can review the patch for commit. Right know I'm writing monitoring scripts for Nagios, Cacti and Ganglia (in this order). The script for nagios is almost ready. Thanks.

          original message
          Subject: [jira] Commented: (ZOOKEEPER-744) Add monitoring four-letter word
          From: "Patrick Hunt (JIRA)" <jira@apache.org>
          Date: 01/06/2010 19:07

          [ https://issues.apache.org/jira/browse/ZOOKEEPER-744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12874111#action_12874111 ]

          Patrick Hunt commented on ZOOKEEPER-744:
          ----------------------------------------

          Andrei, are you are still working on this or should I review for commit?


          This message is automatically generated by JIRA.
          -
          You can reply to this email to add a comment to the issue online.

          Show
          Andrei Savu added a comment - You can review the patch for commit. Right know I'm writing monitoring scripts for Nagios, Cacti and Ganglia (in this order). The script for nagios is almost ready. Thanks. original message Subject: [jira] Commented: ( ZOOKEEPER-744 ) Add monitoring four-letter word From: "Patrick Hunt (JIRA)" <jira@apache.org> Date: 01/06/2010 19:07 [ https://issues.apache.org/jira/browse/ZOOKEEPER-744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12874111#action_12874111 ] Patrick Hunt commented on ZOOKEEPER-744 : ---------------------------------------- Andrei, are you are still working on this or should I review for commit? – This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12445822/ZOOKEEPER-744.patch
          against trunk revision 947063.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 8 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/112/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/112/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/112/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12445822/ZOOKEEPER-744.patch against trunk revision 947063. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 8 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/112/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/112/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/112/console This message is automatically generated.
          Hide
          Patrick Hunt added a comment -

          Andrei, looks good, a few comments while reviewing the patch:

          1) indicate in the docs that not all keys are available on all platforms (fd count only on unix for example)
          2) change "node_count" to "znode_count" (reduce confusion btw serving nodes and znodes)
          3) your implementation of ephemeral counting:
          org.apache.zookeeper.server.DataTree.getEphemeralsCount()
          is inefficient, use entrySet instead (rather than keyset)
          4) take a look at how ephemeral counting is done here:
          org.apache.zookeeper.server.DataTreeBean.countEphemerals()
          You might use refactor to use this code in both places.
          5) watch_count is only counting the number of paths that are watched, not the total number of watches (a path may have multiple watches - ie multiple sessions watching the same path)
          Looks like this is a bug in the existing implementation (currently only exposed in the bean). You should fix this. Add a test for this while you are at it to verify correct counting.
          6) good that you capture the quorum info, is there a way to capture the date/time of the last election?

          Show
          Patrick Hunt added a comment - Andrei, looks good, a few comments while reviewing the patch: 1) indicate in the docs that not all keys are available on all platforms (fd count only on unix for example) 2) change "node_count" to "znode_count" (reduce confusion btw serving nodes and znodes) 3) your implementation of ephemeral counting: org.apache.zookeeper.server.DataTree.getEphemeralsCount() is inefficient, use entrySet instead (rather than keyset) 4) take a look at how ephemeral counting is done here: org.apache.zookeeper.server.DataTreeBean.countEphemerals() You might use refactor to use this code in both places. 5) watch_count is only counting the number of paths that are watched, not the total number of watches (a path may have multiple watches - ie multiple sessions watching the same path) Looks like this is a bug in the existing implementation (currently only exposed in the bean). You should fix this. Add a test for this while you are at it to verify correct counting. 6) good that you capture the quorum info, is there a way to capture the date/time of the last election?
          Hide
          Andrei Savu added a comment -

          Thanks for reviewing. I will resubmit the patch today.


          Savu Andrei

          Website: http://www.andreisavu.ro/

          Show
          Andrei Savu added a comment - Thanks for reviewing. I will resubmit the patch today. – Savu Andrei Website: http://www.andreisavu.ro/
          Hide
          Andrei Savu added a comment -

          @Patrick I have fixed 1-5. I will resubmit the patch after writing some tests to ensure that the node watch count works as expected (I'm having some problems with this part). Right now all tests are passing.

          6. I believe the leader does not record the time of the last election. I will look more into this and change the code as needed.

          Should I also add JVM memory stats?

          Show
          Andrei Savu added a comment - @Patrick I have fixed 1-5. I will resubmit the patch after writing some tests to ensure that the node watch count works as expected (I'm having some problems with this part). Right now all tests are passing. 6. I believe the leader does not record the time of the last election. I will look more into this and change the code as needed. Should I also add JVM memory stats?
          Hide
          Patrick Hunt added a comment -

          iirc 6 is in the jmx intf, perhaps that captures the election time itself, take a look, perhaps it needs to be moved out to the election object itself.

          Show
          Patrick Hunt added a comment - iirc 6 is in the jmx intf, perhaps that captures the election time itself, take a look, perhaps it needs to be moved out to the election object itself.
          Hide
          Andrei Savu added a comment -

          I've updated the patch and added a new the test for getWatchCount(). I'm not yet recording the time of the last election, I'm thinking about open a JIRA later for this. I want to move on and work on ZOOKEEPER-613.

          Show
          Andrei Savu added a comment - I've updated the patch and added a new the test for getWatchCount(). I'm not yet recording the time of the last election, I'm thinking about open a JIRA later for this. I want to move on and work on ZOOKEEPER-613 .
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12447082/ZOOKEEPER-744.patch
          against trunk revision 953041.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 16 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/116/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/116/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/116/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12447082/ZOOKEEPER-744.patch against trunk revision 953041. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 16 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/116/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/116/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/116/console This message is automatically generated.
          Hide
          Patrick Hunt added a comment -

          Updated patch to fix indentation.

          Andrei, please update your editor (eclipse?) to use spaces only, no tabs for indentation.

          Show
          Patrick Hunt added a comment - Updated patch to fix indentation. Andrei, please update your editor (eclipse?) to use spaces only, no tabs for indentation.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12448091/ZOOKEEPER-744.patch
          against trunk revision 958096.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 12 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/121/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/121/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/121/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12448091/ZOOKEEPER-744.patch against trunk revision 958096. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 12 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/121/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/121/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/121/console This message is automatically generated.
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12448091/ZOOKEEPER-744.patch
          against trunk revision 958096.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 12 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/122/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/122/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/122/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12448091/ZOOKEEPER-744.patch against trunk revision 958096. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 12 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/122/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/122/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/122/console This message is automatically generated.
          Hide
          Patrick Hunt added a comment -

          +1, thanks Andrei!

          Show
          Patrick Hunt added a comment - +1, thanks Andrei!
          Hide
          Andrei Savu added a comment -

          Thanks for reviewing.

          Show
          Andrei Savu added a comment - Thanks for reviewing.
          Hide
          Hudson added a comment -

          Integrated in ZooKeeper-trunk #869 (See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/869/)
          ZOOKEEPER-744. Add monitoring four-letter word

          Show
          Hudson added a comment - Integrated in ZooKeeper-trunk #869 (See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/869/ ) ZOOKEEPER-744 . Add monitoring four-letter word

            People

            • Assignee:
              Andrei Savu
              Reporter:
              Travis Crawford
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development