[ZOOKEEPER-722] zkServer.sh uses sh's builtin echo on BSD, behaves incorrectly.

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.3.0
• Fix Version/s: 3.3.1, 3.4.0
• Component/s: scripts

Environment

Mac OS X

• Hadoop Flags: Reviewed
• Release Note: Fix zkServer.sh script for BSD systems.
• Assignee: Ivan Kelly
• Reporter: Ivan Kelly
• Created: 22/Mar/10 14:49
• Updated: 23/Nov/11 19:22
• Resolved: 12/Apr/10 06:33

Description

zkServer.sh output the PID of the zookeeper process with:
echo -n $! > "$ZOOPIDFILE"

This uses -n which sh's builtin echo does not support. From echo's manpage.
<snip>
Some shells may provide a builtin echo command which is similar or identical to this utility. Most notably, the builtin echo in sh(1) does not accept
the -n option. Consult the builtin(1) manual page.
</snip>

This means that echo -n PID > ZOOPIDFILE will mean the contents of ZOOPIDFILE will be "-n PID". This stops zkServer.sh stop from working correctly.