Uploaded image for project: 'ZooKeeper'
  1. ZooKeeper
  2. ZOOKEEPER-722

zkServer.sh uses sh's builtin echo on BSD, behaves incorrectly.

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.3.0
    • Fix Version/s: 3.3.1, 3.4.0
    • Component/s: scripts
    • Labels:
      None
    • Environment:

      Mac OS X

    • Hadoop Flags:
      Reviewed
    • Release Note:
      Fix zkServer.sh script for BSD systems.

      Description

      zkServer.sh output the PID of the zookeeper process with:
      echo -n $! > "$ZOOPIDFILE"

      This uses -n which sh's builtin echo does not support. From echo's manpage.
      <snip>
      Some shells may provide a builtin echo command which is similar or identical to this utility. Most notably, the builtin echo in sh(1) does not accept
      the -n option. Consult the builtin(1) manual page.
      </snip>

      This means that echo -n PID > ZOOPIDFILE will mean the contents of ZOOPIDFILE will be "-n PID". This stops zkServer.sh stop from working correctly.

        Attachments

        1. zk-722.diff
          0.4 kB
          Ivan Kelly

          Activity

            People

            • Assignee:
              ikelly Ivan Kelly
              Reporter:
              ikelly Ivan Kelly
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: